Issue metadata
Sign in to add a comment
|
A zero-to-nonzero to 4.1% regression in browser_tests at 440308:440315 |
||||||||||||||||||||
Issue descriptionIt looks like that the regression is related to https://chromium.googlesource.com/chromium/src/+/4ecbf8fa2be4b989c37258a7038003cf4cd6dbd7 Send to emircan@ to take a look.
,
Jan 3 2017
It looks like it falls back to SW encoder on these platforms, see goog_avg_encode_ms for reference. This is due to setting 3840x2176 as the max supported resolution. I will make a CL to try two resolutions.
,
Jan 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/363636b03eecfabd90f14f05ec3e1baf1d94d469 commit 363636b03eecfabd90f14f05ec3e1baf1d94d469 Author: emircan <emircan@chromium.org> Date: Thu Jan 05 00:22:41 2017 Add optional max supported resolution on MediaFoundationVideoEncodeAccelerator This CL is a followup to https://codereview.chromium.org/2576073002. Before reporting the max supported resolution for MFVEA, we test initializing a session to make sure that it is not falsely reported. 1080p is the max resolution reported by the documentation, and recently we found out that some systems can support 2160p. Earlier CL set 2160p as the max resolution to be tested, however based on drivers and hardware some systems do not support it, see 677003. This CL modifies the check such that 1080p is tested first and optional resolutions follow. This increases the time GetSupportedProfiles() takes from ~40 ms to ~50 ms on Lenovo P50. BUG= 590060 , 677003 TEST=Tested AppRTC loopback with H264. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2615513003 Cr-Commit-Position: refs/heads/master@{#441525} [modify] https://crrev.com/363636b03eecfabd90f14f05ec3e1baf1d94d469/media/gpu/media_foundation_video_encode_accelerator_win.cc [modify] https://crrev.com/363636b03eecfabd90f14f05ec3e1baf1d94d469/media/gpu/media_foundation_video_encode_accelerator_win.h
,
Jan 5 2017
,
Jan 5 2017
The graphs have recovered after the fix. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by minyue@chromium.org
, Dec 26 2016