History and Reading list screen doesn't dismiss on tapping “esc” in bluetooth keyboard |
|||||
Issue descriptionApp Version: 57.0.2960.0 canary, iOS Version: 9.3.5, iOS 10 Device: iPad PreCondition : 1. Connect the Bluetooth keyboard to the device. 2. Enable Reading list from chrome experimental settings. Steps to reproduce: 1. Launch chrome. 2. Type in “ ⌘ Y “ in the bluetooth keyboard to open History dialog or Open Reading list from Menu > Reading list. 3. Tap on “esc” in bluetooth keyboard Observed results: History and Reading list screens are not dismissed. Expected results: History and Reading list screen should be dismissed. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: NA Bug reproducible on current stable build (App Version, iOS Version): Yes in M55.0.2883.79 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes in M56 Link to Video: https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpT3dYNXVVVEEwLWs/view?usp=sharing
,
Dec 27 2016
to gambard for RL. cc lpromero for keyboard commands.
,
Dec 28 2016
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58ad898ef55fa116c6b4a02387a68ac597cc28fe commit 58ad898ef55fa116c6b4a02387a68ac597cc28fe Author: gambard <gambard@chromium.org> Date: Wed Jan 04 12:57:11 2017 Escape on bluetooth keyboard closes the views Hitting the escape key on the bluetooth keyboard closes the history and the reading list views. BUG= 676994 Review-Url: https://codereview.chromium.org/2611543002 Cr-Commit-Position: refs/heads/master@{#441360} [modify] https://crrev.com/58ad898ef55fa116c6b4a02387a68ac597cc28fe/ios/chrome/browser/ui/history/BUILD.gn [modify] https://crrev.com/58ad898ef55fa116c6b4a02387a68ac597cc28fe/ios/chrome/browser/ui/history/history_panel_view_controller.mm [modify] https://crrev.com/58ad898ef55fa116c6b4a02387a68ac597cc28fe/ios/chrome/browser/ui/reading_list/BUILD.gn [modify] https://crrev.com/58ad898ef55fa116c6b4a02387a68ac597cc28fe/ios/chrome/browser/ui/reading_list/reading_list_view_controller.h [modify] https://crrev.com/58ad898ef55fa116c6b4a02387a68ac597cc28fe/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm [modify] https://crrev.com/58ad898ef55fa116c6b4a02387a68ac597cc28fe/ios/chrome/browser/ui/reading_list/reading_list_view_controller_container.mm
,
Jan 4 2017
,
Jan 10 2017
Verified on M57.0.2976.0 dev Device: iPad Pro iOS: 10.1.1 Hitting esc key on bluetooth keyboard dismisses the History and ReadingList dialogs. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by olivierrobin@chromium.org
, Dec 27 2016