New issue
Advanced search Search tips

Issue 676983 link

Starred by 2 users
Status: Fixed
Owner:
shimazu@chromium.org
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 738310
Blocking:
issue 668633



Sign in to add a comment

Guarantee that WorkerStopped is sent before ProviderDestroyed

Project Member Reported by falken@chromium.org, Dec 26 2016 
Background at  Issue 676526 .

When a worker stops we want to send WorkerStopped then ProviderDestroyed to the browser. WorkerStopped enables the browser to run the start/stop callbacks on ServiceWorkerVersion before ProviderDestroyed can teardown the ServiceWorkerProviderHost/ServiceWorkerVersion objects.

Or we could teach the browser to handle the reverse ordering somehow, but seems cleaner to just guarantee an ordering or possibly collapse the messages into one.

However I'm not sure a real bug is here since callers don't seem to care about the StopWorker callback. One problem might be that start callbacks are not invoked (in case a StopWorker interrupts a StartWorker). Also, it looks like most of the time the ordering is correct anyway.

Comment 1 by shimazu@chromium.org, Jan 13 2017

Status: Started (was: Available)
I've started creating a patch: https://codereview.chromium.org/2627413002.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b85dfb581ef764c8a02dbd803f54d0bbab1f318

commit 3b85dfb581ef764c8a02dbd803f54d0bbab1f318
Author: shimazu <shimazu@chromium.org>
Date: Tue Feb 21 13:03:30 2017

Manage ServiceWorkerDispatcherHost in ServiceWorkerContextCore

ServiceWorkerProviders for the service workers currently have the mesasge
ordering issue between ProviderDestroyed and WorkerStopped. Associating the
message pipes correctly will fix that. I'm planning to bind the
ServiceWorkerProvider interfaces with the channel's pipe for pages and with
the EmbeddedWorkerInstanceClient's pipe for service workers.

This is the first patch to introduce the associated provider hosts.
This patch
 - adds ServiceWorkerProviderHostInfo to send the params to SWDispatcherHost
 - manages SWDispatcherHost in SWContextCore
 - creates SWProviderHost by SWProviderHostInfo
 - removes three legacy IPC messages
   - ServiceWorkerHostMsg_ProviderCreated
   - ServiceWorkerHostMsg_ProviderDestroyed
   - ServiceWorkerHostMsg_SetVersionId

BUG=668633,  676983 ,  629701 

Review-Url: https://codereview.chromium.org/2638313002
Cr-Commit-Position: refs/heads/master@{#451745}

[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/embedded_worker_registry.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/embedded_worker_registry.h
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/foreign_fetch_request_handler_unittest.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/link_header_support_unittest.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_context_core.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_context_core.h
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_handle_unittest.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_request_handler_unittest.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_storage_unittest.cc
[add] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_test_utils.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_test_utils.h
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/child/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/child/service_worker/service_worker_network_provider.h
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/common/BUILD.gn
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/common/service_worker/OWNERS
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/common/service_worker/service_worker_messages.h
[add] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/common/service_worker/service_worker_provider.mojom
[add] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/common/service_worker/service_worker_provider.typemap
[add] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/common/service_worker/service_worker_provider_host_info.cc
[add] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/common/service_worker/service_worker_provider_host_info.h
[add] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/common/service_worker/service_worker_provider_struct_traits.cc
[add] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/common/service_worker/service_worker_provider_struct_traits.h
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/common/service_worker/service_worker_types.typemap
[add] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/common/service_worker/service_worker_types_struct_traits.cc
[rename] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/common/service_worker/service_worker_types_struct_traits.h
[delete] https://crrev.com/c183eaa3876b03b16c2c84e3dfb3b87b63071a5b/content/common/service_worker/service_worker_types_traits.cc
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/common/typemaps.gni
[modify] https://crrev.com/3b85dfb581ef764c8a02dbd803f54d0bbab1f318/content/test/BUILD.gn

Comment 3 by falken@chromium.org, Apr 19 2017

Blocking: 668633

Comment 4 by falken@chromium.org, Apr 19 2017

Labels: -Pri-3 Pri-1
(blink-worker triage) Raising priority since it blocks a Pri=1 bug.

Comment 5 by shimazu@chromium.org, May 26 2017

Labels: M-61
Two of CLs are under the review (one has already got LGTM, so it'll be landed after M60 branch)
https://crrev.com/2653493009
https://crrev.com/2779763004
Project Member

Comment 6 by bugdroid1@chromium.org, May 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4223216d2fa2a111c5e0636017bb6766682adda9

commit 4223216d2fa2a111c5e0636017bb6766682adda9
Author: shimazu <shimazu@chromium.org>
Date: Wed May 31 05:16:11 2017

Add two interfaces for ServiceWorkerProviderContext/ProviderHost

This patch introduces two mojom types: ServiceWorkerProviderHost and
ServiceWorkerProvider. They are currently used for managing the lifetime of
ServiceWorkerProviderHost from the renderer, but these interfaces will have
methods managing registrations, registration associated by the document and
controller.
These interfaces are now associated with SWDispatcherHost which is already bound
with the channel. After crrev.com/2779763004, interfaces for worker's context
will be associated with EWInstanceClient. This will solve the ordering issue
between messages of Stopped and ProviderDestroyed.

BUG= 629701 , 676983 ,668633

Review-Url: https://codereview.chromium.org/2653493009
Cr-Commit-Position: refs/heads/master@{#475809}

[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/foreign_fetch_request_handler_unittest.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/link_header_support_unittest.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_handle_unittest.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_navigation_handle_core.h
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_request_handler_unittest.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_test_utils.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_test_utils.h
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/child/service_worker/service_worker_dispatcher_unittest.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/child/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/child/service_worker/service_worker_network_provider.h
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/child/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/child/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/common/BUILD.gn
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/common/service_worker/service_worker_provider.mojom
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/common/service_worker/service_worker_provider_host_info.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/common/service_worker/service_worker_provider_host_info.h
[add] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/common/service_worker/service_worker_provider_interfaces.mojom
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/common/service_worker/service_worker_provider_struct_traits.cc
[modify] https://crrev.com/4223216d2fa2a111c5e0636017bb6766682adda9/content/common/service_worker/service_worker_provider_struct_traits.h
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d04d4a29a4f488d74e04bdc3133db1b72262462

commit 9d04d4a29a4f488d74e04bdc3133db1b72262462
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Wed Jun 07 01:23:34 2017

Fix LinkHeaderServiceWorkerTest to get the id from the provider host

This patch fixes LinkHeaderServiceWorkerTest to create the request for testing
with provider_id set to the provider host. This is necessary for browser-side
creation of ServiceWorkerProviderHost (https://crrev.com/2779763004) because ids
for providers for controllers are assigned on the browser side after it's
implemented.

R=falken@chromium.org

BUG:  629701 ,  676983 , 668633
Change-Id: Icdb3ac3da094db97ba355026249afe3c4a7ff1de
Reviewed-on: https://chromium-review.googlesource.com/523683
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477503}
[modify] https://crrev.com/9d04d4a29a4f488d74e04bdc3133db1b72262462/content/browser/service_worker/link_header_support_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/387a6b29a641d6721774f860c25fe85c47f821c0

commit 387a6b29a641d6721774f860c25fe85c47f821c0
Author: shimazu <shimazu@chromium.org>
Date: Mon Jun 12 07:09:12 2017

ServiceWorker: use the id assigned to the provider host in unittests

In several tests, currently provider's id is assigned to a variable which is
initialized by some random value at the beginning of the test, the provider host
instance is created by using the id, and some other objects are also initialized
by the id. After browser-side SWProviderHost creation, it'll be problematic
because the id will be assigned internally. This patch is to fix the tests by
getting the id from ServiceWorkerProviderHost::provider_id() directly.

This is split off from https://crrev.com/2779763004/ .

BUG= 629701 ,  676983 , 668633

Review-Url: https://codereview.chromium.org/2932273002
Cr-Commit-Position: refs/heads/master@{#478560}

[modify] https://crrev.com/387a6b29a641d6721774f860c25fe85c47f821c0/content/browser/service_worker/foreign_fetch_request_handler_unittest.cc
[modify] https://crrev.com/387a6b29a641d6721774f860c25fe85c47f821c0/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/387a6b29a641d6721774f860c25fe85c47f821c0/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f172ae8bad230163d337b8b07c9969232dc1d0d

commit 4f172ae8bad230163d337b8b07c9969232dc1d0d
Author: shimazu <shimazu@chromium.org>
Date: Mon Jun 12 10:15:39 2017

ServiceWorker: keep dispatcher hosts for unittests in the test helper

Currently tests which have their mock dispatcher hosts remove the dispatcher
host only from SWContextCore but not from the test helper. This patch is to fix
that so that tests will have only one appropriate dispatcher host at the same
time.

This is split off from https://crrev.com/2779763004/ .

BUG= 629701 ,  676983 , 668633

Review-Url: https://codereview.chromium.org/2933793002
Cr-Commit-Position: refs/heads/master@{#478578}

[modify] https://crrev.com/4f172ae8bad230163d337b8b07c9969232dc1d0d/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/4f172ae8bad230163d337b8b07c9969232dc1d0d/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/4f172ae8bad230163d337b8b07c9969232dc1d0d/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/4f172ae8bad230163d337b8b07c9969232dc1d0d/content/browser/service_worker/service_worker_handle_unittest.cc
[modify] https://crrev.com/4f172ae8bad230163d337b8b07c9969232dc1d0d/content/browser/service_worker/service_worker_version_unittest.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f

commit 1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f
Author: shimazu <shimazu@chromium.org>
Date: Thu Jun 22 01:21:29 2017

Create ServiceWorkerProviderHost before starting worker

Currently ServiceWorkerProviderHost for a service worker's context is bound with
the corresponing provider on the hosted worker when ProviderCreated and
SetHostedVersion messages are getting back after sending the StartWorker
message. This patch is to removes the round trip.
This patch changes the procedure of creating the SWProviderHost like the following.

1: Create a mock provider host when ServiceWorkerVersion::StartWorker is called.
2: Complete the rest of initialization for the provider host before sending
StartWorker message at ServiceWorkerProviderHost::CompleteStartWorkerPreparation.
3: Send the infomation about the provider host to the renderer as an argument of
EmbeddedWorkerInstanceClient::StartWorker.
4: Create ServiceWorkerNetworkProvider on the renderer when
ServiceWorkerContextClient is constructed.

This patch also sovles a weird ordering issue between ProviderDestroyed and
SetHostedVersion, and between OnStopped and ProviderDestroyed.

BUG= 629701 , 676983 ,668633
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2779763004
Cr-Commit-Position: refs/heads/master@{#481391}

[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/bad_message.h
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/foreign_fetch_request_handler_unittest.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/link_header_support_unittest.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_registration.h
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_registration_handle.h
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_test_utils.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_test_utils.h
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/child/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/child/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/child/service_worker/service_worker_network_provider.h
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/common/service_worker/service_worker_provider.mojom
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/common/service_worker/service_worker_types.mojom
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/common/service_worker/service_worker_types.typemap
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/renderer/service_worker/embedded_worker_instance_client_impl.h
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f/tools/metrics/histograms/enums.xml

Comment 11 by shimazu@chromium.org, Jun 23 2017

Status: Fixed (was: Started)
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947

commit 6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947
Author: shimazu <shimazu@chromium.org>
Date: Tue Jun 27 12:28:59 2017

Revert "Create ServiceWorkerProviderHost before starting worker"

This reverts commit 1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f.

Reason:
This patch is reverted due to crashes.
See also the bug: https://crbug.com/736649

BUG= 629701 ,  676983 , 668633, 736649
TBR=falken@chromium.org, kinuko@chromium.org, dcheng@chromium.org

Review-Url: https://codereview.chromium.org/2958753003
Cr-Commit-Position: refs/heads/master@{#482602}

[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/foreign_fetch_request_handler_unittest.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/link_header_support_unittest.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_registration.h
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_registration_handle.h
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_test_utils.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_test_utils.h
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/child/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/child/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/child/service_worker/service_worker_network_provider.h
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/common/service_worker/service_worker_provider.mojom
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/common/service_worker/service_worker_types.mojom
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/common/service_worker/service_worker_types.typemap
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/renderer/service_worker/embedded_worker_instance_client_impl.h
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/6f9740cc16c7a534fe8ed8b2c6fbe05c54fa6947/content/renderer/service_worker/service_worker_context_client.h
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 27 2017

Labels: merge-merged-3141
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99262d9db8c1264f97a1727b3100167a50315494

commit 99262d9db8c1264f97a1727b3100167a50315494
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Tue Jun 27 12:58:34 2017

[merge to 3141] Revert "Create ServiceWorkerProviderHost before starting worker"

This reverts commit 1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f.

Reason:
This patch is reverted due to crashes.
See also the bug: https://crbug.com/736649

BUG= 629701 ,  676983 , 668633, 736649
TBR=falken@chromium.org, kinuko@chromium.org, dcheng@chromium.org

Review-Url: https://codereview.chromium.org/2958753003
Cr-Original-Commit-Position: refs/heads/master@{#482602}
Review-Url: https://codereview.chromium.org/2961663004 .
Cr-Commit-Position: refs/branch-heads/3141@{#10}
Cr-Branched-From: 180095eb1bca7df1cdcb02547340499c2ee3af6e-refs/heads/master@{#482153}

[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/foreign_fetch_request_handler_unittest.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/link_header_support_unittest.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_registration.h
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_registration_handle.h
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_test_utils.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_test_utils.h
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/child/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/child/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/child/service_worker/service_worker_network_provider.h
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/common/service_worker/service_worker_provider.mojom
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/common/service_worker/service_worker_types.mojom
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/common/service_worker/service_worker_types.typemap
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/renderer/service_worker/embedded_worker_instance_client_impl.h
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/99262d9db8c1264f97a1727b3100167a50315494/content/renderer/service_worker/service_worker_context_client.h
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 27 2017

Labels: merge-merged-3142
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd596e2b1016b4eee146d6a024672cba18eb1c22

commit bd596e2b1016b4eee146d6a024672cba18eb1c22
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Tue Jun 27 13:51:45 2017

[merge to 3412] Revert "Create ServiceWorkerProviderHost before starting worker"

This reverts commit 1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f.

Reason:
This patch is reverted due to crashes.
See also the bug: https://crbug.com/736649

BUG= 629701 ,  676983 , 668633, 736649
TBR=falken@chromium.org, kinuko@chromium.org, dcheng@chromium.org

Review-Url: https://codereview.chromium.org/2958753003
Cr-Original-Commit-Position: refs/heads/master@{#482602}
Review-Url: https://codereview.chromium.org/2959003002 .
Cr-Commit-Position: refs/branch-heads/3142@{#6}
Cr-Branched-From: 58a8bea874fcfa2c18749645f087d0b21b8a21a0-refs/heads/master@{#482491}

[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/foreign_fetch_request_handler_unittest.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/link_header_support_unittest.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_registration.h
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_registration_handle.h
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_test_utils.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_test_utils.h
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/child/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/child/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/child/service_worker/service_worker_network_provider.h
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/common/service_worker/service_worker_provider.mojom
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/common/service_worker/service_worker_types.mojom
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/common/service_worker/service_worker_types.typemap
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/renderer/service_worker/embedded_worker_instance_client_impl.h
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/bd596e2b1016b4eee146d6a024672cba18eb1c22/content/renderer/service_worker/service_worker_context_client.h

Comment 15 by shimazu@chromium.org, Jun 30 2017

Blockedon: 738310

Comment 16 by falken@chromium.org, Jul 3 2017

Status: Available (was: Fixed)
This will be fixed when the fix relands, tracked at  bug 738310 .
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/820c6c249b597a415c1e29cb39df135f8e6741fd

commit 820c6c249b597a415c1e29cb39df135f8e6741fd
Author: Matt Falkenhagen <falken@chromium.org>
Date: Mon Jul 24 12:34:31 2017

Reland: Create ServiceWorkerProviderHost before starting worker

Reland of https://codereview.chromium.org/2779763004
Original patch from shimazu@.

Most of the diffs from the original patch are between patchset 2 and 3
but I did some complex rebasing and some cosmetic changes in between.

Bug:  629701 , 676983 ,668633
Change-Id: If06585abdb6f4d77ccc789c8961be4e5e1ff68ce
Reviewed-on: https://chromium-review.googlesource.com/564860
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488953}
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/foreign_fetch_request_handler_unittest.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/link_header_support_unittest.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_registration.h
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_registration_handle.h
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_test_utils.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_test_utils.h
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/child/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/child/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/child/service_worker/service_worker_network_provider.h
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/common/service_worker/service_worker_provider.mojom
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/common/service_worker/service_worker_types.mojom
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/common/service_worker/service_worker_types.typemap
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/renderer/service_worker/embedded_worker_instance_client_impl.h
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/820c6c249b597a415c1e29cb39df135f8e6741fd/content/renderer/service_worker/service_worker_context_client.h

Comment 18 by falken@chromium.org, Aug 2 2017

Labels: -M-61 M-62
Status: Fixed (was: Available)
I think fixed now. Based on the commit messages, the earlier commits removed the ProviderDestroyed message, and the reland of the browser-side provider host patch made the appropriate associated interfaces somehow.
►

Sign in to add a comment