New issue
Advanced search Search tips

Issue 676977 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 554033
Owner: ----
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature



Sign in to add a comment

All themes look peculiar on Windows 10

Project Member Reported by tapted@chromium.org, Dec 25 2016

Issue description

Chrome Version       : 55.0.2883.87, 57.0.2962.0 canary (64-bit)
OS Version: 10.0
URLs (if applicable) : https://chrome.google.com/webstore/detail/late-night/pgbdhkpacgdhfabeceekiafonfkipohm

Sorry if this is a dupe. I looked and couldn't find anything (although I could hardly believe it..). I'm not even sure whether it was a deliberate decision to fall back to opaque_browser_frame_view.cc

All I could find was  Issue 504044  "Consider using CrOS/Mac-style theme on Win10" but that's just about the default theme (i.e. no theme installed).

What steps will reproduce the problem?
1. Have Windows 10
2. Install a theme ("Late Night" is a tolerable Google theme, but it's from 2011. Newer themes don't behave differently AFAIK)

What is the expected result?

Chrome should continue to look like a Windows 10 App

What happens instead of that?

 - Browser switches to Vista/Aero style
 - Window gets rounded corners
 - Window gets a thick border/bezel
 - Window controls change to Win7 style
 - Window controls get jpeg/resizing artifacts on 150% screens
 - Status bar is misaligned (there's a 1-2px gap under it showing WebContents before it gets to the bezel)
 - The tab strip looks misaligned near the sides of the window on a lot of themes

Just generally, all themes look kinda gross and ugly on Windows 10. I kinda want a theme to help identify browser windows in different profiles now that they no longer get badged, but it just looks awful.

This will probably be hard - maybe we need a theme manifest attribute to indicate it has a Windows 10 "mode" so that existing themes continue to work as they do currently. I saw on other bugs that the webstore might already have some concept of a "Classic" theme (I don't know much about themes).
 
windows_10_themes_gross.png
301 KB View Download
I think this is covered by  issue 554033 .
Cc: bsep@chromium.org

Comment 3 by tapted@chromium.org, Dec 28 2016

Mergedinto: 554033
Status: Duplicate (was: Unconfirmed)
Yeah I think  Issue 554033  will cover this - thanks for the link! And there's some work there already. I'll give the other bug some labels so it's easier to find.

Sign in to add a comment