New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676941 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , All
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in webrtc::BackgroundNoise::Update

Project Member Reported by ClusterFuzz, Dec 25 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5497274194198528

Fuzzer: libfuzzer_neteq_rtp_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  webrtc::BackgroundNoise::Update
  webrtc::NetEqImpl::GetAudioInternal
  webrtc::NetEqImpl::GetAudio
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=438480:438523

Minimized Testcase (3.94 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97efzRSJjhBmE_1iRDpUWp9TuEdnT4h5lr1b9J5pjYgrUDL9wXnIYFX-oOMN_xZn_5mIDPViO0oj6G0YpCWLhwl4Hhm1b22OMFNL_OjjV81H8lZbSNG5ImosXD8iXemSbLCdo9uUgBekLvNmHSs9KlLeX0wRw?testcase_id=5497274194198528

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 

Comment 1 Deleted

Cc: tlegrand@chromium.org
Components: Blink>WebRTC>Audio
Labels: OS-All
Owner: hlundin@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/a67e5f5de97366587246ff6cc9a92248064e258c

commit a67e5f5de97366587246ff6cc9a92248064e258c
Author: henrik.lundin <henrik.lundin@webrtc.org>
Date: Wed Mar 01 11:06:50 2017

Fixing an overflow issue in NetEq::BackgroundNoise

BUG= chromium:676941 

Review-Url: https://codereview.webrtc.org/2722533002
Cr-Commit-Position: refs/heads/master@{#16938}

[modify] https://crrev.com/a67e5f5de97366587246ff6cc9a92248064e258c/webrtc/modules/audio_coding/neteq/background_noise.cc

Project Member

Comment 4 by ClusterFuzz, Mar 3 2017

ClusterFuzz has detected this issue as fixed in range 454256:454300.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5497274194198528

Fuzzer: libfuzzer_neteq_rtp_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  webrtc::BackgroundNoise::Update
  webrtc::NetEqImpl::GetAudioInternal
  webrtc::NetEqImpl::GetAudio
  
Sanitizer: undefined (UBSAN)

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=438480:438523
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=454256:454300

Reproducer Testcase: https://cluster-fuzz.appspot.com/download/AMIfv94lJFub-EDu9L9IU6tbyika6RaL3nzsmjsbtsXRpb8-Hk5chns4o5j8VTyKjCPT-WjzldfuFzWQQaojxMqB6H6fh9OnR2bAEZ0oAxAZduKWDQdCgQRXG2WK-YBv_tkA7aiNVTeI4aPQw7ye08v4khj5q31h_BDuQD_U2-VJgCAk0LFKzLIsSXzPQ6YwtKtoZR08lFFdOCQ4GYUig4ZSEzOWQmE0FHocTpxNjmiDRH23m2xhCcd1mCAuAc_WopmhfVQGpFcgeAI55vU7wWbWt6eGOauqC8akqC9xgpe_ZLfkIjCyYd63GEMjmf3OIpNa-Pxwvnay8ALnKAUFqz5Flzxk4m49dpjVR1FDfaHRBzEtGI4HMo8?testcase_id=5497274194198528


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Mar 3 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5497274194198528 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: M-59

Sign in to add a comment