Programmatically draw avatar/profile button-related resources
Reported by
billdill...@gmail.com,
Dec 24 2016
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36 Steps to reproduce the problem: I just noticed the little person icon located beside the Minimize button is low res on HIDPI windows, it should be updated (screenshot attached) What is the expected behavior? What went wrong? see above Did this work before? N/A Chrome version: 55.0.2883.87 Channel: stable OS Version: 10.0 Flash Version: Shockwave Flash 24.0 r0
,
Jan 13 2017
Tested this issue on Windows-10 HiDPI using chrome latest stable M55-55.0.2883.87 by following steps mentioned below. 1. Navigated to chrome://flags 2. Enabled material designed user manager 3. Observed there is some blurriness on avatar icon. Since this issue is specific to material design adding appropriate label for further triage. Thanks!
,
Jan 13 2017
someone should also check this out on retina macs too (I don't know anyone with a retina mac, sorry)
,
Jan 16 2017
,
Jan 16 2017
I would imagine that on Windows the issue is that we don't have 2x versions of chrome/app/theme/default_100_percent/win/avatar_button/ . However, rather than adding them, a better fix would probably be to programmatically draw this stuff. Everything in that folder looks like it could be programmatically drawn. Not MD-specific. Tagging this with HarmonyControls even though it's technically not really Harmony either.
,
Jan 25 2017
I have convinced myself that tracking this on the harmony list is the wrong thing to do :)
,
Feb 27 2017
I know this isn't a high priority but any progress on this? it IS part of the main top chrome and visible pretty much at all times
,
Feb 27 2017
If we haven't posted, there's no progress. There is unlikely to be progress in the next several months unless an external contributor would like to try tackling this.
,
Feb 27 2017
I think we're waiting on design feedback/assets/guidance though. I don't think it would take long and it is, imo, a high profile bit of polish, so we should be able to spare the eng time. Over to Alan.
,
Feb 27 2017
We are? What assets are we waiting on? SVGs of the default avatar image or something?
,
Feb 28 2017
that would be one. We could take an icon from the md archive but it wouldn't be optimized for display at 10px (or whatever small number it is). And then the button outline is the other. That might just take the form of a spec, i.e. a color (same as tab outline?) and a corner radius.
,
Feb 28 2017
Bug 644004 is about the correct color for this button (should match caption buttons). The outline doesn't need a designer spec -- should always match the caption buttons. So if we need something, it's just a vector version of the icon within the button, I think.
,
Feb 28 2017
are the frame controls already programmatic? I guess on Linux the avatar button doesn't match the frame controls currently (must be matching Windows instead) but that may something we want to fix.
,
Feb 28 2017
They are in some cases. That said, I retract my claim about the outline "should match the caption buttons". I suspect we don't, in fact, want that (at least size/shape-wise), as it'd look really weird in certain cases, and affect layout of the new tab button. Instead I'm going to claim this bug is only about programmatic/vector-based drawing of something with equivalent behavior to the current button, so it looks good in high DPI; bug 644004 covers the color, bug 591586 the shape. That still leaves us needing only vector icons, it just makes fewer false claims :)
,
Mar 30 2017
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 26 2017
I think this can be labeled as FIXED now but I'm just curious, is it looking as it was intended?
,
Jul 26 2017
posting this here to get it looked at faster :) https://bugs.chromium.org/p/chromium/issues/detail?id=749074
,
Jul 25
--Chrome Identity automated triaging-- This bug is Available and has gone one year without any activity. If another month passes without any activity, this bug will be closed out. Please provide an update with the latest status for this bug. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 25
The avatar chip is deprecated and replaced in Refresh. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by billdill...@gmail.com
, Jan 6 2017