New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676842 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 672860



Sign in to add a comment

Linux TSan Builder misconfigured and not running

Project Member Reported by gab@chromium.org, Dec 23 2016

Issue description

Linux TSan Builder is offline on chromium.memory  https://crbug.com/672860#c16  for background and context (might require another master(s) restart?)
 

Comment 1 by pschm...@google.com, Dec 27 2016

Owner: pschmidt@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by pschm...@google.com, Dec 27 2016

I got the slave up and connected to the master but there is still a master configuration issue. 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20TSan%20Builder/builds/0/steps/generate_build_files/logs/stdio

Comment 3 by pschm...@google.com, Dec 27 2016

Issue 677159 has been merged into this issue.
Summary: Linux TSan Builder misconfigured and not running (was: Linux TSan Builder is offline)
Cc: tandrii@chromium.org
CC'ing the current trooper.
Cc: -tandrii@chromium.org
don't see cc troopers, please; Infra-Troopers is sufficient. EMEA troopers don't handle Pri2 issues.

I think this bug should be closed in favor   https://crbug.com/672860#c16 . This is a VM and can be easily restarted by any infra person through https://chrome-infra.appspot.com/login?r=%2Fvm-power
This bug was filed in response to the suggestion in  https://crbug.com/672860#c17 , which was itself a response to  https://crbug.com/672860#c16 .

There's a priority mismatch here IMO given that this bug is causing an alert in sheriff-o-matic and causing a bot to be consistently red on the main waterfall.
Labels: -Pri-2 Pri-1
Agree with #7 and bumping up to P1.
Owner: ----
Status: Untriaged (was: Assigned)
Fixing up labels so that a trooper can take a look.
Taking a look
I just restarted the VM. Let's see if that fixes things.
That doesn't seem to have helped. Taking another look.
Labels: Type-Bug
Owner: katthomas@chromium.org
Status: Started (was: Untriaged)
Actually, I made a mistake. The master is restarting in fifteen minutes. 
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/39f73e8d9470cb0732bf073250156ad5921c70ca

commit 39f73e8d9470cb0732bf073250156ad5921c70ca
Author: Katie Thomas <katthomas@google.com>
Date: Wed Jan 04 19:13:24 2017

Cc: dpranke@chromium.org gab@chromium.org
The error I see is:

MBErr: Builder name "Linux TSan Builder"  not found under masters[chromium.memory] in "/b/c/b/Linux_TSan_Builder/src/tools/mb/mb_config.pyl"

It is indeed not there...https://codesearch.chromium.org/chromium/src/tools/mb/mb_config.pyl?l=309

It also looks like it has never been successful: http://shortn/_HcoAT02PT2

I see this change: https://chromium.googlesource.com/chromium/tools/build/+/a4dc1bd4c41dd72b2fa83bed1047db1072b30554%5E%21/masters/master.chromium.memory/slaves.cfg

Maybe something was missing? +gab who authored the change and +dpranke who reviewed it.
Cc: katthomas@chromium.org
Owner: ----
Status: Available (was: Started)
Owner: dpranke@chromium.org
Status: Assigned (was: Available)
Ah. This is no longer a master configuration issue, this is an MB configuration issue :).

When we moved the builder we didn't update mb_config.pyl.
Status: Started (was: Assigned)
https://codereview.chromium.org/2618643002/
Components: -Infra Build
Labels: -Restrict-View-Google -Infra-Troopers
Project Member

Comment 20 by bugdroid1@chromium.org, Jan 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2730358eadd0dc68d4da80bab44401c33ed6aac

commit e2730358eadd0dc68d4da80bab44401c33ed6aac
Author: dpranke <dpranke@chromium.org>
Date: Thu Jan 05 03:48:28 2017

Update MB entries for the Linux TSAN Builder.

We moved the builder from the memory.full waterfall to the
memory waterfall but forgot to update the MB config file.

Also, re-sort the builder names in the memory waterfall entries.

TBR=gab@chromium.org
BUG= 676842 

Review-Url: https://codereview.chromium.org/2618643002
Cr-Commit-Position: refs/heads/master@{#441575}

[modify] https://crrev.com/e2730358eadd0dc68d4da80bab44401c33ed6aac/tools/mb/mb_config.pyl

The bot still red:
https://build.chromium.org/p/chromium.memory/waterfall?builder=Linux%20TSan%20Builder
is this bug still 'started'?
Status: Fixed (was: Started)
The bot has cycled green:

https://build.chromium.org/p/chromium.memory/builders/Linux%20TSan%20Builder/builds/698

@loyso - I think you clicked on things slightly too early, and the first build w/ my fix hadn't cycled through yet (the build above completed ~10 minutes after your comment :).

Comment 23 by gab@chromium.org, Jan 5 2017

Thanks Dirk!

PS: maybe it's just me but configuring these feels like a game of whack-a-mole :(...
Yup, no argument there ...

Sign in to add a comment