New issue
Advanced search Search tips

Issue 676805 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 786332
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 624689


Show other hotlists

Hotlists containing this issue:
TaskThrottling


Sign in to add a comment

Post renderer tasks to correct task queues from outside Blink

Project Member Reported by altimin@chromium.org, Dec 23 2016

Issue description

We should post tasks to correct task queues (preferably to per-frame ones) instead of posting them to default task queues.

This is a part of larger per-frame scheduler effort, targeted specifically on tasks originating from outside Blink, mainly content/renderer.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/124814c8025c564a6f494a3c9d4c887d57b98f1e

commit 124814c8025c564a6f494a3c9d4c887d57b98f1e
Author: altimin <altimin@chromium.org>
Date: Tue Jan 03 14:06:54 2017

Use timer task runner for V8PerIsolate tasks

Per the effort of getting rid of default task queue in scheduler, post per-isolate
tasks to renderer-wide timer task queue.

BUG= 676805 

Review-Url: https://codereview.chromium.org/2589363003
Cr-Commit-Position: refs/heads/master@{#441114}

[modify] https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e/extensions/renderer/api_binding_test.cc
[modify] https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e/gin/isolate_holder.cc
[modify] https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e/gin/per_isolate_data.cc
[modify] https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e/gin/per_isolate_data.h
[modify] https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e/gin/public/isolate_holder.h
[modify] https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e/gin/shell/gin_main.cc
[modify] https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e/gin/shell_runner_unittest.cc
[modify] https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e/gin/test/file_runner.cc
[modify] https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e/gin/test/v8_test.cc
[modify] https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e/mojo/edk/js/tests/js_to_cpp_tests.cc
[modify] https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e/net/proxy/proxy_resolver_v8.cc
[modify] https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e/pdf/pdfium/pdfium_engine.cc
[modify] https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
[modify] https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
[modify] https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp
[modify] https://crrev.com/124814c8025c564a6f494a3c9d4c887d57b98f1e/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f45c5de5f5444ffb697790c76387e66502d079f

commit 4f45c5de5f5444ffb697790c76387e66502d079f
Author: altimin <altimin@chromium.org>
Date: Wed Jan 18 10:27:25 2017

Use loading tq instead of timer tq for per-isolate tasks

When per-isolate tasks are posted to timer tq, memory usage metrics go up.
This may happen due to garbage collection being throttled. Switch tasks to
loading task queue to fix regression for now.

R=haraken@chromium.org
CC=skyostil@chromium.org,primiano@chromium.org

BUG=678286, 676805 

Review-Url: https://codereview.chromium.org/2638973002
Cr-Commit-Position: refs/heads/master@{#444327}

[modify] https://crrev.com/4f45c5de5f5444ffb697790c76387e66502d079f/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4d24a8a8d97013513f2f668734ce608a82a541a

commit c4d24a8a8d97013513f2f668734ce608a82a541a
Author: altimin <altimin@chromium.org>
Date: Tue Feb 07 23:18:06 2017

Use timer task queue for RenderMediaLog

As a part of effort to post tasks to correct scheduler task queues instead
of default one, use frame-specific timer task runner for RenderMediaLog tasks.

BUG= 676805 

Review-Url: https://codereview.chromium.org/2647453003
Cr-Commit-Position: refs/heads/master@{#448777}

[modify] https://crrev.com/c4d24a8a8d97013513f2f668734ce608a82a541a/content/renderer/media/render_media_log.cc
[modify] https://crrev.com/c4d24a8a8d97013513f2f668734ce608a82a541a/content/renderer/media/render_media_log.h
[modify] https://crrev.com/c4d24a8a8d97013513f2f668734ce608a82a541a/content/renderer/media/render_media_log_unittest.cc
[modify] https://crrev.com/c4d24a8a8d97013513f2f668734ce608a82a541a/content/renderer/render_frame_impl.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ea4b653af65fdb18c37f54d9986708f5277f8db

commit 9ea4b653af65fdb18c37f54d9986708f5277f8db
Author: altimin <altimin@chromium.org>
Date: Wed Feb 08 17:28:25 2017

Revert of Use timer task queue for RenderMediaLog (patchset #2 id:20001 of https://codereview.chromium.org/2647453003/ )

Reason for revert:
VideoFullscreenOrientationLockTests became flaky (see  crbug.com/676070 )

Original issue's description:
> Use timer task queue for RenderMediaLog
>
> As a part of effort to post tasks to correct scheduler task queues instead
> of default one, use frame-specific timer task runner for RenderMediaLog tasks.
>
> BUG= 676805 
>
> Review-Url: https://codereview.chromium.org/2647453003
> Cr-Commit-Position: refs/heads/master@{#448777}
> Committed: https://chromium.googlesource.com/chromium/src/+/c4d24a8a8d97013513f2f668734ce608a82a541a

TBR=jochen@chromium.org,dalecurtis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 676805 

Review-Url: https://codereview.chromium.org/2688523002
Cr-Commit-Position: refs/heads/master@{#449023}

[modify] https://crrev.com/9ea4b653af65fdb18c37f54d9986708f5277f8db/content/renderer/media/render_media_log.cc
[modify] https://crrev.com/9ea4b653af65fdb18c37f54d9986708f5277f8db/content/renderer/media/render_media_log.h
[modify] https://crrev.com/9ea4b653af65fdb18c37f54d9986708f5277f8db/content/renderer/media/render_media_log_unittest.cc
[modify] https://crrev.com/9ea4b653af65fdb18c37f54d9986708f5277f8db/content/renderer/render_frame_impl.cc

Mergedinto: 786332
Status: Duplicate (was: Started)

Sign in to add a comment