New issue
Advanced search Search tips

Issue 676801 link

Starred by 2 users
Status: Verified
Owner: ----
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Refactor and remove old preferences for default search

Project Member Reported by a-...@yandex-team.ru, Dec 23 2016 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.77 YaBrowser/17.1.0.1289 (beta) Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
After https://bugs.chromium.org/p/chromium/issues/detail?id=365762
chromium code support two sets of preferences for default search - obsolete and new.
Old preferences are migrated to new prefs on start since M36.
Its time to delete old set and migration logic.

What is the expected behavior?

What went wrong?
not applicable

Did this work before? N/A 

Chrome version: 55.0.2883.77  Channel: n/a
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 24.0 r0

Comment 1 by sureshkumari@chromium.org, Dec 26 2016

Labels: TE-NeedsTriageHelp

Comment 2 by a-...@yandex-team.ru, Dec 26 2016 

I have created CL with old prefs removal https://codereview.chromium.org/2598033004/.

Comment 3 by schenney@chromium.org, Dec 26 2016

Components: UI>Browser>Search

Comment 4 by erikc...@chromium.org, Dec 27 2016

Labels: -OS-Mac OS-All
Status: Available (was: Unconfirmed)
Awesome, thanks for being proactive. :)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1be376e34def3865b168d419e415ee4b6df63f6e

commit 1be376e34def3865b168d419e415ee4b6df63f6e
Author: a-v-y <a-v-y@yandex-team.ru>
Date: Tue Jan 10 13:22:10 2017

Remove old default search preferences.

After https://bugs.chromium.org/p/chromium/issues/detail?id=365762
chromium code support two sets of preferences for default search -
obsolete and new. Old preferences are migrated to new prefs on start
since M36. Its time to delete old prefs set and migration logic.

BUG= 676801 

R=pkasting@chromium.org,gab@chromium.org

Review-Url: https://codereview.chromium.org/2598033004
Cr-Commit-Position: refs/heads/master@{#442569}

[modify] https://crrev.com/1be376e34def3865b168d419e415ee4b6df63f6e/chrome/browser/prefs/chrome_pref_service_factory.cc
[modify] https://crrev.com/1be376e34def3865b168d419e415ee4b6df63f6e/chrome/browser/prefs/tracked/pref_hash_browsertest.cc
[modify] https://crrev.com/1be376e34def3865b168d419e415ee4b6df63f6e/components/search_engines/BUILD.gn
[modify] https://crrev.com/1be376e34def3865b168d419e415ee4b6df63f6e/components/search_engines/default_search_policy_handler.cc
[modify] https://crrev.com/1be376e34def3865b168d419e415ee4b6df63f6e/components/search_engines/default_search_policy_handler.h
[modify] https://crrev.com/1be376e34def3865b168d419e415ee4b6df63f6e/components/search_engines/default_search_policy_handler_unittest.cc
[delete] https://crrev.com/6b2ff207c6fdf78d401bd13b417a31040a44dc61/components/search_engines/default_search_pref_migration.cc
[delete] https://crrev.com/6b2ff207c6fdf78d401bd13b417a31040a44dc61/components/search_engines/default_search_pref_migration.h
[delete] https://crrev.com/6b2ff207c6fdf78d401bd13b417a31040a44dc61/components/search_engines/default_search_pref_migration_unittest.cc
[modify] https://crrev.com/1be376e34def3865b168d419e415ee4b6df63f6e/components/search_engines/search_engines_pref_names.cc
[modify] https://crrev.com/1be376e34def3865b168d419e415ee4b6df63f6e/components/search_engines/search_engines_pref_names.h
[modify] https://crrev.com/1be376e34def3865b168d419e415ee4b6df63f6e/components/search_engines/template_url_service.cc
[modify] https://crrev.com/1be376e34def3865b168d419e415ee4b6df63f6e/components/user_prefs/tracked/pref_hash_filter.cc
[modify] https://crrev.com/1be376e34def3865b168d419e415ee4b6df63f6e/ios/chrome/browser/prefs/ios_chrome_pref_service_factory.cc
[modify] https://crrev.com/1be376e34def3865b168d419e415ee4b6df63f6e/tools/metrics/histograms/histograms.xml

Comment 6 by a-...@yandex-team.ru, Jan 11 2017 

I think this issue can be closed.

Comment 7 by a-...@yandex-team.ru, Sep 25 2017

Status: Verified (was: Available)
►

Sign in to add a comment