New issue
Advanced search Search tips

Issue 676800 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 105388



Sign in to add a comment

No-compile tests doesn't work on Mac

Project Member Reported by wychen@chromium.org, Dec 23 2016

Issue description

After enabling no-compile tests on Mac, it couldn't compile due to missing headers.

From https://build.chromium.org/p/chromium/builders/Mac/builds/22001/steps/compile/logs/stdio

---

FAILED: gen/base/callback_unittest_nc.cc 
python ../../tools/nocompile_driver.py 4 ../../base/callback_unittest.nc -Wall\ -Werror\ -Wfatal-errors\ -I../../ gen/base/callback_unittest_nc.cc
In file included from ../../base/callback_unittest.nc:8:
In file included from ../../base/callback.h:9:
In file included from ../../base/callback_internal.h:11:
In file included from ../../base/atomic_ref_count.h:11:
In file included from ../../base/atomicops.h:40:
../../build/build_config.h:37:10: fatal error: 'TargetConditionals.h' file not found
#include <TargetConditionals.h>
         ^~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[49/49241] ACTION //base:base_nocompile_tests_run_nocompile(//build/toolchain/mac:clang_x64)
FAILED: gen/base/callback_list_unittest_nc.cc 
python ../../tools/nocompile_driver.py 4 ../../base/callback_list_unittest.nc -Wall\ -Werror\ -Wfatal-errors\ -I../../ gen/base/callback_list_unittest_nc.cc
In file included from ../../base/callback_list_unittest.nc:8:
In file included from ../../base/callback_list.h:8:
In file included from /b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/list:173:
In file included from /b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/memory:629:
In file included from /b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/typeinfo:61:
In file included from /b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/exception:82:
In file included from /b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/cstdlib:86:
/b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/stdlib.h:94:15: fatal error: 'stdlib.h' file not found
#include_next <stdlib.h>
              ^~~~~~~~~~
1 error generated.
[50/49241] ACTION //base:base_nocompile_tests_run_nocompile(//build/toolchain/mac:clang_x64)
FAILED: gen/base/histogram_unittest_nc.cc 
python ../../tools/nocompile_driver.py 4 ../../base/metrics/histogram_unittest.nc -Wall\ -Werror\ -Wfatal-errors\ -I../../ gen/base/histogram_unittest_nc.cc
In file included from ../../base/metrics/histogram_unittest.nc:8:
In file included from ../../base/metrics/histogram_macros.h:8:
In file included from ../../base/metrics/histogram.h:72:
In file included from /b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/map:442:
In file included from /b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__tree:15:
In file included from /b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/iterator:417:
In file included from /b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/iosfwd:90:
/b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/wchar.h:119:15: fatal error: 'wchar.h' file not found
#include_next <wchar.h>
              ^~~~~~~~~
1 error generated.

[118/49241] ACTION //base:base_nocompile_tests_run_nocompile(//build/toolchain/mac:clang_x64)
FAILED: gen/base/weak_ptr_unittest_nc.cc 
python ../../tools/nocompile_driver.py 4 ../../base/memory/weak_ptr_unittest.nc -Wall\ -Werror\ -Wfatal-errors\ -I../../ gen/base/weak_ptr_unittest_nc.cc
In file included from ../../base/memory/weak_ptr_unittest.nc:8:
In file included from ../../base/memory/weak_ptr.h:77:
In file included from ../../base/logging.h:10:
/b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/cassert:21:10: fatal error: 'assert.h' file not found
#include <assert.h>
         ^~~~~~~~~~
1 error generated.
[119/49241] ACTION //base:base_nocompile_tests_run_nocompile(//build/toolchain/mac:clang_x64)
FAILED: gen/base/bind_unittest_nc.cc 
python ../../tools/nocompile_driver.py 4 ../../base/bind_unittest.nc -Wall\ -Werror\ -Wfatal-errors\ -I../../ gen/base/bind_unittest_nc.cc
In file included from ../../base/bind_unittest.nc:10:
In file included from ../../base/bind.h:8:
In file included from ../../base/bind_internal.h:10:
In file included from /b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/tuple:142:
In file included from /b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__functional_base:16:
In file included from /b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/typeinfo:61:
In file included from /b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/exception:82:
In file included from /b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/cstdlib:86:
/b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/stdlib.h:94:15: fatal error: 'stdlib.h' file not found
#include_next <stdlib.h>
              ^~~~~~~~~~
1 error generated.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/296d75bd21e5f6b3d492dbec0f14dc22d837bf0b

commit 296d75bd21e5f6b3d492dbec0f14dc22d837bf0b
Author: wychen <wychen@chromium.org>
Date: Wed Jan 04 06:51:50 2017

Fix no-compile tests on Linux by adding sysroot

It became necessary to specify sysroot after the following CL:
https://codereview.chromium.org/2583353002
Otherwise, std::is_trivially_copyable wouldn't be there.

This CL also fixes the missing header issue on Mac.

BUG=105388,  676800 

Review-Url: https://codereview.chromium.org/2595413004
Cr-Commit-Position: refs/heads/master@{#441327}

[modify] https://crrev.com/296d75bd21e5f6b3d492dbec0f14dc22d837bf0b/build/nocompile.gni

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1a7b9b88e0e16e81184f62970550a1080b02674

commit e1a7b9b88e0e16e81184f62970550a1080b02674
Author: wychen <wychen@chromium.org>
Date: Wed Jan 04 13:21:55 2017

Support no-compile tests on Mac

The expected error message on Mac is:
  fatal error: call to implicitly-deleted copy constructor
On Linux, it's:
  fatal error: call to deleted constructor

BUG= 676800 

Review-Url: https://codereview.chromium.org/2603573002
Cr-Commit-Position: refs/heads/master@{#441363}

[modify] https://crrev.com/e1a7b9b88e0e16e81184f62970550a1080b02674/base/callback_list_unittest.nc

Cc: thakis@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment