New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 676774 link

Starred by 2 users
Status: Verified
Owner:
alemate@chromium.org
Closed: Feb 2017
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Focus is missing on Language/Accessibility buttons in Welcome screen after setting language/enabling accessibility.

Project Member Reported by jbanavatu@chromium.org, Dec 23 2016 
Chrome Version: 57.0.2959.0/9112.0.0  Daisy, Candy, Wolf
OS: ChromeOS

What steps will reproduce the problem?
(1)Recover build via USB>>Hit tab (here you will see focus on Language& Keyboard button)
(2) Go to 'Choose language & keyboard' screen>> Set language & Keyboard options and click OK
(3) Now Observe for focus on Language & Keyboard button in welcome screen.

Note:Same issue is with Accessibility button in welcome screen.

Expected: Focus should be seen on Language&Keyboard button after setting language/keyboard
Actual: Instead focus is seen missing.

This is regression issue as it is working fine in M56.

Comment 1 by jbanavatu@chromium.org, Dec 23 2016 

Attaching screen-cast for reference.
Actual.mp4
3.6 MB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0

commit bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0
Author: alemate <alemate@chromium.org>
Date: Sat Feb 18 06:56:14 2017

ChromeOS OOBE: fix focus flow in MD-OOBE.

BUG= 676774 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2688153004
Cr-Commit-Position: refs/heads/master@{#451434}

[modify] https://crrev.com/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0/chrome/browser/resources/chromeos/login/oobe_a11y_option.html
[modify] https://crrev.com/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0/chrome/browser/resources/chromeos/login/oobe_a11y_option.js
[modify] https://crrev.com/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0/chrome/browser/resources/chromeos/login/oobe_buttons.js
[modify] https://crrev.com/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0/chrome/browser/resources/chromeos/login/oobe_dialog.html
[modify] https://crrev.com/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0/chrome/browser/resources/chromeos/login/oobe_dialog.js
[modify] https://crrev.com/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0/chrome/browser/resources/chromeos/login/oobe_eula.html
[modify] https://crrev.com/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0/chrome/browser/resources/chromeos/login/oobe_eula.js
[modify] https://crrev.com/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0/chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.html
[modify] https://crrev.com/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0/chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js
[modify] https://crrev.com/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0/chrome/browser/resources/chromeos/login/oobe_screen_eula.js
[modify] https://crrev.com/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0/chrome/browser/resources/chromeos/login/oobe_screen_network.js
[modify] https://crrev.com/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0/chrome/browser/resources/chromeos/login/oobe_welcome.html
[modify] https://crrev.com/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0/chrome/browser/resources/chromeos/login/oobe_welcome.js
[modify] https://crrev.com/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
[modify] https://crrev.com/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.js
[modify] https://crrev.com/bc82717e957aeaf5b865d4f4b4c3ec7ad48360c0/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc

Comment 3 by alemate@chromium.org, Feb 18 2017

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b95cf24b16a79138e0f4c01375b3af62512dae2e

commit b95cf24b16a79138e0f4c01375b3af62512dae2e
Author: alemate <alemate@chromium.org>
Date: Wed Feb 22 10:37:26 2017

ChromeOS OOBE: Fix EULA Back button.

This Cl prevents duplicate "selected network connected" events
and fixes focus when returning to network selection dialog
after pressing "Back" button on EULA screen.

BUG= 676774 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2700353002
Cr-Commit-Position: refs/heads/master@{#451979}

[modify] https://crrev.com/b95cf24b16a79138e0f4c01375b3af62512dae2e/chrome/browser/resources/chromeos/login/oobe_dialog.js
[modify] https://crrev.com/b95cf24b16a79138e0f4c01375b3af62512dae2e/chrome/browser/resources/chromeos/login/oobe_welcome.js

Comment 5 by rookrishna@chromium.org, Feb 27 2017

Status: Verified (was: Fixed)
58.0.3021.0/9313.0.0
►

Sign in to add a comment