New issue
Advanced search Search tips

Issue 676763 link

Starred by 1 user
Status: Fixed
Owner:
r...@igalia.com
Closed: Jan 2017
Cc:
flor...@rivoal.net
editing-dev@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 665422



Sign in to add a comment

[css-ui] Resolved value of caret-color should be the used value

Project Member Reported by r...@igalia.com, Dec 23 2016 
This has been discussed by the CSS WG and resolved this week:
https://github.com/w3c/csswg-drafts/issues/566

Basically caret-color will behave like the rest of color properties
when you call getComputedStyle() to get the resolved value.
Instead of getting "auto" or "currentcolor", you'll get
the numeric value "rgb(X, X, X)".

We need to update caret-color implementation, as current one is not passing:
https://github.com/w3c/csswg-test/blob/master/css-ui-3/caret-color-009.html
https://github.com/w3c/csswg-test/blob/master/css-ui-3/caret-color-013.html

There's a CL doing that at: https://codereview.chromium.org/2577633002/
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff62a1d1b18d235feb6c3aeb750aeb4ced1ec9c6

commit ff62a1d1b18d235feb6c3aeb750aeb4ced1ec9c6
Author: qyearsley <qyearsley@chromium.org>
Date: Sat Dec 24 21:24:41 2016

Import csswg-test@75a3f186b64787c9b7cb292a22d1f6e9237ff1bc

Using update-w3c-deps in Chromium de864efb596ca3df1a6df84a67f110221fb7bcaf.

Import after https://github.com/w3c/csswg-test/pull/1157, making sure that it works now that the CRLF endings were removed.

BUG= 676763 

Review-Url: https://codereview.chromium.org/2595173004
Cr-Commit-Position: refs/heads/master@{#440676}

[modify] https://crrev.com/ff62a1d1b18d235feb6c3aeb750aeb4ced1ec9c6/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/ff62a1d1b18d235feb6c3aeb750aeb4ced1ec9c6/third_party/WebKit/LayoutTests/imported/csswg-test/css-ui-3/caret-color-009.html
[modify] https://crrev.com/ff62a1d1b18d235feb6c3aeb750aeb4ced1ec9c6/third_party/WebKit/LayoutTests/imported/csswg-test/css-ui-3/caret-color-013.html
[modify] https://crrev.com/ff62a1d1b18d235feb6c3aeb750aeb4ced1ec9c6/third_party/WebKit/LayoutTests/imported/csswg-test/css-ui-3/caret-color-021.html
[modify] https://crrev.com/ff62a1d1b18d235feb6c3aeb750aeb4ced1ec9c6/third_party/WebKit/LayoutTests/imported/csswg-test/lint.whitelist
[modify] https://crrev.com/ff62a1d1b18d235feb6c3aeb750aeb4ced1ec9c6/third_party/WebKit/LayoutTests/imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-empty-001a-expected.html
[modify] https://crrev.com/ff62a1d1b18d235feb6c3aeb750aeb4ced1ec9c6/third_party/WebKit/LayoutTests/imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-empty-001a.html
[modify] https://crrev.com/ff62a1d1b18d235feb6c3aeb750aeb4ced1ec9c6/third_party/WebKit/LayoutTests/imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-empty-001b-expected.html
[modify] https://crrev.com/ff62a1d1b18d235feb6c3aeb750aeb4ced1ec9c6/third_party/WebKit/LayoutTests/imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-empty-001b.html

Comment 2 by r...@igalia.com, Jan 4 2017

Labels: -Pri-3 Hotlist-Interop Pri-1
Firefox is already returning a rgb() as resolved value, so we should update this too.
There's a CL waiting for review:
https://codereview.chromium.org/2577633002/

See Firefox bug for reference:
https://bugzilla.mozilla.org/show_bug.cgi?id=1063162#c72

Comment 3 by r...@igalia.com, Jan 9 2017

Status: Fixed (was: Started)
This has been fixed by at r442214.
https://chromium.googlesource.com/chromium/src/+/1d659157007dc8af77915b4af72f577b324c5e81

The CL pointed to  bug #665422  instead of here, sorry about that.
►

Sign in to add a comment