Sometimes rebaseline bot does nothing for failing NeedsRebaseline tests |
||||||
Issue description1. Auto-rebaseline (https://codereview.chromium.org/2593853003/) didn't create text baseline for the test (only created image baseline). After auto-rebaseline, the test failed because of missing text rebaseline. 2. Tried rebaseline-cl in https://codereview.chromium.org/2600613002/ and it did nothing, though the test failed on rebaseline try bots because of missing text baseline.
,
Dec 28 2016
There still may be a bug to investigate here (rebaseline-cl should have downloaded a baseline if there is an actual result and the text baseline is missing), but it's no longer easy to investigate because the test is now passing, with no baselines (after https://codereview.chromium.org/2602703002). Let me know again if you see something like this again!
,
Jan 27 2017
A sheriff encountered this again today. Some tests fail on Win7 after rebaselined, but the rebaseline bot did nothing for a retried rebaseline. See bug 685851 , and https://codereview.chromium.org/2651413003/.
,
Jan 27 2017
Thanks for updating this, will take a look.
,
Jan 27 2017
,
Jan 27 2017
I can reproduce this bug with local manual rebaselining: 1. Mark fast/table/backgr_position-table-column-group.html [ Rebaseline ]. 2. Commit the change int a local branch. 3. Run webkit-patch rebaseline-expectations. Expected: The test (failing on Win7) should be rebaselined using actual results on bots. Actual: The command does nothing but removing all Rebaseline lines from TestExpectations. webkitpy.common.system.log_utils: [DEBUG] Debug logging enabled. webkitpy.common.system.executive: [DEBUG] "git rev-parse --is-inside-work-tree" took 0.02s webkitpy.common.system.executive: [DEBUG] "git rev-parse --show-toplevel" took 0.01s webkitpy.tool.commands.rebaseline: [INFO] Retrieving results for win-win10 from WebKit Win10. webkitpy.tool.commands.rebaseline: [INFO] fast/table/backgr_position-table-column-group.html (png,wav,txt) webkitpy.tool.commands.rebaseline: [INFO] Retrieving results for win-win7 from WebKit Win7. webkitpy.tool.commands.rebaseline: [INFO] fast/table/backgr_position-table-column-group.html (png,wav,txt) webkitpy.common.system.executive: [DEBUG] "git diff HEAD --no-renames --name-only -- /ssd/work/chrome/src/third_party/WebKit/LayoutTests" took 0.44s webkitpy.tool.commands.rebaseline: [INFO] Rebaselining fast/table/backgr_position-table-column-group.html webkitpy.tool.commands.rebaseline: [DEBUG] Build(builder_name='WebKit Win10', build_number=None): png,wav,txt webkitpy.tool.commands.rebaseline: [DEBUG] Build(builder_name='WebKit Win7', build_number=None): png,wav,txt webkitpy.tool.commands.rebaseline: [DEBUG] No test result for test fast/table/backgr_position-table-column-group.html in build Build(builder_name='WebKit Win10', build_number=None) webkitpy.tool.commands.rebaseline: [ERROR] webkitpy.common.system.log_utils: [DEBUG] Debug logging enabled. webkitpy.common.system.executive: [DEBUG] "git rev-parse --is-inside-work-tree" took 0.02s webkitpy.common.system.executive: [DEBUG] "git rev-parse --show-toplevel" took 0.01s webkitpy.tool.commands.rebaseline: [DEBUG] Could not add file based off output "" webkitpy.tool.commands.rebaseline: [ERROR] webkitpy.common.system.log_utils: [DEBUG] Debug logging enabled. webkitpy.common.system.executive: [DEBUG] "git rev-parse --is-inside-work-tree" took 0.01s webkitpy.common.system.executive: [DEBUG] "git rev-parse --show-toplevel" took 0.02s webkitpy.tool.commands.rebaseline: [DEBUG] Retrieving source https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7/results/layout-test-results/fast/table/backgr_position-table-column-group-actual.txt for target /ssd/work/chrome/src/third_party/WebKit/LayoutTests/platform/win7/fast/table/backgr_position-table-column-group-expected.txt. webkitpy.tool.commands.rebaseline: [DEBUG] Retrieving source https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7/results/layout-test-results/fast/table/backgr_position-table-column-group-actual.png for target /ssd/work/chrome/src/third_party/WebKit/LayoutTests/platform/win7/fast/table/backgr_position-table-column-group-expected.png. webkitpy.tool.commands.rebaseline: [DEBUG] No test result for test fast/table/backgr_position-table-column-group.html in build Build(builder_name='WebKit Win10', build_number=None) webkitpy.tool.commands.rebaseline: [ERROR] webkitpy.common.system.log_utils: [DEBUG] Debug logging enabled. webkitpy.common.system.executive: [DEBUG] "git rev-parse --is-inside-work-tree" took 0.01s webkitpy.common.system.executive: [DEBUG] "git rev-parse --show-toplevel" took 0.01s webkitpy.common.checkout.baseline_optimizer: [DEBUG] Optimizing regular fallback path. webkitpy.common.checkout.baseline_optimizer: [DEBUG] backgr_position-table-column-group-expected.txt: (already optimal) webkitpy.common.checkout.baseline_optimizer: [DEBUG] linux: 428a07 webkitpy.common.checkout.baseline_optimizer: [DEBUG] mac: 9816c0 webkitpy.common.checkout.baseline_optimizer: [DEBUG] win: 991b77 webkitpy.common.checkout.baseline_optimizer: [DEBUG] win7: 214bbc webkitpy.common.checkout.baseline_optimizer: [DEBUG] Optimizing regular fallback path. webkitpy.common.checkout.baseline_optimizer: [DEBUG] backgr_position-table-column-group-expected.png: (already optimal) webkitpy.common.checkout.baseline_optimizer: [DEBUG] linux: c2cabc webkitpy.common.checkout.baseline_optimizer: [DEBUG] mac: 843a63 webkitpy.common.checkout.baseline_optimizer: [DEBUG] mac-mac10.10: 638447 webkitpy.common.checkout.baseline_optimizer: [DEBUG] mac-mac10.9: 49842d webkitpy.common.checkout.baseline_optimizer: [DEBUG] win: bae656 webkitpy.common.checkout.baseline_optimizer: [DEBUG] win7: ac3f3e webkitpy.tool.commands.rebaseline: [DEBUG] Could not add file based off output "" webkitpy.common.system.executive: [DEBUG] "git status -z" took 0.97s webkitpy.common.system.executive: [DEBUG] "git add" took 0.02s
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fc8a7790843c9a31a1f251d25395277b9077a82 commit 2fc8a7790843c9a31a1f251d25395277b9077a82 Author: qyearsley <qyearsley@chromium.org> Date: Fri Jan 27 20:29:41 2017 Add build link to rebaseline-o-matic CL descriptions. Currently, when debugging rebaseline-o-matic changes, it's a bit hard to find the logs since there are so many rebaseline-o-matic jobs. This should make it a bit faster to find the logs for debugging. BUG= 676748 Review-Url: https://codereview.chromium.org/2658983003 Cr-Commit-Position: refs/heads/master@{#446750} [modify] https://crrev.com/2fc8a7790843c9a31a1f251d25395277b9077a82/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py [modify] https://crrev.com/2fc8a7790843c9a31a1f251d25395277b9077a82/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline.py [modify] https://crrev.com/2fc8a7790843c9a31a1f251d25395277b9077a82/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py [modify] https://crrev.com/2fc8a7790843c9a31a1f251d25395277b9077a82/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
,
Jan 28 2017
Thanks wangxianzhu@ for reproducing and pasting the log. It looks like one import line was: webkitpy.tool.commands.rebaseline: [DEBUG] No test result for test fast/table/backgr_position-table-column-group.html in build Build(builder_name='WebKit Win10', build_number=None) (Note that build_number=None here means latest build results, from aggregated results directory in Google Storage).
,
Jan 29 2017
A small correction to #7: the output was for crbug.com/686851 [ Win ] fast/table/backgr_position-table-column-group.html [ Rebaseline ], though rebaseline also fails without '[ Win ]'. Re #8: I think the Win10 message is because that the test passes on Win10. I don't think it's the reason of the failure. Tried to use7 crbug.com/686851 [ Win7 ] fast/table/backgr_position-table-column-group.html [ Rebaseline ] and webkit-patch rebaseline-cl outputs the following and did nothing but removed the above line. ~/chrome/src/third_party/WebKit test$ webkit-patch rebaseline-expectations -v webkitpy.common.system.log_utils: [DEBUG] Debug logging enabled. webkitpy.common.system.executive: [DEBUG] "git rev-parse --is-inside-work-tree" took 0.01s webkitpy.common.system.executive: [DEBUG] "git rev-parse --show-toplevel" took 0.01s webkitpy.tool.commands.rebaseline: [INFO] Retrieving results for win-win7 from WebKit Win7. webkitpy.tool.commands.rebaseline: [INFO] fast/table/backgr_position-table-column-group.html (png,wav,txt) webkitpy.common.system.executive: [DEBUG] "git diff HEAD --no-renames --name-only -- /ssd/work/chrome/src/third_party/WebKit/LayoutTests" took 0.38s webkitpy.tool.commands.rebaseline: [INFO] Rebaselining fast/table/backgr_position-table-column-group.html webkitpy.tool.commands.rebaseline: [DEBUG] Build(builder_name='WebKit Win7', build_number=None): png,wav,txt webkitpy.tool.commands.rebaseline: [ERROR] webkitpy.common.system.log_utils: [DEBUG] Debug logging enabled. webkitpy.common.system.executive: [DEBUG] "git rev-parse --is-inside-work-tree" took 0.02s webkitpy.common.system.executive: [DEBUG] "git rev-parse --show-toplevel" took 0.01s webkitpy.tool.commands.rebaseline: [DEBUG] Could not add file based off output "" webkitpy.tool.commands.rebaseline: [ERROR] webkitpy.common.system.log_utils: [DEBUG] Debug logging enabled. webkitpy.common.system.executive: [DEBUG] "git rev-parse --is-inside-work-tree" took 0.01s webkitpy.common.system.executive: [DEBUG] "git rev-parse --show-toplevel" took 0.01s webkitpy.tool.commands.rebaseline: [DEBUG] Retrieving source https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7/results/layout-test-results/fast/table/backgr_position-table-column-group-actual.txt for target /ssd/work/chrome/src/third_party/WebKit/LayoutTests/platform/win7/fast/table/backgr_position-table-column-group-expected.txt. webkitpy.tool.commands.rebaseline: [DEBUG] Retrieving source https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7/results/layout-test-results/fast/table/backgr_position-table-column-group-actual.png for target /ssd/work/chrome/src/third_party/WebKit/LayoutTests/platform/win7/fast/table/backgr_position-table-column-group-expected.png. webkitpy.tool.commands.rebaseline: [ERROR] webkitpy.common.system.log_utils: [DEBUG] Debug logging enabled. webkitpy.common.system.executive: [DEBUG] "git rev-parse --is-inside-work-tree" took 0.01s webkitpy.common.system.executive: [DEBUG] "git rev-parse --show-toplevel" took 0.01s webkitpy.common.checkout.baseline_optimizer: [DEBUG] Optimizing regular fallback path. webkitpy.common.checkout.baseline_optimizer: [DEBUG] backgr_position-table-column-group-expected.txt: (already optimal) webkitpy.common.checkout.baseline_optimizer: [DEBUG] linux: 428a07 webkitpy.common.checkout.baseline_optimizer: [DEBUG] mac: 9816c0 webkitpy.common.checkout.baseline_optimizer: [DEBUG] win: 991b77 webkitpy.common.checkout.baseline_optimizer: [DEBUG] win7: 214bbc webkitpy.common.checkout.baseline_optimizer: [DEBUG] Optimizing regular fallback path. webkitpy.common.checkout.baseline_optimizer: [DEBUG] backgr_position-table-column-group-expected.png: (already optimal) webkitpy.common.checkout.baseline_optimizer: [DEBUG] linux: c2cabc webkitpy.common.checkout.baseline_optimizer: [DEBUG] mac: 843a63 webkitpy.common.checkout.baseline_optimizer: [DEBUG] mac-mac10.10: 638447 webkitpy.common.checkout.baseline_optimizer: [DEBUG] mac-mac10.9: 49842d webkitpy.common.checkout.baseline_optimizer: [DEBUG] win: bae656 webkitpy.common.checkout.baseline_optimizer: [DEBUG] win7: ac3f3e webkitpy.tool.commands.rebaseline: [DEBUG] Could not add file based off output "" webkitpy.common.system.executive: [DEBUG] "git status -z" took 0.84s webkitpy.common.system.executive: [DEBUG] "git add" took 0.01s
,
Feb 25 2017
Encountered the bug again. https://codereview.chromium.org/2704383008 is supposed to rebaseline 26 tests, but it only rebaselined 16 of them, leaving 10 failing. I'm raising the priority because this is causing much trouble for committers and sheriffs. As I can reproduce it now, I'll take a look into it.
,
Feb 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d51e157fdf0e87ba5fdc470dc18c3c75f7a27eef commit d51e157fdf0e87ba5fdc470dc18c3c75f7a27eef Author: wangxianzhu <wangxianzhu@chromium.org> Date: Sat Feb 25 21:08:00 2017 Abort rebaseline of some virtual/disable-spinvalidation tests Because of crbug.com/676748 , the rebaseline will definitely fail again. Mark them NeedsManualRebaseline until crbug.com/676748 is fixed. BUG= 676748 TBR=qyearsley@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2719703002 Cr-Commit-Position: refs/heads/master@{#453104} [modify] https://crrev.com/d51e157fdf0e87ba5fdc470dc18c3c75f7a27eef/third_party/WebKit/LayoutTests/TestExpectations
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc6161dbf888519842e446982a6e0a86c7476df6 commit fc6161dbf888519842e446982a6e0a86c7476df6 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:13:10 2017 Fix rebaseline bug when new files are under untracked directories Previously when some new baseline files are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline files not added. Add '--untracked-files=all' paramter to 'git status' command to show untracked files under untracked directories. BUG= 676748 Review-Url: https://codereview.chromium.org/2713383002 Cr-Commit-Position: refs/heads/master@{#453260} [modify] https://crrev.com/fc6161dbf888519842e446982a6e0a86c7476df6/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc6161dbf888519842e446982a6e0a86c7476df6 commit fc6161dbf888519842e446982a6e0a86c7476df6 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:13:10 2017 Fix rebaseline bug when new files are under untracked directories Previously when some new baseline files are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline files not added. Add '--untracked-files=all' paramter to 'git status' command to show untracked files under untracked directories. BUG= 676748 Review-Url: https://codereview.chromium.org/2713383002 Cr-Commit-Position: refs/heads/master@{#453260} [modify] https://crrev.com/fc6161dbf888519842e446982a6e0a86c7476df6/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc6161dbf888519842e446982a6e0a86c7476df6 commit fc6161dbf888519842e446982a6e0a86c7476df6 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:13:10 2017 Fix rebaseline bug when new files are under untracked directories Previously when some new baseline files are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline files not added. Add '--untracked-files=all' paramter to 'git status' command to show untracked files under untracked directories. BUG= 676748 Review-Url: https://codereview.chromium.org/2713383002 Cr-Commit-Position: refs/heads/master@{#453260} [modify] https://crrev.com/fc6161dbf888519842e446982a6e0a86c7476df6/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0ececae52cee97be01efd0ab698d06ffafb23bb commit e0ececae52cee97be01efd0ab698d06ffafb23bb Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:38:43 2017 Rebaseline tests that weren't correctly rebaselined because of bug 676748 BUG= 676748 , 696398 TBR=wangxianzhu@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2720723003 Cr-Commit-Position: refs/heads/master@{#453270} [modify] https://crrev.com/e0ececae52cee97be01efd0ab698d06ffafb23bb/third_party/WebKit/LayoutTests/TestExpectations
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc6161dbf888519842e446982a6e0a86c7476df6 commit fc6161dbf888519842e446982a6e0a86c7476df6 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:13:10 2017 Fix rebaseline bug when new files are under untracked directories Previously when some new baseline files are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline files not added. Add '--untracked-files=all' paramter to 'git status' command to show untracked files under untracked directories. BUG= 676748 Review-Url: https://codereview.chromium.org/2713383002 Cr-Commit-Position: refs/heads/master@{#453260} [modify] https://crrev.com/fc6161dbf888519842e446982a6e0a86c7476df6/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0ececae52cee97be01efd0ab698d06ffafb23bb commit e0ececae52cee97be01efd0ab698d06ffafb23bb Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:38:43 2017 Rebaseline tests that weren't correctly rebaselined because of bug 676748 BUG= 676748 , 696398 TBR=wangxianzhu@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2720723003 Cr-Commit-Position: refs/heads/master@{#453270} [modify] https://crrev.com/e0ececae52cee97be01efd0ab698d06ffafb23bb/third_party/WebKit/LayoutTests/TestExpectations
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc6161dbf888519842e446982a6e0a86c7476df6 commit fc6161dbf888519842e446982a6e0a86c7476df6 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:13:10 2017 Fix rebaseline bug when new files are under untracked directories Previously when some new baseline files are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline files not added. Add '--untracked-files=all' paramter to 'git status' command to show untracked files under untracked directories. BUG= 676748 Review-Url: https://codereview.chromium.org/2713383002 Cr-Commit-Position: refs/heads/master@{#453260} [modify] https://crrev.com/fc6161dbf888519842e446982a6e0a86c7476df6/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0ececae52cee97be01efd0ab698d06ffafb23bb commit e0ececae52cee97be01efd0ab698d06ffafb23bb Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:38:43 2017 Rebaseline tests that weren't correctly rebaselined because of bug 676748 BUG= 676748 , 696398 TBR=wangxianzhu@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2720723003 Cr-Commit-Position: refs/heads/master@{#453270} [modify] https://crrev.com/e0ececae52cee97be01efd0ab698d06ffafb23bb/third_party/WebKit/LayoutTests/TestExpectations
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc6161dbf888519842e446982a6e0a86c7476df6 commit fc6161dbf888519842e446982a6e0a86c7476df6 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:13:10 2017 Fix rebaseline bug when new files are under untracked directories Previously when some new baseline files are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline files not added. Add '--untracked-files=all' paramter to 'git status' command to show untracked files under untracked directories. BUG= 676748 Review-Url: https://codereview.chromium.org/2713383002 Cr-Commit-Position: refs/heads/master@{#453260} [modify] https://crrev.com/fc6161dbf888519842e446982a6e0a86c7476df6/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc6161dbf888519842e446982a6e0a86c7476df6 commit fc6161dbf888519842e446982a6e0a86c7476df6 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:13:10 2017 Fix rebaseline bug when new files are under untracked directories Previously when some new baseline files are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline files not added. Add '--untracked-files=all' paramter to 'git status' command to show untracked files under untracked directories. BUG= 676748 Review-Url: https://codereview.chromium.org/2713383002 Cr-Commit-Position: refs/heads/master@{#453260} [modify] https://crrev.com/fc6161dbf888519842e446982a6e0a86c7476df6/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc6161dbf888519842e446982a6e0a86c7476df6 commit fc6161dbf888519842e446982a6e0a86c7476df6 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:13:10 2017 Fix rebaseline bug when new files are under untracked directories Previously when some new baseline files are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline files not added. Add '--untracked-files=all' paramter to 'git status' command to show untracked files under untracked directories. BUG= 676748 Review-Url: https://codereview.chromium.org/2713383002 Cr-Commit-Position: refs/heads/master@{#453260} [modify] https://crrev.com/fc6161dbf888519842e446982a6e0a86c7476df6/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0ececae52cee97be01efd0ab698d06ffafb23bb commit e0ececae52cee97be01efd0ab698d06ffafb23bb Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:38:43 2017 Rebaseline tests that weren't correctly rebaselined because of bug 676748 BUG= 676748 , 696398 TBR=wangxianzhu@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2720723003 Cr-Commit-Position: refs/heads/master@{#453270} [modify] https://crrev.com/e0ececae52cee97be01efd0ab698d06ffafb23bb/third_party/WebKit/LayoutTests/TestExpectations
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc6161dbf888519842e446982a6e0a86c7476df6 commit fc6161dbf888519842e446982a6e0a86c7476df6 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:13:10 2017 Fix rebaseline bug when new files are under untracked directories Previously when some new baseline files are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline files not added. Add '--untracked-files=all' paramter to 'git status' command to show untracked files under untracked directories. BUG= 676748 Review-Url: https://codereview.chromium.org/2713383002 Cr-Commit-Position: refs/heads/master@{#453260} [modify] https://crrev.com/fc6161dbf888519842e446982a6e0a86c7476df6/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc6161dbf888519842e446982a6e0a86c7476df6 commit fc6161dbf888519842e446982a6e0a86c7476df6 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:13:10 2017 Fix rebaseline bug when new files are under untracked directories Previously when some new baseline files are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline files not added. Add '--untracked-files=all' paramter to 'git status' command to show untracked files under untracked directories. BUG= 676748 Review-Url: https://codereview.chromium.org/2713383002 Cr-Commit-Position: refs/heads/master@{#453260} [modify] https://crrev.com/fc6161dbf888519842e446982a6e0a86c7476df6/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0ececae52cee97be01efd0ab698d06ffafb23bb commit e0ececae52cee97be01efd0ab698d06ffafb23bb Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:38:43 2017 Rebaseline tests that weren't correctly rebaselined because of bug 676748 BUG= 676748 , 696398 TBR=wangxianzhu@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2720723003 Cr-Commit-Position: refs/heads/master@{#453270} [modify] https://crrev.com/e0ececae52cee97be01efd0ab698d06ffafb23bb/third_party/WebKit/LayoutTests/TestExpectations
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0ececae52cee97be01efd0ab698d06ffafb23bb commit e0ececae52cee97be01efd0ab698d06ffafb23bb Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:38:43 2017 Rebaseline tests that weren't correctly rebaselined because of bug 676748 BUG= 676748 , 696398 TBR=wangxianzhu@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2720723003 Cr-Commit-Position: refs/heads/master@{#453270} [modify] https://crrev.com/e0ececae52cee97be01efd0ab698d06ffafb23bb/third_party/WebKit/LayoutTests/TestExpectations
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc6161dbf888519842e446982a6e0a86c7476df6 commit fc6161dbf888519842e446982a6e0a86c7476df6 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:13:10 2017 Fix rebaseline bug when new files are under untracked directories Previously when some new baseline files are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline files not added. Add '--untracked-files=all' paramter to 'git status' command to show untracked files under untracked directories. BUG= 676748 Review-Url: https://codereview.chromium.org/2713383002 Cr-Commit-Position: refs/heads/master@{#453260} [modify] https://crrev.com/fc6161dbf888519842e446982a6e0a86c7476df6/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0ececae52cee97be01efd0ab698d06ffafb23bb commit e0ececae52cee97be01efd0ab698d06ffafb23bb Author: wangxianzhu <wangxianzhu@chromium.org> Date: Mon Feb 27 18:38:43 2017 Rebaseline tests that weren't correctly rebaselined because of bug 676748 BUG= 676748 , 696398 TBR=wangxianzhu@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2720723003 Cr-Commit-Position: refs/heads/master@{#453270} [modify] https://crrev.com/e0ececae52cee97be01efd0ab698d06ffafb23bb/third_party/WebKit/LayoutTests/TestExpectations
,
Feb 27 2017
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f19cdc7ac0d961eeb71c3c279856c25f33ef1227 commit f19cdc7ac0d961eeb71c3c279856c25f33ef1227 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Mon Feb 27 23:32:13 2017 Auto-rebaseline for r453270 Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/618257 https://chromium.googlesource.com/chromium/src/+/e0ececae52cee BUG= 676748 , 696398 TBR=wangxianzhu@chromium.org Review-Url: https://codereview.chromium.org/2720923003 . Cr-Commit-Position: refs/heads/master@{#453389} [modify] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/flexbox/repaint-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/selection/selection-in-non-composited-scrolling-container-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/table/resize-table-repaint-percent-size-cell-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/table/resize-table-repaint-vertical-align-cell-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/table/resize-table-row-repaint-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/disable-spinvalidation/paint/invalidation/forms/button-reset-focus-by-mouse-then-keydown-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/disable-spinvalidation/paint/invalidation/forms/submit-focus-by-mouse-then-keydown-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/disable-spinvalidation/paint/invalidation/forms/submit-focus-by-mouse-then-keydown-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/disable-spinvalidation/paint/invalidation/selection/selection-in-non-composited-scrolling-container-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/flexbox/repaint-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/forms/button-reset-focus-by-mouse-then-keydown-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/forms/range-focus-by-mouse-then-keydown-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/forms/submit-focus-by-mouse-then-keydown-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/selection/selection-in-non-composited-scrolling-container-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/table/resize-table-repaint-percent-size-cell-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/table/resize-table-repaint-vertical-align-cell-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/table/resize-table-row-repaint-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/flexbox/repaint-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/forms/button-reset-focus-by-mouse-then-keydown-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/forms/range-focus-by-mouse-then-keydown-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/forms/submit-focus-by-mouse-then-keydown-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/selection/selection-in-non-composited-scrolling-container-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/table/resize-table-repaint-percent-size-cell-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/table/resize-table-repaint-vertical-align-cell-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/table/resize-table-row-repaint-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/platform/win7/virtual/disable-spinvalidation/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/compositing/should-not-repaint-composited-descendants-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/css-grid-layout/grid-element-change-columns-repaint-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/css-grid-layout/grid-element-change-rows-repaint-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/flexbox/scrollbars-changed-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/table/border-collapse-change-collapse-to-separate-expected.txt [add] https://crrev.com/f19cdc7ac0d961eeb71c3c279856c25f33ef1227/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/table/border-collapse-change-separate-to-collapse-expected.txt |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by wangxianzhu@chromium.org
, Dec 23 2016