New issue
Advanced search Search tips

Issue 676746 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"OmniboxViewViewsTest.SelectionClipboard" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 23 2016

Issue description

"OmniboxViewViewsTest.SelectionClipboard" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMgsSBUZsYWtlIidPbW5pYm94Vmlld1ZpZXdzVGVzdC5TZWxlY3Rpb25DbGlwYm9hcmQM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dea296de1bb5b61515994926d3ece3165274ffc2

commit dea296de1bb5b61515994926d3ece3165274ffc2
Author: dbeam <dbeam@chromium.org>
Date: Fri Dec 23 02:46:48 2016

Disable flaky test OmniboxViewViewsTest.SelectionClipboard

TBR=msw@chromium.org
BUG= 676746 

Review-Url: https://codereview.chromium.org/2597403002
Cr-Commit-Position: refs/heads/master@{#440586}

[modify] https://crrev.com/dea296de1bb5b61515994926d3ece3165274ffc2/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

Cc: msw@chromium.org
Labels: -Sheriff-Chromium
Owner: dbeam@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by dbeam@chromium.org, Dec 28 2016

Owner: ----
Status: Available (was: Assigned)

Comment 4 by msw@chromium.org, Dec 28 2016

From the list linked above, It seems likely that a recent Cl introduced flakiness.
The first recent failure was: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/361694
The git log from that run: https://chromium.googlesource.com/chromium/src/+log/c856108d12afdf9d3fea36a6f71c7439ccc04143
I don't see anything obvious, but there's likely to be a culprit within about a day there.
It might make sense to just try rewriting the test, but I'm just going to add a comment for now.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4ce7dbac01a9f1c86e966d11075e88258ac99be

commit a4ce7dbac01a9f1c86e966d11075e88258ac99be
Author: msw <msw@chromium.org>
Date: Wed Dec 28 18:37:26 2016

Add a TODO comment to fix OmniboxViewViewsTest.SelectionClipboard.

BUG= 676746 
TBR=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2606943002
Cr-Commit-Position: refs/heads/master@{#440869}

[modify] https://crrev.com/a4ce7dbac01a9f1c86e966d11075e88258ac99be/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

Project Member

Comment 6 by sheriffbot@chromium.org, Feb 15 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00d08cce6b85cb9c8a141aee211e33847ab4c57b

commit 00d08cce6b85cb9c8a141aee211e33847ab4c57b
Author: Mike Wasserman <msw@chromium.org>
Date: Fri Feb 16 17:08:06 2018

Enable Linux-only OmniboxViewViewsTest.SelectionClipboard

This test seems to work as-is, and passed 100 times in a row locally.
Hopefully it's no longer flaky; let's give it a shot.

Bug:  676746 
Change-Id: I28857f2c97b354160bd945bb284083b080938899
Reviewed-on: https://chromium-review.googlesource.com/922794
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537329}
[modify] https://crrev.com/00d08cce6b85cb9c8a141aee211e33847ab4c57b/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

Comment 8 by msw@chromium.org, Feb 16 2018

Status: Fixed (was: Untriaged)
I'll mark this fixed now, and see if it sticks.

Sign in to add a comment