New issue
Advanced search Search tips

Issue 676730 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
chanli@chromium.org
seanmccullough@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocked on:
issue 596226


Sign in to add a comment

Do not re-add queue label (e.g. Sheriff-Chromium) when the test is disabled (based on data reported to event_mon)

Project Member Reported by hcarmona@chromium.org, Dec 22 2016 
Timeline:
2016-12-21 20:52:07 UTC -  http://crbug.com/676429  is created
2016-12-22 01:33:33 UTC - Test is disabled
2016-12-22 20:53:07 UTC - Bug is updated with "Detected 11 new flakes for test/step"

Link in comment shows last flake at 2016-12-22 01:42:07 UTC

It's expected that chromium-try-flakes only update a bug if new flakes are detected.

Comment 1 by serg...@chromium.org, Jan 9 2017

Blockedon: 596226
Status: Available (was: Untriaged)
Summary: Do not re-add queue label (e.g. Sheriff-Chromium) when the test is disabled (based on data reported to event_mon) (was: chromium-try-flakes should not update with "new" flakes detected when there are none)
Even though the test was disabled, some flakes have happened after the previous report and before the CL disabling the test landed, which has caused chromium-try-flakes to post another message. This is also why we ask sheriffs to disable a test within 30 minutes, but even within those 30 minutes a test may flake again, especially if it's very flaky.

IMHO reporting flakes on the bug is the right action to do, but IMHO we should check if the test is disabled and skip re-adding the Sheriff-Chromium label. Unfortunately, with the current system this is non-trivial and with the current focus on Flakiness Surface project, it may take a while before this will fixed. Sorry for that.
Project Member

Comment 2 by sheriffbot@chromium.org, Feb 15 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment