enhanced reading list confirmation |
|||||||||
Issue descriptionEnhancing confirmation to 'Read Later' functionality when adding a page to Bling Reading List from another browser Would also affect [Add to Bookmarks] for consistency. Current behavior: 1) User selects Chrome from Action sheet from another browser 2) Selects Read Later, bg fills to highlighted state 3) Dialogue immediately dismisses top 3) [Read Later] fades out, dismisses top Desired behavior: 1) User selects Chrome from Action sheet from another browser 2) Selects [Read Later], bg fills to highlighted state (not shown in prototype) 3) [Read Later] fades out 4) [Added] pops in 5) [✔] pops in 6) Dismisses top (lowfi keynote) prototype attached for reference. cc: Helene for motion details.
,
Dec 23 2016
+jif our animation specialist.
,
Dec 23 2016
How is "Added pop in" and dismiss sequenced? If we want the user to be able to read "Added [check]", should we let it a long time?
,
Jan 2 2017
mardini, can you validate this animation?
,
Jan 2 2017
I think we need to see the animation with the background colour change for the pressed button all the way until the pop up is dismissed to judge, no?
,
Jan 3 2017
I honestly prefer to shrink the whole dialog into a small widget having the Chrome icon and small string saying "Done" or "Added" and possibly a check mark à la Pocket extension. Putting the visual feedback under the users finger risks making it invisible.
,
Jan 4 2017
Keeping the confirmation light and immediate in the existing space (rather than adding an additional state) is a feature not a bug ;)
,
Jan 6 2017
Shoulw we use the unicode ✔ ?
,
Jan 6 2017
Should both button have the same behavior?
,
Jan 6 2017
My answer is yes for both questions in #8 and #9. Helene, Amy: wdyt?
,
Jan 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/944e00928bdee6bd6961c095cca361586f4a3478 commit 944e00928bdee6bd6961c095cca361586f4a3478 Author: olivierrobin <olivierrobin@chromium.org> Date: Mon Jan 09 08:13:17 2017 Animate IOS Share extension button. Animation on the share extension is in 3 steps: - label disappears - "Added" appears - a checkmark appears after added. BUG= 676724 Review-Url: https://codereview.chromium.org/2617993002 Cr-Commit-Position: refs/heads/master@{#442207} [modify] https://crrev.com/944e00928bdee6bd6961c095cca361586f4a3478/ios/chrome/share_extension/share_extension_localize_strings_config.plist [modify] https://crrev.com/944e00928bdee6bd6961c095cca361586f4a3478/ios/chrome/share_extension/share_extension_view.mm [modify] https://crrev.com/944e00928bdee6bd6961c095cca361586f4a3478/ios/chrome/share_extension/share_view_controller.mm [modify] https://crrev.com/944e00928bdee6bd6961c095cca361586f4a3478/ios/chrome/share_extension/strings/ios_share_extension_strings.grd [modify] https://crrev.com/944e00928bdee6bd6961c095cca361586f4a3478/ios/chrome/share_extension/ui_util.h [modify] https://crrev.com/944e00928bdee6bd6961c095cca361586f4a3478/ios/chrome/share_extension/ui_util.mm
,
Jan 9 2017
,
Jan 9 2017
Agree on #8 & #9
,
Jan 10 2017
Verified in 57.0.2977.0 canary, iPhone 6S iOS 10.1, iPhone 6 plus 10.2, iPad mini 10.1 Animation on the share extension: - label disappears - "Added" appears - a checkmark appears after added. Looks good |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by mard...@chromium.org
, Dec 22 2016Labels: -Pri-3 M-57 Hotlist-ReadingList Pri-2
Owner: helenepark@chromium.org
Status: Assigned (was: Untriaged)