Remove debug CHECK from didCommitNavigation: |
||||||
Issue descriptiondidCommitNavigation: crashes when called when NavigationManager is empty. This probably happens because |registerLoadRequest| was not called from |didStartProvisionalNavigation:| when a child window was open by DOM. eugenebut@ added a CHECK to didCommitNavigation: to verify this assumption and CHECK must be removed before shipping M47. Keeping check until beta should be sufficient to collect necessary crash logs on canary.
,
Feb 2 2017
,
Feb 2 2017
,
Feb 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7dda59dad207a6642d7a201e7ed088f3e8bad92 commit c7dda59dad207a6642d7a201e7ed088f3e8bad92 Author: eugenebut <eugenebut@chromium.org> Date: Fri Feb 03 20:06:40 2017 Removed investigation CHECK from didCommitNavigation. This CHECK did not fire. Either because WKNavigation object is nil or because the assumption from crbug.com/676721 was incorrect. BUG= 676721 Review-Url: https://codereview.chromium.org/2672673002 Cr-Commit-Position: refs/heads/master@{#448058} [modify] https://crrev.com/c7dda59dad207a6642d7a201e7ed088f3e8bad92/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/c7dda59dad207a6642d7a201e7ed088f3e8bad92/ios/web/web_state/ui/crw_wk_navigation_states.h [modify] https://crrev.com/c7dda59dad207a6642d7a201e7ed088f3e8bad92/ios/web/web_state/ui/crw_wk_navigation_states.mm [modify] https://crrev.com/c7dda59dad207a6642d7a201e7ed088f3e8bad92/ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm
,
Feb 4 2017
,
Feb 4 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f09ebb60a6b4cc4e6854bde63c64badc7b9ce576 commit f09ebb60a6b4cc4e6854bde63c64badc7b9ce576 Author: eugenebut <eugenebut@chromium.org> Date: Sat Feb 04 04:04:16 2017 Removed investigation CHECK from didCommitNavigation. This CHECK did not fire. Either because WKNavigation object is nil or because the assumption from crbug.com/676721 was incorrect. BUG= 676721 TBR=kknorimoto@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2672673002 Cr-Commit-Position: refs/heads/master@{#448058} (cherry picked from commit c7dda59dad207a6642d7a201e7ed088f3e8bad92) Review-Url: https://codereview.chromium.org/2678473003 Cr-Commit-Position: refs/branch-heads/2987@{#308} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/f09ebb60a6b4cc4e6854bde63c64badc7b9ce576/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/f09ebb60a6b4cc4e6854bde63c64badc7b9ce576/ios/web/web_state/ui/crw_wk_navigation_states.h [modify] https://crrev.com/f09ebb60a6b4cc4e6854bde63c64badc7b9ce576/ios/web/web_state/ui/crw_wk_navigation_states.mm [modify] https://crrev.com/f09ebb60a6b4cc4e6854bde63c64badc7b9ce576/ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by eugene...@chromium.org
, Jan 18 2017