New issue
Advanced search Search tips

Issue 676714 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 661143



Sign in to add a comment

ProfileBrowserTests db open flakes on Mac ASAN 64 under history redirect experiment

Project Member Reported by gab@chromium.org, Dec 22 2016

Issue description

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/25853

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/25845/steps/browser_tests/logs/ProfileBrowserTest.CreateNewProfileSynchronous

ProfileBrowserTest.CreateNewProfileSynchronous (run #1):
[ RUN      ] ProfileBrowserTest.CreateNewProfileSynchronous
[61046:7431:1222/082919.774412:ERROR:variations_util.cc(88)] Missing Worker Pool Configuration: Background
[61046:29187:1222/082919.918154:WARNING:mac_util.mm(222)] Failed to set backup exclusion for file '/private/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.hxVmFK/dGsXDpE/Default/History': Error Domain=NSOSStatusErrorDomain Code=-50 "The operation couldn?t be completed. (OSStatus error -50.)" (paramErr: error in user parameter list) (-50)
[61046:29187:1222/082920.133497:WARNING:mac_util.mm(222)] Failed to set backup exclusion for file '/private/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.hxVmFK/dGsXDpE/Default/Favicons': Error Domain=NSOSStatusErrorDomain Code=-50 "The operation couldn?t be completed. (OSStatus error -50.)" (paramErr: error in user parameter list) (-50)
[61056:3335:1222/082920.371415:WARNING:vt_video_decode_accelerator_mac.cc(169)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "The operation couldn?t be completed. (OSStatus error -8973.)" (codecOpenErr) (-8973)
[61056:3335:1222/082920.374778:WARNING:vt_video_decode_accelerator_mac.cc(191)] Failed to create hardware VideoToolbox session
[61056:3335:1222/082920.484061:ERROR:vt_video_encode_accelerator_mac.cc(518)]  VTCompressionSessionCreate failed: -12908
[61046:29187:1222/082921.437821:WARNING:mac_util.mm(222)] Failed to set backup exclusion for file '/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.65h4RB/History': Error Domain=NSOSStatusErrorDomain Code=-50 "The operation couldn?t be completed. (OSStatus error -50.)" (paramErr: error in user parameter list) (-50)
[61046:29187:1222/082921.690145:ERROR:connection.cc(1947)] Thumbnail sqlite error 14, errno -2: unable to open database file, sql: -- sqlite3_open()
[61046:29187:1222/082921.690318:ERROR:connection.cc(1947)] Thumbnail sqlite error 21, errno -2: unable to open database file, sql: PRAGMA writable_schema=1
[61046:29187:1222/082921.690366:FATAL:connection.cc(1962)] unable to open database file
0   browser_tests                       0x000000010cec3073 _ZN4base5debug10StackTraceC1Ev + 19
1   browser_tests                       0x000000010cf229d0 _ZN7logging10LogMessageD2Ev + 336
2   browser_tests                       0x0000000113bcf2f4 _ZNK3sql10Connection13OnSqliteErrorEiPNS_9StatementEPKc + 2804
3   browser_tests                       0x0000000113bc6b33 _ZN3sql10Connection7ExecuteEPKc + 275
4   browser_tests                       0x0000000113bd7dc2 _ZN3sql8Recovery4InitERKN4base8FilePathE + 402
5   browser_tests                       0x0000000113bd7948 _ZN3sql8Recovery5BeginEPNS_10ConnectionERKN4base8FilePathE + 424
6   browser_tests                       0x00000001142ebf9a _ZN7history12_GLOBAL__N_121DatabaseErrorCallbackEPN3sql10ConnectionERKN4base8FilePathEPNS_20HistoryBackendClientEiPNS1_9StatementE + 698
7   browser_tests                       0x0000000113bcf03e _ZNK3sql10Connection13OnSqliteErrorEiPNS_9StatementEPKc + 2110
8   browser_tests                       0x0000000113bc23f2 _ZN3sql10Connection12OpenInternalERKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEENS0_5RetryE + 1986
9   browser_tests                       0x0000000113bc1ae1 _ZN3sql10Connection4OpenERKN4base8FilePathE + 833
10  browser_tests                       0x00000001142ebbb4 _ZN7history17ThumbnailDatabase12OpenDatabaseEPN3sql10ConnectionERKN4base8FilePathE + 836
11  browser_tests                       0x00000001142e58a2 _ZN7history17ThumbnailDatabase8InitImplERKN4base8FilePathE + 290
12  browser_tests                       0x00000001142e5726 _ZN7history17ThumbnailDatabase4InitERKN4base8FilePathE + 22
13  browser_tests                       0x0000000114275765 _ZN7history14HistoryBackend8InitImplERKNS_21HistoryDatabaseParamsE + 2245
14  browser_tests                       0x0000000114274bc2 _ZN7history14HistoryBackend4InitEbRKNS_21HistoryDatabaseParamsE + 530
15  browser_tests                       0x00000001142dacda _ZN4base8internal7InvokerINS0_9BindStateIMN7history14HistoryBackendEFvbRKNS3_21HistoryDatabaseParamsEEJ13scoped_refptrIS4_EbS5_EEEFvvEE3RunEPNS0_13BindStateBaseE + 490
16  browser_tests                       0x000000010cec4341 _ZN4base5debug13TaskAnnotator7RunTaskEPKcPNS_11PendingTaskE + 817
17  browser_tests                       0x000000010d0634f8 _ZN4base8internal11TaskTracker14PerformRunTaskENSt3__110unique_ptrINS0_4TaskENS2_14default_deleteIS4_EEEE + 216
18  browser_tests                       0x000000010d063f0c _ZN4base8internal16TaskTrackerPosix14PerformRunTaskENSt3__110unique_ptrINS0_4TaskENS2_14default_deleteIS4_EEEE + 316
19  browser_tests                       0x000000010d0619dd _ZN4base8internal11TaskTracker7RunTaskENSt3__110unique_ptrINS0_4TaskENS2_14default_deleteIS4_EEEERKNS_13SequenceTokenE + 2061
20  browser_tests                       0x000000010d04cf23 _ZN4base8internal15SchedulerWorker6Thread10ThreadMainEv + 1587
21  browser_tests                       0x000000010d07dc9e _ZN4base12_GLOBAL__N_110ThreadFuncEPv + 206
22  libsystem_pthread.dylib             0x00007fff96606899 _pthread_body + 138
23  libsystem_pthread.dylib             0x00007fff9660672a _pthread_struct_init + 0
24  libsystem_pthread.dylib             0x00007fff9660afc9 thread_start + 13
 

Comment 1 by gab@chromium.org, Dec 22 2016

Bot turned green with revert (https://codereview.chromium.org/2598033003/) so definitely the cause.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/584e16efe96fd3b746987ac7afc357798f512921

commit 584e16efe96fd3b746987ac7afc357798f512921
Author: fdoray <fdoray@chromium.org>
Date: Fri Jan 06 16:53:38 2017

Flush TaskScheduler in ProfileBrowserTest.*.

When the BrowserScheduler/RedirectHistoryService experiment is disabled,
HistoryService uses a dedicated thread for backend operations. This thread
is joined when the HistoryService is deleted.

When the BrowserScheduler/RedirectHistoryService experiment is enabled,
HistoryService uses a TaskScheduler sequence for backend operations.
These tasks can run after the HistoryService has been deleted.

History backend tasks access databases in the profile directory. A crash
occurs if these accesses occur after the profile directory has been deleted.
To prevent this from happening in ProfileBrowserTest.*., this CL adds code to
flush TaskScheduler before deleting the profile directory.

BUG=661143,  676714 

Review-Url: https://codereview.chromium.org/2611053003
Cr-Commit-Position: refs/heads/master@{#441951}

[modify] https://crrev.com/584e16efe96fd3b746987ac7afc357798f512921/chrome/browser/profiles/profile_browsertest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment