New issue
Advanced search Search tips

Issue 676708 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

realtimeanalyser-fft-scaling test is flaky

Project Member Reported by rtoy@chromium.org, Dec 22 2016 
Because we create many offline contexts and use oncomplete to verify the tests, the order in which the tests finish (and print out results) isn't defined.

We should rewrite the tests to use either the promise pattern or to run the tests in a fixed order, waiting for the previous test to finish before starting another.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faa3e9c3de15cf738fac0bc21406f2af3cc424c7

commit faa3e9c3de15cf738fac0bc21406f2af3cc424c7
Author: rtoy <rtoy@chromium.org>
Date: Tue Jan 03 21:18:29 2017

Convert realtimeanalyser-fft-scaling to testharness

Test converted to use testharness and new Audit.  By doing this, we
also remove the flakiness caused by oncomplete handler finishing at
different times.

The expected result file is also removed.

BUG= 675987 ,  676708 
TEST=realtimeanalyser-fft-scaling.html

Review-Url: https://codereview.chromium.org/2596983004
Cr-Commit-Position: refs/heads/master@{#441209}

[delete] https://crrev.com/c0304f6696623d76672a4c8fbefa16378c3137b8/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling-expected.txt
[modify] https://crrev.com/faa3e9c3de15cf738fac0bc21406f2af3cc424c7/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html

Comment 2 by rtoy@chromium.org, Jan 4 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment