New issue
Advanced search Search tips

Issue 676703 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 597053



Sign in to add a comment

Shorten some of the method names in //third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h

Project Member Reported by juncai@chromium.org, Dec 22 2016

Issue description

Since the device is already a BluetoothDevice, the following methods can be renamed:
getOrCreateBluetoothRemoteGATTService -> getOrCreateRemoteGATTService
getOrCreateBluetoothRemoteGATTCharacteristic -> getOrCreateRemoteGATTCharacteristic
 

Comment 1 by juncai@chromium.org, Dec 28 2016

Status: Started (was: Assigned)
Blocking: 597053
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/599c47bd57be5be9b13126ca4c7678fa3f067481

commit 599c47bd57be5be9b13126ca4c7678fa3f067481
Author: juncai <juncai@chromium.org>
Date: Tue Jan 03 22:41:37 2017

Shorten some method names in //third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h

This is a follow-up CL for:
https://codereview.chromium.org/2565913002/

Since the device is already a BluetoothDevice, the following methods
at BluetoothDevice class can be renamed:
getOrCreateBluetoothRemoteGATTService -> getOrCreateRemoteGATTService
getOrCreateBluetoothRemoteGATTCharacteristic -> getOrCreateRemoteGATTCharacteristic

BUG= 676703 ,  597053 

Review-Url: https://codereview.chromium.org/2614523002
Cr-Commit-Position: refs/heads/master@{#441227}

[modify] https://crrev.com/599c47bd57be5be9b13126ca4c7678fa3f067481/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp
[modify] https://crrev.com/599c47bd57be5be9b13126ca4c7678fa3f067481/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.h
[modify] https://crrev.com/599c47bd57be5be9b13126ca4c7678fa3f067481/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp
[modify] https://crrev.com/599c47bd57be5be9b13126ca4c7678fa3f067481/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h
[modify] https://crrev.com/599c47bd57be5be9b13126ca4c7678fa3f067481/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp
[modify] https://crrev.com/599c47bd57be5be9b13126ca4c7678fa3f067481/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

Status: Fixed (was: Started)

Sign in to add a comment