In the web_bluetooth.mojom, some structs such as: struct WebBluetoothRequestDeviceOptions struct WebBluetoothRemoteGATTCharacteristic can use typemap to simplify the code that use them.
WebBluetoothDeviceId as well can probably be typemapped.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8819858e6747aae06f155f04909b458ee782538c commit 8819858e6747aae06f155f04909b458ee782538c Author: juncai <juncai@chromium.org> Date: Mon Jan 09 23:16:54 2017 Typemap WebBluetoothDeviceId to WTF::String This is a follow-up CL for: https://codereview.chromium.org/2565913002/ This CL does the following: 1. Typemap WebBluetoothDeviceId to WTF::String. 2. Use mojom::blink::WebBluetoothRemoteGATTServicePtr directly in the parameter. 3. Use mojom::blink::WebBluetoothDevicePtr directly in the parameter. 4. Use mojom::blink::WebBluetoothRemoteGATTServicePtr directly in the parameter. BUG= 676702 , 597053 Review-Url: https://codereview.chromium.org/2615093002 Cr-Commit-Position: refs/heads/master@{#442397} [modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp [modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/Bluetooth.h [modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp [modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.h [modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp [modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h [modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp [modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h [modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp [modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp [modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h [modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/platform/mojo/BluetoothStructTraits.cpp [modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/platform/mojo/BluetoothStructTraits.h [modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/platform/mojo/blink_typemaps.gni [rename] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/public/platform/modules/bluetooth/Bluetooth.typemap
Comment 1 by dcheng@chromium.org
, Dec 29 2016