Add presubmit check to enforce tab indents for ebuilds/eclass (and more?) |
||
Issue descriptionI have a CL for this, so let's create a bug now ;)
,
Dec 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3c555daec310719139d2d3cad2f10e57f6c7701a commit 3c555daec310719139d2d3cad2f10e57f6c7701a Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Thu Dec 22 23:23:44 2016 Delete obsolete file ROOT_PRESUBMIT. So the next poor fellow like me doesn't end up trying to fix bugs in it. BUG= chromium:676699 TEST=None. Change-Id: Iaea22e1c57abe12bf3133dc17d017657ef9c99de Reviewed-on: https://chromium-review.googlesource.com/423333 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [delete] https://crrev.com/45d1ca9d64ba5fcc40685f0d5d0b7913c2f86897/ROOT_PRESUBMIT.py
,
Dec 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/repohooks/+/a9de1722459e487e71f27693bfe07dfc4a129ea3 commit a9de1722459e487e71f27693bfe07dfc4a129ea3 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Thu Dec 22 22:56:40 2016 pre-upload: Unbreak per-line checks. Some of the per-line checks (line too long, stray whitespace, tab characters in file) have been broken since https://chromium-review.googlesource.com/#/c/205172/ This CL fixes them. BUG= chromium:676699 TEST=Manual. Create a bogus CL with these issues and run pre-upload.py Change-Id: I51b6ee869a9264b3866d6b4b6fd21b79320fe9a6 Reviewed-on: https://chromium-review.googlesource.com/423002 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/a9de1722459e487e71f27693bfe07dfc4a129ea3/pre-upload.py
,
Jan 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/repohooks/+/c525465c04e76421e42f33721443ec326332e7cf commit c525465c04e76421e42f33721443ec326332e7cf Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Thu Dec 22 20:58:05 2016 pre-upload: Add a check for tabbed indents for ebuild,eclass. I have :set expandtab in vim. Maybe you do too! ebuild/eclass files want tabbed indents. So let's catch that in pre-upload rather than annoying reviewers. BUG= chromium:676699 TEST=(1) (new) unittest. (2) Upload a CL in some ebuild/eclass with/without space indent. Change-Id: If9d9b3e3cfd253960a1d593e9374b4e8664bc8c8 Reviewed-on: https://chromium-review.googlesource.com/423003 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/c525465c04e76421e42f33721443ec326332e7cf/pre-upload_unittest.py [modify] https://crrev.com/c525465c04e76421e42f33721443ec326332e7cf/pre-upload.py
,
Jan 8 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by pprabhu@chromium.org
, Dec 22 2016Status: Started (was: Assigned)