Issue metadata
Sign in to add a comment
|
Cannot drag tab onto full-screen'd window |
||||||||||||||||||||||
Issue descriptionChrome Version: 57.0.2951.0 dev (64-bit) OS: ChromeOS Panther What steps will reproduce the problem? (1) Open two Chrome windows. (2) Hit the full-screen/F4 button to full-screen one of them. (3) Focus the non-full-screen window. (4) Drag the tab out of that window, up to the tab-strip of the full-screen window. What is the expected result? Expect that the full-screen window's tab-strip re-appears when the mouse gets close to it, making it possible to dock the tab to it. What happens instead? The full-screen window's tab-strip does not auto-show. It is necessary to un-full-screen the target window to drag a tab to it. Possibly related to issue 675032 , which also regressed in this build?
,
Jan 9 2017
I can repro on 56. wez@ when did you see this work last? 55?
,
Jan 9 2017
Not sure, but I think early M56 dev-channel pushes worked as expected.
,
Jan 12 2017
bisect shows the broken cl is: https://codereview.chromium.org/2326703002
,
Jan 17 2017
Based on #4, this was likely broken in M-55. Looking at what's involved in https://chromiumcodereview.appspot.com/2640433004/ and given how close we are to M-56 stable, I would suggest not merging to 56 and instead re-targeting for 57. +tbuckley, abodenha for their thoughts.
,
Jan 18 2017
I agree with #5. If this is really a RBS, we probably can merge a cl that disables the MD in the cl in #4?
,
Jan 18 2017
At this point in M-56, disabling the CL in #4 would probably be even riskier, as we'd be reverting back to deprecated codepaths that have not seen any use in months. Let's re-target this to 57.
,
Feb 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4cc8622a6cca4971414a46acf812c7ea4e410eb commit a4cc8622a6cca4971414a46acf812c7ea4e410eb Author: warx <warx@chromium.org> Date: Thu Feb 02 00:36:15 2017 ChromeOS MD: Fix cannot drag tab onto immersive fullscreen window changes: This CL is a follow-up fix for https://codereview.chromium.org/2326703002/ MD change. The new MD design completely hides tabstrip without light bar anymore. In this case, we could consider tabstrip as visible. BUG= 676698 TEST=emulator test saw bug fixed. Review-Url: https://codereview.chromium.org/2640433004 Cr-Commit-Position: refs/heads/master@{#447658} [modify] https://crrev.com/a4cc8622a6cca4971414a46acf812c7ea4e410eb/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/a4cc8622a6cca4971414a46acf812c7ea4e410eb/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/a4cc8622a6cca4971414a46acf812c7ea4e410eb/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc [modify] https://crrev.com/a4cc8622a6cca4971414a46acf812c7ea4e410eb/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
,
Feb 2 2017
request a merge to M-57
,
Feb 2 2017
Approving merge to M57 Chrome OS.
,
Feb 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6aaac605eaec9919ecdd8d55bdb5236d546a7d6 commit b6aaac605eaec9919ecdd8d55bdb5236d546a7d6 Author: Qiang Xu <warx@chromium.org> Date: Thu Feb 02 04:04:30 2017 [Merge to M57] ChromeOS MD: Fix cannot drag tab onto immersive fullscreen window changes: This CL is a follow-up fix for https://codereview.chromium.org/2326703002/ MD change. The new MD design completely hides tabstrip without light bar anymore. In this case, we could consider tabstrip as visible. TBR=sky@chromium.org, tdanderson@chromium.org, yiyix@chromium.org BUG= 676698 TEST=emulator test saw bug fixed. Review-Url: https://codereview.chromium.org/2640433004 Cr-Commit-Position: refs/heads/master@{#447658} (cherry picked from commit a4cc8622a6cca4971414a46acf812c7ea4e410eb) Review-Url: https://codereview.chromium.org/2668413004 . Cr-Commit-Position: refs/branch-heads/2987@{#263} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/b6aaac605eaec9919ecdd8d55bdb5236d546a7d6/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/b6aaac605eaec9919ecdd8d55bdb5236d546a7d6/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/b6aaac605eaec9919ecdd8d55bdb5236d546a7d6/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc [modify] https://crrev.com/b6aaac605eaec9919ecdd8d55bdb5236d546a7d6/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
,
Feb 2 2017
,
Feb 21 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by w...@chromium.org
, Jan 3 2017