New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 676689 link

Starred by 2 users
Status: Fixed
Owner:
geoffl...@chromium.org
Closed: Dec 2016
Cc:
█ kbr@chromium.org
cwallez@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

TimerQueriesTest.TimeElapsed_ES2_OPENGL failure on GPU FYI

Project Member Reported by vmp...@chromium.org, Dec 22 2016 
It seems that

TimerQueriesTest.TimeElapsed_ES2_OPENGL started flaking on the GPU FYI, here's the first instance I could find on Win7 Debug AMD:

https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28AMD%29/builds/577

This is a part of the angle_end2end_tests. There is an angle roll in the range, but the revert of that roll is in the same range so it's likely that an earlier roll caused this.

jmadill@, do you mind taking a look/triaging?

Comment 1 by jmad...@chromium.org, Dec 22 2016

Owner: geoffl...@chromium.org
I don't think this test has ever been non-flaky. We should disable it or make it more robust. Assigning to current ANGLE wrangler geofflang. Geoff can you disable this test?

vmpstr, for your info, the FYI bots build with top of tree ANGLE, so rolls showing up in the blamelist are a red herring. You'll need to look at parent_got_angle_revision to find the ANGLE blamelist.

Comment 2 by vmp...@chromium.org, Dec 22 2016 

Oh, thanks for the info!
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/1da9193f3c86ff6c3f7edcdf5fdaddeb7d310459

commit 1da9193f3c86ff6c3f7edcdf5fdaddeb7d310459
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Dec 22 20:14:59 2016

Disable the flaky expectation in TimerQueriesTest.TimeElapsed.

BUG= 676689 

Change-Id: I5cf6fe7573d69a52b1c33f70a78f081ee833d1b5
Reviewed-on: https://chromium-review.googlesource.com/423388
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/1da9193f3c86ff6c3f7edcdf5fdaddeb7d310459/src/tests/gl_tests/TimerQueriesTest.cpp

Comment 4 by geoffl...@chromium.org, Dec 22 2016

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8438beb74dd3443e928c2e53082dbde81ca1900

commit f8438beb74dd3443e928c2e53082dbde81ca1900
Author: jmadill <jmadill@chromium.org>
Date: Fri Dec 23 16:29:06 2016

Roll ANGLE b8a580a..d5fe352

https://chromium.googlesource.com/angle/angle.git/+log/b8a580a..d5fe352

BUG= 676333 , 676689 , 672719 , 668223 , 630498 

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2606473002
Cr-Commit-Position: refs/heads/master@{#440636}

[modify] https://crrev.com/f8438beb74dd3443e928c2e53082dbde81ca1900/DEPS
►

Sign in to add a comment