New issue
Advanced search Search tips

Issue 676687 link

Starred by 2 users
Status: Fixed
Owner:
braveyao@chromium.org
Closed: Jan 2017
Cc:
guidou@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Bug



Sign in to add a comment

TabCapture can't get the cursor position accurate on Linux and Win

Project Member Reported by braveyao@chromium.org, Dec 22 2016 
What steps will reproduce the problem?
(1) Start a tabCapture on Linux or Win.
(2) reduce the window of the tab to show the problem better
(3) check the cursor position in the capture

What is the expected result?
captured cursor is at the same position as in the tab.

What happens instead?
It's offset several pixels.

Please use labels and text to provide additional information.
The problem only exist in Aura platforms. Mac works fine.

Comment 1 by braveyao@chromium.org, Dec 22 2016 

The problem is cursors_aura.cc failed to provide accurate hot spot of the cursor.
On Linux, it returns the hotspot of a 2x cursor, which is due to the scale factor of the cursor is not always correctly set.
On Win, it doesn't provide any hotspot info at all.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f1d5f56541d4200134418bff40902734d4fe7ce

commit 2f1d5f56541d4200134418bff40902734d4fe7ce
Author: braveyao <braveyao@chromium.org>
Date: Fri Jan 06 01:28:51 2017

Fix Aura can't provide accurate cursor hotspot info.

On Linux,  device scale factor is not set.
On Win, there is no API to offer hotspot of a cursor.
This cl addresses the above two problems.

BUG= 676687 

Review-Url: https://codereview.chromium.org/2605773002
Cr-Commit-Position: refs/heads/master@{#441790}

[modify] https://crrev.com/2f1d5f56541d4200134418bff40902734d4fe7ce/ui/base/cursor/cursor_loader_x11.cc
[modify] https://crrev.com/2f1d5f56541d4200134418bff40902734d4fe7ce/ui/base/cursor/cursors_aura.cc
[modify] https://crrev.com/2f1d5f56541d4200134418bff40902734d4fe7ce/ui/gfx/icon_util.cc
[modify] https://crrev.com/2f1d5f56541d4200134418bff40902734d4fe7ce/ui/gfx/icon_util.h

Comment 3 by braveyao@chromium.org, Jan 6 2017

Status: Fixed (was: Assigned)

Comment 4 by anatolid@chromium.org, Jan 12 2017

Labels: M-57
►

Sign in to add a comment