PaintScrollbarCorner gets called for overlay scrollbars |
|||
Issue descriptionChrome Version: 57.0.2958.0 OS: Linux What steps will reproduce the problem? (1)Enable overlay scrollbars (2)Go to https://productforums.google.com/forum/#!forum/chrome What is the expected result? PaintScrollbarCorner shouldn't get called for overlay scrollbars. What happens instead? The function is called and the DCHECK(!use_overlay_scrollbars_) fails.
,
Mar 10 2017
,
Mar 10 2017
This failed DCHECK is because this is custom scrollbar with corner and we use |Platform::current()->themeEngine()| in |ScrollbarTheme::paintScrollCorner|. This is an example (http://ht.chaopeng.me/custom-scrollbar-2.html) for this issue. Open it and resize window to small(600*400). Could we just remove the DCHECK or we need to add a new code path for custom scrollbar?
,
Mar 10 2017
Why are we using ScrollbarTheme::paintScrollCorner if the scrollbars are custom? Shouldn't we be using LayoutScrollbarTheme instead?
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe8765486d0c6b4e2e470bf284697fcb9aae5ea4 commit fe8765486d0c6b4e2e470bf284697fcb9aae5ea4 Author: chaopeng <chaopeng@chromium.org> Date: Tue Mar 14 02:04:26 2017 Use correct ScrollbarTheme to paintScrollCorner This issue is caused by we did not know ScrollbarTheme in FramePainter::paintScrollCorner then use ScrollbarTheme::theme to paint. In this patch, we get ScrollbarTheme from the related scrollbar and use it to paintScrollCorner. BUG= 676678 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2741223002 Cr-Commit-Position: refs/heads/master@{#456569} [modify] https://crrev.com/fe8765486d0c6b4e2e470bf284697fcb9aae5ea4/third_party/WebKit/Source/core/paint/FramePainter.cpp [modify] https://crrev.com/fe8765486d0c6b4e2e470bf284697fcb9aae5ea4/third_party/WebKit/Source/web/tests/WebFrameTest.cpp [add] https://crrev.com/fe8765486d0c6b4e2e470bf284697fcb9aae5ea4/third_party/WebKit/Source/web/tests/data/custom-scrollbar-dcheck-failed-when-paint-scroll-corner.html
,
Mar 14 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bokan@chromium.org
, Dec 22 2016Labels: Hotlist-Input-Dev OS-Chrome OS-Linux
Status: Available (was: Untriaged)