Add effective connection type change events to the net log. This will make it easier to debug bugs related to triggering of interventions in Chrome and in Cronet.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66edd71ca9b4e2691ab0d0926b7b77945c92556f commit 66edd71ca9b4e2691ab0d0926b7b77945c92556f Author: tbansal <tbansal@chromium.org> Date: Mon Jan 09 20:44:04 2017 Use net::TestNetworkQualityEstimator in resource loader unittests Use net::TestNetworkQualityEstimator in tests instead of creating multiple overriding classes. Also, add a new easy to use constructor for TestNetworkQualityEstimator. BUG= 676661 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2596983003 Cr-Commit-Position: refs/heads/master@{#442333} [modify] https://crrev.com/66edd71ca9b4e2691ab0d0926b7b77945c92556f/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc [modify] https://crrev.com/66edd71ca9b4e2691ab0d0926b7b77945c92556f/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc [modify] https://crrev.com/66edd71ca9b4e2691ab0d0926b7b77945c92556f/content/browser/loader/resource_loader_unittest.cc [modify] https://crrev.com/66edd71ca9b4e2691ab0d0926b7b77945c92556f/net/nqe/network_qualities_prefs_manager_unittest.cc [modify] https://crrev.com/66edd71ca9b4e2691ab0d0926b7b77945c92556f/net/nqe/network_quality_estimator_test_util.cc [modify] https://crrev.com/66edd71ca9b4e2691ab0d0926b7b77945c92556f/net/nqe/network_quality_estimator_test_util.h [modify] https://crrev.com/66edd71ca9b4e2691ab0d0926b7b77945c92556f/net/nqe/network_quality_estimator_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97e38a2f826fed6afd6422f44ca291d553adda8c commit 97e38a2f826fed6afd6422f44ca291d553adda8c Author: tbansal <tbansal@chromium.org> Date: Fri Jan 20 20:43:02 2017 Add network quality change events to net log If Network Quality Estimator (NQE) determines that network quality has changed, an event is added to the net log. The event includes the effective connection type, http rtt, transport rtt, and throughput. The net log source is set to NETWORK_QUALITY_ESTIMATOR. This is how the net log looks like: t=295473 [st=295473] NETWORK_QUALITY_CHANGED --> downstream_throughput_kbps = 29 --> effective_connection_type = "Slow2G" --> http_rtt_ms = 4691 --> transport_rtt_ms = 1822 BUG= 676661 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2593243003 Cr-Commit-Position: refs/heads/master@{#445153} [modify] https://crrev.com/97e38a2f826fed6afd6422f44ca291d553adda8c/chrome/browser/android/net/external_estimate_provider_android_unittest.cc [modify] https://crrev.com/97e38a2f826fed6afd6422f44ca291d553adda8c/chrome/browser/io_thread.cc [modify] https://crrev.com/97e38a2f826fed6afd6422f44ca291d553adda8c/components/cronet/android/cronet_url_request_context_adapter.cc [modify] https://crrev.com/97e38a2f826fed6afd6422f44ca291d553adda8c/ios/chrome/browser/ios_chrome_io_thread.mm [modify] https://crrev.com/97e38a2f826fed6afd6422f44ca291d553adda8c/net/log/net_log_event_type_list.h [modify] https://crrev.com/97e38a2f826fed6afd6422f44ca291d553adda8c/net/log/net_log_source_type_list.h [modify] https://crrev.com/97e38a2f826fed6afd6422f44ca291d553adda8c/net/net.gypi [add] https://crrev.com/97e38a2f826fed6afd6422f44ca291d553adda8c/net/nqe/event_creator.cc [add] https://crrev.com/97e38a2f826fed6afd6422f44ca291d553adda8c/net/nqe/event_creator.h [modify] https://crrev.com/97e38a2f826fed6afd6422f44ca291d553adda8c/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/97e38a2f826fed6afd6422f44ca291d553adda8c/net/nqe/network_quality_estimator.h [modify] https://crrev.com/97e38a2f826fed6afd6422f44ca291d553adda8c/net/nqe/network_quality_estimator_test_util.cc [modify] https://crrev.com/97e38a2f826fed6afd6422f44ca291d553adda8c/net/nqe/network_quality_estimator_test_util.h [modify] https://crrev.com/97e38a2f826fed6afd6422f44ca291d553adda8c/net/nqe/network_quality_estimator_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/781262f98757b3e657a9089de7f98b9752482d09 commit 781262f98757b3e657a9089de7f98b9752482d09 Author: tbansal <tbansal@chromium.org> Date: Thu Jan 26 14:21:21 2017 NQE: Add net log events when there is a significant change in metrics Add net log events for Network Quality Estimator (NQE) when there is a significant change in network quality metrics (e.g., RTT, bandwidth). Currently, the net log event is added only when there is a change in the effective connection type. This CL modifies the logic to add a net log event when there is a significant change in other metrics. Also, this CL refactors the code to make EventCreator a non-static class. BUG= 676661 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2643213003 Cr-Commit-Position: refs/heads/master@{#446319} [modify] https://crrev.com/781262f98757b3e657a9089de7f98b9752482d09/net/nqe/event_creator.cc [modify] https://crrev.com/781262f98757b3e657a9089de7f98b9752482d09/net/nqe/event_creator.h [modify] https://crrev.com/781262f98757b3e657a9089de7f98b9752482d09/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/781262f98757b3e657a9089de7f98b9752482d09/net/nqe/network_quality_estimator.h [modify] https://crrev.com/781262f98757b3e657a9089de7f98b9752482d09/net/nqe/network_quality_estimator_test_util.cc [modify] https://crrev.com/781262f98757b3e657a9089de7f98b9752482d09/net/nqe/network_quality_estimator_test_util.h [modify] https://crrev.com/781262f98757b3e657a9089de7f98b9752482d09/net/nqe/network_quality_estimator_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Jan 9 2017