New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676645 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: 59-Stable
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----



Sign in to add a comment

stylesheets should maintain their own referrer policy

Project Member Reported by jochen@chromium.org, Dec 22 2016

Issue description

and they should be able to get the referrer policy from the network header
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f43f2eacab108429daea2bf64678922fc85491e

commit 4f43f2eacab108429daea2bf64678922fc85491e
Author: jochen <jochen@chromium.org>
Date: Sun Feb 05 05:02:52 2017

Move parsing of referrer policy header values to SecurityPolicy

Also unify the code paths for legacy and non-legacy policies a bit

R=estark@chromium.org
BUG= 676645 

Review-Url: https://codereview.chromium.org/2674973006
Cr-Commit-Position: refs/heads/master@{#448176}

[modify] https://crrev.com/4f43f2eacab108429daea2bf64678922fc85491e/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/4f43f2eacab108429daea2bf64678922fc85491e/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
[modify] https://crrev.com/4f43f2eacab108429daea2bf64678922fc85491e/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
[modify] https://crrev.com/4f43f2eacab108429daea2bf64678922fc85491e/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
[modify] https://crrev.com/4f43f2eacab108429daea2bf64678922fc85491e/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
[modify] https://crrev.com/4f43f2eacab108429daea2bf64678922fc85491e/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
[modify] https://crrev.com/4f43f2eacab108429daea2bf64678922fc85491e/third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp
[modify] https://crrev.com/4f43f2eacab108429daea2bf64678922fc85491e/third_party/WebKit/Source/platform/weborigin/SecurityPolicy.h

Labels: -Type-Bug OWP-Type-ChangeBehavior Type-Launch-OWP
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d687e467ebbde1d0c7862c29a375263167b04306

commit d687e467ebbde1d0c7862c29a375263167b04306
Author: jochen <jochen@chromium.org>
Date: Tue Mar 28 12:40:42 2017

Change CSSParserContext to either take explicit or implicit referrer

Either we pass in an base URL, then also pass in a referrer policy, or
we pass in a document, the take both from the document.

BUG= 676645 
R=estark@chromium.org

Review-Url: https://codereview.chromium.org/2776163002
Cr-Commit-Position: refs/heads/master@{#460068}

[modify] https://crrev.com/d687e467ebbde1d0c7862c29a375263167b04306/third_party/WebKit/Source/core/css/CSSStyleSheet.cpp
[modify] https://crrev.com/d687e467ebbde1d0c7862c29a375263167b04306/third_party/WebKit/Source/core/css/FontFace.cpp
[modify] https://crrev.com/d687e467ebbde1d0c7862c29a375263167b04306/third_party/WebKit/Source/core/css/StyleRuleImport.cpp
[modify] https://crrev.com/d687e467ebbde1d0c7862c29a375263167b04306/third_party/WebKit/Source/core/css/parser/CSSParserContext.cpp
[modify] https://crrev.com/d687e467ebbde1d0c7862c29a375263167b04306/third_party/WebKit/Source/core/css/parser/CSSParserContext.h
[modify] https://crrev.com/d687e467ebbde1d0c7862c29a375263167b04306/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
[modify] https://crrev.com/d687e467ebbde1d0c7862c29a375263167b04306/third_party/WebKit/Source/core/dom/SelectorQuery.cpp
[modify] https://crrev.com/d687e467ebbde1d0c7862c29a375263167b04306/third_party/WebKit/Source/core/dom/SelectorQueryTest.cpp
[modify] https://crrev.com/d687e467ebbde1d0c7862c29a375263167b04306/third_party/WebKit/Source/core/html/LinkStyle.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57c4423dceffc997459ae34640abdfc1f067cc2e

commit 57c4423dceffc997459ae34640abdfc1f067cc2e
Author: jochen <jochen@chromium.org>
Date: Wed Mar 29 10:46:28 2017

Use Referrer-Policy headers for CSS stylesheets

Link to intent to ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/YkXg6ZkW2Bs/6aDLAs0qBwAJ

BUG= 676645 
R=estark@chromium.org

Review-Url: https://codereview.chromium.org/2780533002
Cr-Commit-Position: refs/heads/master@{#460344}

[add] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/css-integration/README.md
[add] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/css-integration/external-import-stylesheet.html
[add] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/css-integration/external-stylesheet.html
[add] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/css-integration/inline-style.html
[add] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/css-integration/internal-import-stylesheet.html
[add] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/css-integration/internal-stylesheet.html
[add] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/css-integration/presentation-attribute.html
[add] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/css-integration/processing-instruction.html
[modify] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/generic/subresource/image.py
[add] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/generic/subresource/stylesheet.py
[modify] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/generic/subresource/subresource.py
[add] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/LayoutTests/external/wpt/referrer-policy/generic/template/stylesheet.css.template
[modify] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/Source/core/css/StyleRuleImport.cpp
[modify] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/Source/core/css/StyleRuleImport.h
[modify] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
[modify] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/Source/core/dom/ProcessingInstruction.h
[modify] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/Source/core/html/LinkStyle.cpp
[modify] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/Source/core/html/LinkStyle.h
[modify] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp
[modify] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.h
[modify] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/Source/core/html/parser/CSSPreloadScannerTest.cpp
[modify] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp
[modify] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/Source/core/html/parser/PreloadRequest.h
[modify] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
[modify] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.cpp
[modify] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/Source/core/loader/resource/LinkPreloadResourceClients.h
[modify] https://crrev.com/57c4423dceffc997459ae34640abdfc1f067cc2e/third_party/WebKit/Source/core/loader/resource/StyleSheetResourceClient.h

Comment 7 by jochen@chromium.org, Mar 29 2017

Labels: Launch-M-Target-59-Stable OS-All
Status: Fixed (was: Assigned)

Comment 8 by jochen@chromium.org, Mar 29 2017

Labels: M-59

Sign in to add a comment