New issue
Advanced search Search tips

Issue 676620 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
V1



Sign in to add a comment

authpolicy: Combine net_ads seccomp filters and test different multiple boards

Project Member Reported by ljusten@chromium.org, Dec 22 2016

Issue description

Different boards will require different seccomp filters, e.g. x86 vs amd64 vs arm vs arm64. Be sure to test on all these boards.
 
Owner: ljusten@chromium.org
BTW, if you just log chromad task items and leave them unassigned, they fall on the triager's plate, and we don't know what to do with them.
Status: Assigned (was: Available)
Labels: M-57
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8ff2060074e952daee634cc05c1f2acb6642fa58

commit 8ff2060074e952daee634cc05c1f2acb6642fa58
Author: Lutz Justen <ljusten@chromium.org>
Date: Mon Jan 02 14:04:41 2017

authpolicy: Combine 4 net ads seccomp filters into one

The 4 net ads seccomp filters are very similar and it would be troublesome
to maintain them when filters for all architecture permutations (arm/x86/
32bit/64bit) are added. Hence, the filters are combined into one superset.

BUG= chromium:676620 
TEST=Compiles, tested with custom test code

Change-Id: Id761efd3f8e97cf8bc31e058e9290405fc2ee7a8
Reviewed-on: https://chromium-review.googlesource.com/423057
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[delete] https://crrev.com/38770411485aa61750a9eaa8ced44880bbe9adad/authpolicy/seccomp_filters/net_ads_info-seccomp.policy
[delete] https://crrev.com/38770411485aa61750a9eaa8ced44880bbe9adad/authpolicy/seccomp_filters/net_ads_gpo_list-seccomp.policy
[rename] https://crrev.com/8ff2060074e952daee634cc05c1f2acb6642fa58/authpolicy/seccomp_filters/net_ads-seccomp.policy
[modify] https://crrev.com/8ff2060074e952daee634cc05c1f2acb6642fa58/authpolicy/samba_interface.cc
[delete] https://crrev.com/38770411485aa61750a9eaa8ced44880bbe9adad/authpolicy/seccomp_filters/net_ads_search-seccomp.policy

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/203d22014e786ff8b5f3ed68c9e83c5a82b5368f

commit 203d22014e786ff8b5f3ed68c9e83c5a82b5368f
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu Jan 05 14:32:04 2017

authpolicy: Adjust seccomp filters for samus

smbclient didn't run on Samus because a syscall was blocked.

BUG= chromium:676620 
TEST=Works on a samus pixel chromebook

Change-Id: I3ff8a8b99a0f938e2f996331bae8646869db0e1f
Reviewed-on: https://chromium-review.googlesource.com/422208
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/203d22014e786ff8b5f3ed68c9e83c5a82b5368f/authpolicy/seccomp_filters/net_ads-seccomp.policy
[modify] https://crrev.com/203d22014e786ff8b5f3ed68c9e83c5a82b5368f/authpolicy/seccomp_filters/smbclient-seccomp.policy

Labels: Enterprise-Triaged
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f2c5b83887381682d5c3cdc5dba60f9183fd66c2

commit f2c5b83887381682d5c3cdc5dba60f9183fd66c2
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Mon Jan 16 17:13:08 2017

authpolicy: Add more syscalls to seccomp filters

Adding rt_sigsuspend which I've seen being used on auron_paine.

BUG= chromium:676620 
TEST=manual

Change-Id: I1751579c8c689ab772e4705fda945cd9a0fdc8a5
Reviewed-on: https://chromium-review.googlesource.com/427802
Commit-Ready: Thiemo Nagel <tnagel@chromium.org>
Tested-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/f2c5b83887381682d5c3cdc5dba60f9183fd66c2/authpolicy/seccomp_filters/net_ads-seccomp.policy
[modify] https://crrev.com/f2c5b83887381682d5c3cdc5dba60f9183fd66c2/authpolicy/seccomp_filters/smbclient-seccomp.policy

Labels: -Pri-3 Pri-2
Status: Fixed (was: Started)
Closing this since seccomp filters have been combined.  Filed  issue 687177  for investigating seccomp test coverage.
Status: Verified (was: Fixed)
bulk Verify of Chromad V1 bugs

Sign in to add a comment