MacViews IME Regression: On pressing Left/Right arrow keys, whole composition text is confirmed. |
|||||
Issue descriptionChrome Version: 57.0.2959.0 OS:Mac What steps will reproduce the problem? (1) Enable MacViews using --secondary-ui-md flag. (2) Open Bookmark Bubble. (3) Switch input source to Katanaka. (4) Type some long text. (5) Press down arrow key to see candidate dropdown. (6) Press right arrow. What is the expected result? Dropdown for next target clause should open. What happens instead? All the composition text is confirmed. Another repro case. 1) Press a for some seconds so that candidate window opens. 2) Press right arrow key. 3) Instead of switching amongst the candidate options, the current option is selected and confirmed.
,
Dec 22 2016
,
Dec 22 2016
,
Dec 22 2016
,
Dec 22 2016
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85d9c68076c03f77b7c61a9c2e2056862bb9d189 commit 85d9c68076c03f77b7c61a9c2e2056862bb9d189 Author: karandeepb <karandeepb@chromium.org> Date: Thu Dec 22 20:08:15 2016 MacViews: Mark key down event as handled when consumed by the IME. r434436 changed how key events are handled on MacViews. It overrode _wantsKeyDownForEvent: to receive more key events from Cocoa and passed all unhandled key down events to the underlying views::Widget. However, key down events captured by the IME in the following NSTextInputClient methods were not marked as handled: - setMarkedText:selectedRange:replacementRange: - unmarkText: As a result, these key down events were erronously passed to the underlying views::Widget resulting in a regression in the IME behavior. This CL fixes the regression by marking the key down event as handled in the above mentioned methods. BUG= 676615 Review-Url: https://codereview.chromium.org/2601513002 Cr-Commit-Position: refs/heads/master@{#440483} [modify] https://crrev.com/85d9c68076c03f77b7c61a9c2e2056862bb9d189/ui/views/cocoa/bridged_content_view.mm
,
Dec 22 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by karandeepb@chromium.org
, Dec 22 2016