New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 676597 link

Starred by 2 users
Status: Archived
Owner: ----
Closed: Apr 2017
Cc:
qyears...@chromium.org
█ wkorman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

The archive_webkit_tests_results step uploaded results to an unexpected directory.

Project Member Reported by drott@chromium.org, Dec 22 2016 
Triggering rebaseline-cl on https://codereview.chromium.org/2600453003 started all the required bots, and had layout test failures on mac10_11_retina_blink_rel but then the tool was unable to retrieve results from the Retina bot.

This seems quite understandable as manually clicking on the build runs layout_test_results link leads to "The specified key does not exist"
https://storage.googleapis.com/chromium-layout-test-archives/mac10_11_retina_blink_rel/1477/layout-test-results/results.html

In any event, I can't complete the webkit-patch rebaseline-cl run on this CL. 

Suggestions for how to follow up or fixes are welcome, thanks for working on this qyearsley@ and wkorman@.

Comment 1 by qyears...@chromium.org, Dec 28 2016

Cc: qyears...@chromium.org
Components: -Tools Blink>Infra
Owner: ----
Status: Available (was: Untriaged)
Summary: The archive_webkit_tests_results step uploaded results to an unexpected directory. (was: Unable to retrieve rebaseline-cl results from mac10_11_retina_blink_rel)
Now it looks like in that CL a second job was started with mac10_11_retina_blink_rel and it did have results (https://storage.googleapis.com/chromium-layout-test-archives/mac10_11_retina_blink_rel/1478/layout-test-results/results.html).

There was some kind of problem where the results were uploaded to 

gs://chromium-layout-test-archives/mac10_11_retina_blink_rel/1477/ instead of
gs://chromium-layout-test-archives/mac10_11_retina_blink_rel/1477/layout-test-results/.

(The results.html file was put in: https://storage.googleapis.com/chromium-layout-test-archives/mac10_11_retina_blink_rel/1477/results.html)

Comparing the archive_layout_test_results stdio for these two test runs, I can't see any obvious differences:

https://build.chromium.org/p/tryserver.blink/builders/mac10.11_retina_blink_rel/builds/1477/steps/archive_webkit_tests_results/logs/stdio
https://build.chromium.org/p/tryserver.blink/builders/mac10.11_retina_blink_rel/builds/1478/steps/archive_webkit_tests_results/logs/stdio

When uploading the results folder which contains results.html, the first has:
.../gsutil.py -- -m -q -h "Cache-Control:public, max-age=31556926" cp -R /b/rr/tmpMVeiZH/w/layout-test-results gs://chromium-layout-test-archives/mac10_11_retina_blink_rel/1477
and the second has:
.../gsutil.py -- -m -q -h "Cache-Control:public, max-age=31556926" cp -R /b/rr/tmpeEDVbT/w/layout-test-results gs://chromium-layout-test-archives/mac10_11_retina_blink_rel/1478

In the former job (1477), the results are all directly put in .../1477/, whereas in the latter, they're put in .../1478/layout-test-results. However, in the former, a layout-test-results directory is also created, as can be seen by https://storage.googleapis.com/chromium-layout-test-archives/mac10_11_retina_blink_rel/1477/layout-test-results/LAST_CHANGE.


I'm pretty sure I've seen this happen elsewhere somewhere. Some guesses at why it might happen:
 - Maybe the behavior of gsutil can change?
 - Maybe sometimes the process of zipping can sometimes change the contents of layout-test-results?

Possible follow-up: Maybe we could add debug logging to list out the contents of the "results dir" before uploading?

Comment 2 by stip@chromium.org, Feb 10 2017

Cc: -stip@chromium.org

Comment 3 by qyears...@chromium.org, Apr 7 2017

Status: Archived (was: Available)
Haven't seen this in the past few months, might be resolved, will re-open if I see it again.
►

Sign in to add a comment