Flaky layout test: virtual/mojo-localstorage/imported/wpt/webstorage/storage_local_setitem_quotaexceedederr.html |
||||
Issue descriptionvirtual/mojo-localstorage/imported/wpt/webstorage/storage_local_setitem_quotaexceedederr.html is TIMEOUT on chromium.webkit/WebKit Linux Trusty (dbg) Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fmojo-localstorage%2Fimported%2Fwpt%2Fwebstorage%2Fstorage_local_setitem_quotaexceedederr.html&testType=webkit_tests Build bot log: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/324
,
Jan 3 2017
,
Jan 4 2017
Ah, yes. I had noticed this but tried to pretend the problem didn't exist. Looking into this more the problem is caused by not having implemented any kind of throttling for the mojo messages that are send from the renderer to the browser. In the IPC implementation we flush all pending async messages when we detect too many in flight (by sending a sync IPC), but doing the same in the mojo world doesn't quite work currently (sync mojo currently never delivers async message replies without spinning the event loop, while sync IPC would deliver all async replies it received while waiting for a sync reply). I've tried some stuff in https://codereview.chromium.org/2611843004 but haven't figured out a satisfactory solution yet.
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/856592d9bae5db8f6550e85e11f71405255e2993 commit 856592d9bae5db8f6550e85e11f71405255e2993 Author: Marijn Kruisselbrink <mek@chromium.org> Date: Wed Jun 07 21:18:45 2017 Update test expectations for wpt localstorage quota test. Because of slowness in mojo in debug mode this test is expected to be slow on debug builds. Not much we can do about it, so mark it as slow. Bug: 676572 Change-Id: I0bd8c65b8fad4d45c46f38420c9010dc160c2062 Reviewed-on: https://chromium-review.googlesource.com/527260 Reviewed-by: Michael Nordman <michaeln@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#477761} [modify] https://crrev.com/856592d9bae5db8f6550e85e11f71405255e2993/third_party/WebKit/LayoutTests/SlowTests [modify] https://crrev.com/856592d9bae5db8f6550e85e11f71405255e2993/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 7 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Dec 22 2016