New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 676568 link

Starred by 2 users
Status: Verified
Owner:
azurewei@chromium.org
Closed: Feb 2017
Cc:
shuchen@chromium.org
█ xiangye@chromium.org
wuyingbing@chromium.org
zhan...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 676798



Sign in to add a comment

Emoji&HW should be disable in shelf when focus on pwd input-box

Project Member Reported by xiulingw@chromium.org, Dec 22 2016 
Version 57.0.2958.0 canary 
Platform 9109 link
Firmware Google_Link.2695.1.169

REPRO STEPS 
1.Enable #enable-emoji-handwriting-voice-on-ime-menu
2.Checked <Show input options in the shelf> 
3.Put cursor into any pwd input-box.
4.Open opt-in menu in shelf 


ACTUAL RESULTS 
Emoji&HW icons are still click-able

EXPECTED
Emoji&HW icons should be disable, just like them in the default (main) keyset.

Comment 1 by xiulingw@chromium.org, Dec 22 2016

Screenshot 2016-12-22 at 3.14.48 PM.png
194 KB View Download
Screenshot 2016-12-22 at 3.15.02 PM.png
266 KB View Download

Comment 2 by azurewei@chromium.org, Dec 22 2016 

Voice input should also be disabled for pwd input client.

Comment 3 by azurewei@chromium.org, Dec 25 2016

Blocking: 676798
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/045de38a389fa2f65d4e703c910d25438a8bde1f

commit 045de38a389fa2f65d4e703c910d25438a8bde1f
Author: azurewei <azurewei@chromium.org>
Date: Fri Jan 06 02:06:00 2017

Add MockInputMethodManager under ui/base/ime/chromeos/.
Thus we could use MockInputMethodManager from ash/common/system/chromeos/.
See https://codereview.chromium.org/2599743003/.

Rename MockInputMethodManager (under chrome/browser/chromeos/input_method/) as MockInputMethodManagerImpl
and make it extends MockInputMethodManager.

BUG= 676568 
TEST=None

Review-Url: https://codereview.chromium.org/2605843002
Cr-Commit-Position: refs/heads/master@{#441819}

[modify] https://crrev.com/045de38a389fa2f65d4e703c910d25438a8bde1f/chrome/browser/BUILD.gn
[modify] https://crrev.com/045de38a389fa2f65d4e703c910d25438a8bde1f/chrome/browser/chromeos/events/event_rewriter_unittest.cc
[modify] https://crrev.com/045de38a389fa2f65d4e703c910d25438a8bde1f/chrome/browser/chromeos/input_method/input_method_configuration_unittest.cc
[modify] https://crrev.com/045de38a389fa2f65d4e703c910d25438a8bde1f/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc
[modify] https://crrev.com/045de38a389fa2f65d4e703c910d25438a8bde1f/chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc
[delete] https://crrev.com/ae0ddfaace8dd20347b3898655f0209583ad8b96/chrome/browser/chromeos/input_method/mock_input_method_manager.cc
[add] https://crrev.com/045de38a389fa2f65d4e703c910d25438a8bde1f/chrome/browser/chromeos/input_method/mock_input_method_manager_impl.cc
[add] https://crrev.com/045de38a389fa2f65d4e703c910d25438a8bde1f/chrome/browser/chromeos/input_method/mock_input_method_manager_impl.h
[modify] https://crrev.com/045de38a389fa2f65d4e703c910d25438a8bde1f/chrome/browser/chromeos/preferences_unittest.cc
[modify] https://crrev.com/045de38a389fa2f65d4e703c910d25438a8bde1f/chrome/browser/ui/views/frame/test_with_browser_view.cc
[modify] https://crrev.com/045de38a389fa2f65d4e703c910d25438a8bde1f/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
[modify] https://crrev.com/045de38a389fa2f65d4e703c910d25438a8bde1f/chrome/browser/ui/webui/chromeos/login/l10n_util_test_util.h
[modify] https://crrev.com/045de38a389fa2f65d4e703c910d25438a8bde1f/ui/base/BUILD.gn
[add] https://crrev.com/045de38a389fa2f65d4e703c910d25438a8bde1f/ui/base/ime/chromeos/mock_input_method_manager.cc
[rename] https://crrev.com/045de38a389fa2f65d4e703c910d25438a8bde1f/ui/base/ime/chromeos/mock_input_method_manager.h
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c4c4e8afd6f1259d52e1ccb1aff046204421fdc

commit 1c4c4e8afd6f1259d52e1ccb1aff046204421fdc
Author: azurewei <azurewei@chromium.org>
Date: Tue Jan 10 04:47:18 2017

Disable emoji, handwriting and voice for password input client.

Make ImeMenuTray observes InputMethod to get the current input type. If
the current input client is password, do not show emoji, handwriting and
voice buttons.
We don't need to care about the input type changed after IME menu shown,
since it will hide the bubble view.

BUG= 676568 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2599743003
Cr-Commit-Position: refs/heads/master@{#442478}

[modify] https://crrev.com/1c4c4e8afd6f1259d52e1ccb1aff046204421fdc/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/1c4c4e8afd6f1259d52e1ccb1aff046204421fdc/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc

Comment 6 by azurewei@chromium.org, Jan 10 2017

Status: Fixed (was: Assigned)

Comment 7 by xiulingw@chromium.org, Jan 11 2017

Status: Assigned (was: Fixed)
Still repro on M57 9170 link.

Comment 8 by azurewei@chromium.org, Feb 14 2017 

Just verified with 9280 canary clapper, and failed to repro. Could give more specific steps (e.g. pwd input box in which page)? Thanks.

Comment 9 by azurewei@chromium.org, Feb 14 2017

Status: Fixed (was: Assigned)

Comment 10 by sdantul...@chromium.org, Feb 22 2017

Status: Verified (was: Fixed)
9304.0.0 / 58.0.3015.0

Verified using pwd input box on gmail.com and facebook.com login pages
►

Sign in to add a comment