New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 676566 link

Starred by 4 users
Status: Fixed
Owner:
bsep@chromium.org
Closed: Jan 2017
Cc:
bsep@chromium.org
nyerramilli@chromium.org
pbomm...@chromium.org
jmukthavaram@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Win 10] Regression:Incognito icon doesn't appear on top left side of browser.

Reported by vku...@etouch.net, Dec 22 2016 
Chrome Version :57.0.2957.0 (Official Build)Revision 97d232ea886d11bd5f7f5b3157637e1ae92ae980-refs/heads/master@{#439663} (32/64-bit)
OS:Windows (7,8,10)

What steps will reproduce the problem?
(1)Freshly launch chrome and click on wrench menu
(2)Click on new incognito window option and observe.

Actual: Incognito icon is not seen on top left side of browser.

Expected: Incognito icon should be seen on top left side of browser.

This is a regression issue broken in 'M57' and will soon update other info

Comment 1 by vku...@etouch.net, Dec 22 2016

Summary: [Win 10]Regression:Incognito icon doesn't appear on top left side of browser. (was: Regression:Incognito icon doesn't appear on top left side of browser.)
Manual regression range:
Good Build: 57.0.2953.0
Bad Build:  57.0.2955.0

Note: This is Windows 10 specific issue not seen on other OS like Win 7,8,Linux(Ubuntu 14.04 LTS)and Mac (10.11.6, 10.12.1)
Actual_incognito.mp4
173 KB View Download
Expected_incognito.mp4
213 KB View Download

Comment 2 by vku...@etouch.net, Dec 22 2016

Cc: pbomm...@chromium.org
Labels: Proj-Windows10 hasbisect
Owner: bsep@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/c360dbf9da64cbf1c6b2d63e87aab8eda61dd424..7b033bfa43bdf3bcdbeb6a9d9742dcf26346830b?pretty=fuller&n=10

Suspecting: 439030 ?

Comment 3 by ranjitkan@chromium.org, Dec 22 2016

Labels: ReleaseBlock-Dev
Summary: [Win 10] Regression:Incognito icon doesn't appear on top left side of browser. (was: [Win 10]Regression:Incognito icon doesn't appear on top left side of browser.)
Adding release block label, please undo if not the case.

Comment 4 by bsep@chromium.org, Dec 22 2016 

This only reproduces if you have "Show color on Start, taskbar, action center, and title bar" turned off.

Very odd. I guess it's plausible my patch caused this, but it seems unlikely... I'll take a look.

Comment 5 by bsep@chromium.org, Dec 22 2016 

It was me after all. I made a patch to fix this here: https://codereview.chromium.org/2605443002 but everyone is on vacation right now. I'll land this in january.

Comment 6 by manoranj...@chromium.org, Dec 28 2016

Labels: -ReleaseBlock-Dev ReleaseBlock-Stable
Lowering the priority as per c#4.

Comment 7 by bsep@chromium.org, Jan 3 2017

Cc: jmukthavaram@chromium.org bsep@chromium.org
 Issue 677693  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b052bbc63d486e85df9da4b073c5decd16972a4d

commit b052bbc63d486e85df9da4b073c5decd16972a4d
Author: bsep <bsep@chromium.org>
Date: Tue Jan 03 23:36:46 2017

Ensure UI elements contrast with the right frame color.

With a Windows-drawn titlebar we need to make sure we're reporting the
frame color that Windows uses so that elements like the incognito icon
will contrast correctly. This patch changes theme_service_win to not
assume custom titlebar mode is on when calculating colors.

R=estade@chromium.org
BUG= 676566 

Review-Url: https://codereview.chromium.org/2605443002
Cr-Commit-Position: refs/heads/master@{#441254}

[modify] https://crrev.com/b052bbc63d486e85df9da4b073c5decd16972a4d/chrome/browser/themes/theme_service_win.cc
[modify] https://crrev.com/b052bbc63d486e85df9da4b073c5decd16972a4d/chrome/browser/themes/theme_service_win.h

Comment 9 by bsep@chromium.org, Jan 3 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment