New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676561 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Layout Test images/paletted-png-with-color-profile.html is flaky

Project Member Reported by shimazu@chromium.org, Dec 22 2016

Issue description

Owner: schenney@chromium.org
Status: Assigned (was: Available)
Link to flakiness dashboard
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=images%2Fpaletted-png-with-color-profile.html&testType=webkit_tests

I've created a CL to skip this test temporally (https://codereview.chromium.org/2596163002) and let me pass this issue to who has recently modified on the layout tests in images/.

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f3b8fe15bdeef7ba4f3860042cbf99b25ea7812

commit 6f3b8fe15bdeef7ba4f3860042cbf99b25ea7812
Author: shimazu <shimazu@chromium.org>
Date: Thu Dec 22 07:36:48 2016

Mark images/paletted-png-with-color-profile.html as skip on android

BUG= 676561 
TBR=schenney@chromium.org

Review-Url: https://codereview.chromium.org/2596163002
Cr-Commit-Position: refs/heads/master@{#440353}

[modify] https://crrev.com/6f3b8fe15bdeef7ba4f3860042cbf99b25ea7812/third_party/WebKit/LayoutTests/TestExpectations

Components: -Blink>Paint Blink>Image

Comment 4 by noel@chromium.org, Dec 26 2016

Cc: msarett@chromium.org noel@chromium.org
Seems images/paletted-png-with-color-profile.html has no expected results on Android Nexus 4, looking at

Layout test result:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Android__Nexus4_/58513/layout-test-results/results.html
Components: -Blink>LayoutTests

Comment 6 by noel@chromium.org, Feb 23 2017

First issue: there is no expected image.  schenney@ how about we try a rebaseline?

Second issue, the actual image looks to have its R and B channels swapped.  The
test started failing around the time color correction was enabled for Android. msarett@ any clues as to why?
I'm actually the one who added this test - and I'm fine with removing it.

I'm not extremely familiar with the LayoutTest framework on Android, but it seems a real challenge to add a test there that isn't flaky...

The BGRA/RGBA swap is pretty strange.  I don't know how to explain that - I've not seen that outside of LayoutTests.
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/858bfb659e50d2d2debebd92847c59b884848ae4

commit 858bfb659e50d2d2debebd92847c59b884848ae4
Author: schenney <schenney@chromium.org>
Date: Wed Apr 05 21:52:46 2017

Move Paint Team TestExpectations lines into appropriate sections

This completes a review of all the Paint Team owned layout test
failures. With this patch tests are grouped so we know which ones
might be worth investigating in the future and so we can more
easily incorporate new failures.

There is one outstanding patch to be comnitted rebasing one set
of tests.

TBR=chrishtr@chromium.org
BUG=309675,504613, 517449 , 549742 , 602110 , 606302 ,614910, 676561 

Review-Url: https://codereview.chromium.org/2803633005
Cr-Commit-Position: refs/heads/master@{#462231}

[modify] https://crrev.com/858bfb659e50d2d2debebd92847c59b884848ae4/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/858bfb659e50d2d2debebd92847c59b884848ae4/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Pri-1 BugSource-Chromium PaintTeamTriaged-20170427 Pri-2
Status: WontFix (was: Assigned)
We decided not to fix this.

Sign in to add a comment