New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676560 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security

Blocking:
issue 468240



Sign in to add a comment

Bad-cast to blink::TraceWrapperBase from invalid vptr;blink::ScriptWrappableVisitor::dispatchTraceWrappers;blink::ScriptWrappableVisitor::AdvanceTracing

Project Member Reported by ClusterFuzz, Dec 22 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6671083655921664

Fuzzer: therealholden_worker
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x000000000000
Crash State:
  Bad-cast to blink::TraceWrapperBase from invalid vptr
  blink::ScriptWrappableVisitor::dispatchTraceWrappers
  blink::ScriptWrappableVisitor::AdvanceTracing
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_cfi_chrome&range=439808:439921

Minimized Testcase (4.46 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97Ccq18-IHPgI8ZZUa1n3i3LiOyn3ogJmdC1wwllsvCaqXy41bYIKforWldceQ_EZ05TvvquIYQnUs5-alazFKkvsnuMbxRhMFgpEWs2HzrIbsZLGbwGA5YScbX2qab8Ly1mrYkUS4W7Q2jmZzJM9ahGQ668w?testcase_id=6671083655921664

Additional requirements: Requires HTTP

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Dec 22 2016

Labels: M-57
Project Member

Comment 2 by sheriffbot@chromium.org, Dec 22 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 22 2016

Labels: Pri-1
Components: Blink>JavaScript Blink
Owner: mlippautz@chromium.org
Status: Assigned (was: Untriaged)
Hi Michael,

Assigning this security bug to you, due to your CL that touches heap tracing: https://chromium.googlesource.com/v8/v8/+/17318bbd393f8e1b60a00d1cb1fb57befdec0874

CC'ing sigbjornf@opera as well who also touched these areas: https://chromium.googlesource.com/chromium/src/+/2c7d13f7694fa208d996947731eacd152902ebdd


This is related to v8 heap allocation on non-windows.  A CFI exception during blink::ScriptWrappableVisitor while stack tracing.  Crash-type says "bad cast", but have a look at the stack in the detailed report and the run-time error.

Feel free to adjust labels and re-assign as appropriate.

Thanks!
Blocking: 468240
Components: -Blink Blink>JavaScript>GC
Thanks, that looks like one of the remaining rare crashers one crash/. Will have a look as soon as possible.

I doubt it's security status though since it looks like we crash because of a nullptr, which obviously is a bad cast.

Also, it's very likely not related to sigbjornf@ CLs.
Cc: haraken@chromium.org
Cc: mlippautz@chromium.org
 Issue 676850  has been merged into this issue.
Project Member

Comment 8 by ClusterFuzz, Dec 24 2016

ClusterFuzz has detected this issue as fixed in range 440627:440645.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6671083655921664

Fuzzer: therealholden_worker
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x000000000000
Crash State:
  Bad-cast to blink::TraceWrapperBase from invalid vptr
  blink::ScriptWrappableVisitor::dispatchTraceWrappers
  blink::ScriptWrappableVisitor::AdvanceTracing
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_cfi_chrome&range=439808:439921
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_cfi_chrome&range=440627:440645

Minimized Testcase (4.46 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97Ccq18-IHPgI8ZZUa1n3i3LiOyn3ogJmdC1wwllsvCaqXy41bYIKforWldceQ_EZ05TvvquIYQnUs5-alazFKkvsnuMbxRhMFgpEWs2HzrIbsZLGbwGA5YScbX2qab8Ly1mrYkUS4W7Q2jmZzJM9ahGQ668w?testcase_id=6671083655921664

Additional requirements: Requires HTTP

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Dec 24 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5677163530682368 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Dec 24 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -reward-topanel reward-0
Labels: -ReleaseBlock-Beta
Project Member

Comment 13 by sheriffbot@chromium.org, Apr 1 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment