New issue
Advanced search Search tips

Issue 676552 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocked on:
issue 676416



Sign in to add a comment

1.5% regression in memory.top_10_mobile at 439400:439418

Project Member Reported by kouhei@google.com, Dec 22 2016

Issue description

See the link to graphs below.
 

Comment 1 by kouhei@google.com, Dec 22 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=676552

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg78qiugoM


Bot(s) for this bug's original alert(s):

android-nexus6
Blockedon: 676416
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Apr 10 2017

Cc: ssid@chromium.org
Owner: ssid@chromium.org

=== Auto-CCing suspected CL author ssid@chromium.org ===

Hi ssid@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : ssid
  Commit : 3583cfe73e8f0ac811ad2e978fcd1cfaebce6ba6
  Date   : Mon Dec 19 04:16:15 2016
  Subject: [memory-infra] Implement PollFastMemoryTotal in ProcessMetricsMemoryDumpProvider.

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:malloc:effective_size_avg/load_search/load_search_ebay

Revision             Result                   N
chromium@439388      32765113 +- 1036488      9      good
chromium@439402      32817743 +- 318784       6      good
chromium@439404      32741852 +- 778153       6      good
chromium@439405      33325372 +- 384346       9      bad       <--
chromium@439406      33323585 +- 438809       6      bad
chromium@439409      33300487 +- 280640       6      bad
chromium@439415      33329320 +- 244146       6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.search.ebay system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8982659697801992528

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5028228069064704


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
Status: WontFix (was: Assigned)
ssid: sounds like this was expected? WontFix-ing but please reopen if not.

Comment 13 by ssid@chromium.org, Sep 14 2017

Yes sorry, missed it. It will probably increase memory only when tracing.

Sign in to add a comment