Was this part of the settings hardening fixes?

@georgesak

Friendly ping. Our enterprise customer reported they cannot set Chrome browser as their default browser, as using master_preferences is the only way to do that on OS X. (we don't have the policy yet.)
As it might be a wide-spread issue for Chrome deployment on OS X, I would be grateful if you could prioritize this issue. Thanks!

+privard, robertshield to comment on #3

+shrike

How is this done on windows? I'm trying to understand if this is a bug with the settings hardening (ie, this is the correct practice but it's now broken) or if there is something else they should be doing.

Settings hardening isn't currently enabled on Mac, so while possible I doubt it's that. 

I don't know much about how master_preferences get loaded on Mac, Greg might.

Ok, poked at this a bit, the only Mac-specific code seems to be in looking up the master preferences file here (https://codesearch.chromium.org/chromium/src/chrome/browser/mac/master_prefs.mm). 

The rest (https://codesearch.chromium.org/chromium/src/chrome/browser/first_run/first_run.cc?rcl=0&l=467) looks like it uses the same preferences loading code as on Windows, so.. in theory it should work there too. I don't have a Mac dev environment set up to step through, but I don't see any obvious platform-specific preferences changes that would break this only on Mac. 

I have nothing to add beyond what Robert said. It looks like SetAsDefaultBrowser in shell_integration_mac.mm should be getting called by first_run.cc's ProcessDefaultBrowserPolicy. Note that this is only for users going through first-run.

Assigning to George for further updates.

Hi team,

Are there any updates here?. 

Thanks in advance.

Added RVG as there are links of cs.

I received update request from the customer.

There are 3 calls from SetAsDefaultBrowser().
https://codesearch.chromium.org/chromium/src/chrome/browser/shell_integration_mac.mm?rcl=c88786898b6f37bf802e1db5aee843f3b27c1627&l=55

1. 'if (!CanSetAsDefaultBrowser())'
CanSetAsDefaultBrowser() will return SET_DEFAULT_UNATTENDED when the browser isn't Canary. Thus, it will be always 'false'.
https://codesearch.chromium.org/chromium/src/chrome/browser/shell_integration_mac.mm?rcl=c88786898b6f37bf802e1db5aee843f3b27c1627&l=92

2. NSString* identifier = [base::mac::OuterBundle() bundleIdentifier];
'base::mac::OuterBundle()' won't return nil, because at least, it will return [NSBundle mainBundle].
https://codesearch.chromium.org/chromium/src/base/mac/bundle_locations.mm?rcl=c88786898b6f37bf802e1db5aee843f3b27c1627&l=28

Need to check if bundleIdentifier is nil.
https://codesearch.chromium.org/chromium/src/build/config/mac/BuildInfo.plist?rcl=c88786898b6f37bf802e1db5aee843f3b27c1627&l=21

3. [[NSWorkspace sharedWorkspace] setDefaultBrowserWithIdentifier:identifier];
'setDefaultBrowserWithIdentifier' is defined as extension in NSWorkspace+Utils.h.
The "NSWorkspace+Utils.h" is loaded by #import instead of #include. Need to check if it is loaded properly.
https://codesearch.chromium.org/chromium/src/chrome/browser/shell_integration_mac.mm?rcl=c88786898b6f37bf802e1db5aee843f3b27c1627&l=12

soushi: Chromium is open source.

Friendly bump.

Do you guys need any specific info that we might provide?

This looks like a change in the OS that prevents us from silently changing the default browser. From OS X 10.10 and on, trying to change the browser results in a popup that explicitly asks the user to validate the change.

@1: Does the first run trigger that popup or nothing at all?

Hello!
This bug is receiving this notice because there has been no acknowledgment of its existence in quite a bit of time
- If you are currently working on this bug, please provide an update.
- If you are currently affected by this bug, please update with your current symptoms and relevant logs.

If there has been no updates provided by EOD Wednesday, 12/12/18 (5pm EST), this bug will be archived and can be re-opened at any time deemed necessary.

Thank you!

Due to lack of action this bug has been Archived. If work is still being done on this issue or you are still experiencing this issue please feel free to re-open with the appropriate information.