New issue
Advanced search Search tips

Issue 676538 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Checkboxes are not working right

Reported by himanshu...@gmail.com, Dec 22 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36

Steps to reproduce the problem:
1. Place a checkbox in a widget. (I did in the title bar of a Title Pane)
2. Click on the checkbox.
3. The checkbox does not get checked.

What is the expected behavior?
The checkbox should get checked

What went wrong?
The checkbox behaviour is all wrong.

Did this work before? Yes 54.0

Chrome version: 55.0.2883.87  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 24.0 r0
 
Labels: M-55 Needs-Bisect
Cc: kkaluri@chromium.org
Labels: Needs-Feedback
himanshugarg834@ in order to triage this issue could you please help us with the  sample html page or test url, so that we can test this scenario from our end.

Thank You...
Hi,

Please go to this link:
https://jsfiddle.net/dkc1esdL/3/

I have created a sample fiddle with a DOJO Title Pane and HTML checkbox. I have also added the required logging statements on clicking of the checkbox.

To reproduce the issue:
1. Go to the link specified above.
2. Click on the checkbox placed in the title bar of the title pane.
3. Open console and observe the logging statements.

Also attaching the screenshots of the logging statements on two different versions of Chrome. The two different versions are 54.0.2840.99 and 55.0.2883.87.

The behaviour is correct on 54.0.2840.99 as you can see from the logging statements in screen shot.
54.0.2840.99.JPG
111 KB View Download
55.0.2883.87.PNG
136 KB View Download
Also, there is one more issue with DOJO checkboxes (I think it is the same as the one mentioned above). The behaviour of Dijit Checkboxes is has been inverted with the latest update.

To test, please go to this link:
https://jsfiddle.net/dkc1esdL/1/

Steps to reproduce are the same as mentioned above. And results are also the same, the behaviour is correct on 54.0.2840.99 and inverted on 55.0.2883.87.

Thank you.
Components: Blink>Forms>Checkbox
Labels: -Needs-Feedback -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable OS-Linux OS-Mac
Owner: mustaq@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on Windows 10, Ubuntu 14.04 and Mac 10.12.2 on chrome stable version 55.0.2883.87 and also in current canary version #57.0.2962.0
Issue is broken in M55. 

Bisect Info:
===========

Good build : 55.0.2875.0,  Revision Range -421703
Bad build  : 55.0.2876.0,  Revision Range -421986

After executing the per-revision-bisect script, i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/bd027238e7f3d3c8096c1a62e9063d8cbf5d8a80..902a3d6303dfbfd49a24173777afcb4b70234a17

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/902a3d6303dfbfd49a24173777afcb4b70234a17

From the above CL suspecting the below change
---------------------------
Review-Url: https://codereview.chromium.org/2375493005

mustaq@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Comment 6 by tkent@chromium.org, Dec 26 2016

Components: -UI Blink>Input
Labels: -Pri-2 -M-55 M-56 Pri-1
Just to update, still able to reproduce the issue on windows 7 using chrome version 57.0.2969.0.

mustaq@ could you please look into this issue.

Thanks,
Labels: Hotlist-Input-Dev
Looks like a double event handling somewhere in dojo for this particular demo:
- All DOJO checkboxes seem working fine, both the UI and the "checked" values:
https://dojotoolkit.org/documentation/tutorials/1.10/checkboxes/demo/CheckBox.html

- In the demo in this bug, moving the checkbox out of the titlePane also makes it work.


This looks like a Dojo implementation issue: the checkbox works fine when not placed inside a titlePane. The "checked" state somehow depends on both pointerdown & mousedown handlers, which seems non-ideal, and that seems to break inside a titlePane.
Thanks for the update.

FYI: Your bug is labelled as Stable Release Block, please make sure to land the fix and get it merged into the release branch ASAP so we can take it for next week's Beta release for Desktop. Thank you!
Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
Status: ExternalDependency (was: Assigned)
Seems there is nothing to fix in Chrome. Dojo team is aware of the issue on their side for a while already, here is their bug:
  https://bugs.dojotoolkit.org/ticket/18932

We will keep this bug open to track the Dojo fix. Removing release-blocker tag.
Labels: PointerEvent

Comment 13 by dyla...@gmail.com, Jan 12 2017

Looking at this more, it looks like it was fixed back in Dojo 1.10.5.

See http://jsfiddle.net/dylan/k5agxn2g/1/ for example, which seems to work as expected in Chrome 55.
Status: WontFix (was: ExternalDependency)
Thanks Dylan for confirming the Dojo fix.

Sign in to add a comment