New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676537 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Layout Test fast/css/imageTileOpacity.html is flaky

Project Member Reported by yhirano@chromium.org, Dec 22 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/239e15c575095c7215e9c61fdc5b6d7b32aabd2b

commit 239e15c575095c7215e9c61fdc5b6d7b32aabd2b
Author: yhirano <yhirano@chromium.org>
Date: Thu Dec 22 04:20:12 2016

Mark fast/css/imageTileOpacity.html as flaky

BUG= 676537 
TBR=kojii@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2600433002
Cr-Commit-Position: refs/heads/master@{#440338}

[modify] https://crrev.com/239e15c575095c7215e9c61fdc5b6d7b32aabd2b/third_party/WebKit/LayoutTests/TestExpectations

Status: Available (was: Untriaged)
Labels: -Pri-3 OS-Mac Pri-2
Labels: Update-Fortnightly

Comment 5 by suzyh@chromium.org, Apr 10 2017

Looking on Linux, the failure appears to be a font difference between the test output and the reference image. Just eyeballing the test, it's not obvious what the correct output is supposed to look like.
Owner: nainar@chromium.org
Status: Assigned (was: Available)

Comment 7 by nainar@chromium.org, May 24 2017

Sorry no update haven't worked on this. 

Comment 8 by nainar@chromium.org, Jun 14 2017

No progress at the moment. 

Comment 9 by nainar@chromium.org, Jul 18 2017

CL deleting this test with reasoning here: https://chromium-review.googlesource.com/c/575798/

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/137de62239c67d4a3ced473d1fecb916e6459fbc

commit 137de62239c67d4a3ced473d1fecb916e6459fbc
Author: Naina Raisinghani <nainar@chromium.org>
Date: Wed Jul 19 02:50:54 2017

Delete obsolete flaky test imageTileOpacity.html

The test imageTileOpacity.html is currently marked as flaky. It was
added in 2004 to test Webkit specific code which to the best of my
codesearch I cannot find a reference to. This makes me think that the
test is currently not adding value or testing any code. We already
have tests that test opacity for the generic code path.

Hence I am deleting the test and all the expectations and references to
the test.

The test was added in: https://chromium.googlesource.com/chromium/src/+/6b3386a94eab6c43c8b2fc6a3488560b71ce8a01

Bug:  676537 
Change-Id: I0f11aa58fd337bb3991cb65a41718f1a3e9761eb
Reviewed-on: https://chromium-review.googlesource.com/575798
Reviewed-by: Mike Lawther <mikelawther@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487728}
[modify] https://crrev.com/137de62239c67d4a3ced473d1fecb916e6459fbc/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/137de62239c67d4a3ced473d1fecb916e6459fbc/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/f6fd25d5826f1a62010b08037eb50c396b05d7a2/third_party/WebKit/LayoutTests/fast/css/button_center.png
[delete] https://crrev.com/f6fd25d5826f1a62010b08037eb50c396b05d7a2/third_party/WebKit/LayoutTests/fast/css/imageTileOpacity.html
[delete] https://crrev.com/f6fd25d5826f1a62010b08037eb50c396b05d7a2/third_party/WebKit/LayoutTests/platform/linux/fast/css/imageTileOpacity-expected.png
[delete] https://crrev.com/f6fd25d5826f1a62010b08037eb50c396b05d7a2/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/css/imageTileOpacity-expected.png
[delete] https://crrev.com/f6fd25d5826f1a62010b08037eb50c396b05d7a2/third_party/WebKit/LayoutTests/platform/mac/fast/css/imageTileOpacity-expected.png
[delete] https://crrev.com/f6fd25d5826f1a62010b08037eb50c396b05d7a2/third_party/WebKit/LayoutTests/platform/mac/fast/css/imageTileOpacity-expected.txt
[delete] https://crrev.com/f6fd25d5826f1a62010b08037eb50c396b05d7a2/third_party/WebKit/LayoutTests/platform/win/fast/css/imageTileOpacity-expected.png
[delete] https://crrev.com/f6fd25d5826f1a62010b08037eb50c396b05d7a2/third_party/WebKit/LayoutTests/platform/win/fast/css/imageTileOpacity-expected.txt

Status: Fixed (was: Assigned)

Sign in to add a comment