New issue
Advanced search Search tips

Issue 676491 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 693792



Sign in to add a comment

[W3C auto-import] Very large files aren't uploaded.

Project Member Reported by qyears...@chromium.org, Dec 21 2016

Issue description

If any very large tests are added to web-platform-tests, they may not be accepted by Rietveld (or Gerrit in the future), and may be skipped.

Example upstream commit that adds a very large file:

https://github.com/w3c/web-platform-tests/commit/acc1d24ec6f0eae7f857e73cb76a853b2919038d

domxpath/xml_xpath_tests.xml was never uploaded since Rietveld rejected it as too large.
 
Labels: TE-NeedsTriageHelp
Cc: jeffcarp@chromium.org
Labels: -TE-NeedsTriageHelp
Status: Available (was: Unconfirmed)
Summary: [W3C auto-import] Very large files aren't uploaded. (was: W3C auto-import: very large files aren't uploaded.)
Components: Blink>Infra>Predictability
Components: -Blink>Infra
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c8e22a0a0e02013b973443aada2975d7d915e40

commit 7c8e22a0a0e02013b973443aada2975d7d915e40
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Jan 05 01:45:40 2017

Skip importing domxpath/xml_xpath_runner.html due to large file.

Currently, the large (2.2MB) file domxpath/xml_xpath_tests.xml
hasn't been imported because the auto-importer can't handle it
because Rietveld can't handle very large text files.

The auto-importer marked this test as fail, but instead we should
skip trying to import it for now since the reason why it can't
be run is not a problem with the test itself, but a problem with
the importer.

BUG= 676491 

Review-Url: https://codereview.chromium.org/2618563002
Cr-Commit-Position: refs/heads/master@{#441550}

[modify] https://crrev.com/7c8e22a0a0e02013b973443aada2975d7d915e40/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/7c8e22a0a0e02013b973443aada2975d7d915e40/third_party/WebKit/LayoutTests/W3CImportExpectations
[delete] https://crrev.com/345b473979542dc15d4a4780f9b24a557a7f11fa/third_party/WebKit/LayoutTests/imported/wpt/domxpath/xml_xpath_runner.html

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e71e4c5f1355e8937d59728476ef1e1eef170b06

commit e71e4c5f1355e8937d59728476ef1e1eef170b06
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Jan 11 10:13:31 2017

Add domxpath/xml_xpath_tests.xml to list of files to skip when updating WPT.

This file is too large to upload to Rietveld. This is just a quick fix CL for this particular case of a large file.

NOEXPORT=true
BUG= 676491 

Review-Url: https://codereview.chromium.org/2619163005
Cr-Commit-Position: refs/heads/master@{#442841}

[modify] https://crrev.com/e71e4c5f1355e8937d59728476ef1e1eef170b06/third_party/WebKit/LayoutTests/W3CImportExpectations

Alright, now large files failing to upload should not block the importer, but it's still the case that we can't import large files, and domxpath/xml_xpath_tests.xml is skipped.
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/531db5a7f975086598bf966a1d9186a00a537f9b

commit 531db5a7f975086598bf966a1d9186a00a537f9b
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Jan 13 21:36:30 2017

Revert of On W3C test import, always skip large files that may fail to upload. (patchset #1 id:1 of https://codereview.chromium.org/2628913003/ )

Reason for revert:
I believe that this didn't actually solve the problem properly -
In the latest import, some tests are failing because they depend on files that are too large that were already checked in (in media/*), and after this change, the files are removed but the tests are still imported, causing this failure: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7870/steps/update%20wpt/logs/stdio

Original issue's description:
> On W3C test import, always skip large files that may fail to upload.
>
> This CL also removes a skip from W3CImportExpectations that should no
> longer be necessary.
>
> BUG= 676491 
>
> Review-Url: https://codereview.chromium.org/2628913003
> Cr-Commit-Position: refs/heads/master@{#443163}
> Committed: https://chromium.googlesource.com/chromium/src/+/dff0c445aee94798e03534796a0af11eb459d3a9

TBR=jeffcarp@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 676491 

Review-Url: https://codereview.chromium.org/2630813002
Cr-Commit-Position: refs/heads/master@{#443678}

[modify] https://crrev.com/531db5a7f975086598bf966a1d9186a00a537f9b/third_party/WebKit/LayoutTests/W3CImportExpectations
[modify] https://crrev.com/531db5a7f975086598bf966a1d9186a00a537f9b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py
[modify] https://crrev.com/531db5a7f975086598bf966a1d9186a00a537f9b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py
[modify] https://crrev.com/531db5a7f975086598bf966a1d9186a00a537f9b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
[modify] https://crrev.com/531db5a7f975086598bf966a1d9186a00a537f9b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

Blockedon: 693792
I expect this to be resolved after migrating to Gerrit (I think).
Owner: qyears...@chromium.org
Status: Assigned (was: Available)
To do: Try to enable import of this file (domxpath/xml_xpath_tests.xml) and verify whether Gerrit can handle it.
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70a0d8804002266d4d4641219208149c157343de

commit 70a0d8804002266d4d4641219208149c157343de
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Mar 01 03:46:17 2017

W3C test importer: Unskip large files in domxpath/.

In theory since imports should now be done by Gerrit, this issue may be resolved.

BUG= 676491 

Review-Url: https://codereview.chromium.org/2724483002
Cr-Commit-Position: refs/heads/master@{#453833}

[modify] https://crrev.com/70a0d8804002266d4d4641219208149c157343de/third_party/WebKit/LayoutTests/W3CImportExpectations

Status: Fixed (was: Assigned)
Fixed since it has now been verified that Gerrit can handle these large files.
Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability

Sign in to add a comment