Issue 676488 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	lukasza@chromium.org
Closed:	Dec 2016
Cc:	danakj@chromium.org dcheng@chromium.org █ nasko@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	1
Type:	Bug
clang

Blocking:
issue 578344

rewrite_to_chrome_style should rewrite |to##macroArg()| into |To##macroArg()|

Project Member Reported by lukasza@chromium.org, Dec 21 2016

Issue description

Hopefully supporting 
  |to##macroArg()| -> |To##macroArg()|
rewrite will help with the rather broad issue of macro-defined is/to conversion function in Blink.

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d56282cc3b00bb07ebf0261f7185368b2456dce

commit 7d56282cc3b00bb07ebf0261f7185368b2456dce
Author: lukasza <lukasza@chromium.org>
Date: Tue Dec 27 20:14:27 2016

Support rewriting |to##macroArg()| into |To##macroArg()|.

BUG= 676488 

Review-Url: https://codereview.chromium.org/2592273002
Cr-Commit-Position: refs/heads/master@{#440778}

[modify] https://crrev.com/7d56282cc3b00bb07ebf0261f7185368b2456dce/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
[modify] https://crrev.com/7d56282cc3b00bb07ebf0261f7185368b2456dce/tools/clang/rewrite_to_chrome_style/tests/macros-expected.cc
[modify] https://crrev.com/7d56282cc3b00bb07ebf0261f7185368b2456dce/tools/clang/rewrite_to_chrome_style/tests/macros-original.cc

Comment 2 by lukasza@chromium.org, Dec 28 2016

Status: Fixed (was: Started)

This should be fixed now.  Let's treat any remaining issues as separate bugs.

►

Issue 676488 link

Issue metadata

rewrite_to_chrome_style should rewrite |to##macroArg()| into |To##macroArg()|

Issue description

Comment 1 by bugdroid1@chromium.org, Dec 27 2016

Comment 1 Deleted

Comment 2 by lukasza@chromium.org, Dec 28 2016

Comment 2 Deleted

Sign in to add a comment