New issue
Advanced search Search tips

Issue 676467 link

Starred by 2 users
Status: Verified
Owner:
dtseng@chromium.org
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

ChromeVox doesn't work when enabled in lock screen

Project Member Reported by dmazz...@chromium.org, Dec 21 2016 
Chrome Version: 57
OS: Chrome OS

Start Chrome OS from the login screen

Sign in, turn ChromeVox off if it was on before.

Lock the screen with Search+L.

Now press Ctrl+Alt+Z to turn on ChromeVox. Speech starts, but the panel doesn't work and ChromeVox keyboard shortcuts (like Search+Left/Right to navigate or Control to silence speech) don't work.

It works fine if ChromeVox was enabled before you entered the lock screen, the issue is just when you enable it for the first time from the lock screen.

Kevin and I ran into this while testing the fix to  bug 669413 , but it appears unrelated. David, could you take a look?

Comment 1 by dtseng@chromium.org, Jan 5 2017 

It seems like this is related to your refactoring of accessibility manager. If I enable ChromeVox on the lock screen, I'm getting the system profile. However, if I lock if ChromeVox enabled, the events (including tts) are being directed to the signed in profile.

Can dig in.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4702f8e80cde7762dc897963ab69080e38093b97

commit 4702f8e80cde7762dc897963ab69080e38093b97
Author: dtseng <dtseng@chromium.org>
Date: Wed Jan 11 18:54:12 2017

Fix AccessibilityExtensionLoader's handling of locked screen

Previously, accessibility extensions required content scripts to access locked screen UI. With the introduction of chrome.automation, this is no longer necessary. An extension running in the signed in profile can easily access locked screen UI.

We therefore can:
- remove enabling an extension in the locked screen ui's profile (e.g. adding ChromeVox as a component extension).
- stop injection of content scripts into the locked screen's web ui.

TEST=navigate to locked screen with ChromeVox on. Verify things work. Toggle ChromeVox off and on. Verify things still work.
BUG= 676467 , 611736 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2617633004
Cr-Commit-Position: refs/heads/master@{#442970}

[modify] https://crrev.com/4702f8e80cde7762dc897963ab69080e38093b97/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/4702f8e80cde7762dc897963ab69080e38093b97/chrome/browser/chromeos/accessibility/accessibility_extension_loader.cc
[modify] https://crrev.com/4702f8e80cde7762dc897963ab69080e38093b97/chrome/browser/chromeos/accessibility/accessibility_extension_loader.h
[modify] https://crrev.com/4702f8e80cde7762dc897963ab69080e38093b97/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/4702f8e80cde7762dc897963ab69080e38093b97/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/4702f8e80cde7762dc897963ab69080e38093b97/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
[modify] https://crrev.com/4702f8e80cde7762dc897963ab69080e38093b97/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h
[modify] https://crrev.com/4702f8e80cde7762dc897963ab69080e38093b97/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
[modify] https://crrev.com/4702f8e80cde7762dc897963ab69080e38093b97/chrome/browser/resources/chromeos/chromevox/cvox2/background/keyboard_handler.js
[delete] https://crrev.com/eed4ea8fb01d92a623f3d912d3ea904e7740e13f/chrome/test/data/extensions/platform_apps/web_view/chromevox_injection/guest.html
[delete] https://crrev.com/eed4ea8fb01d92a623f3d912d3ea904e7740e13f/chrome/test/data/extensions/platform_apps/web_view/chromevox_injection/main.html
[delete] https://crrev.com/eed4ea8fb01d92a623f3d912d3ea904e7740e13f/chrome/test/data/extensions/platform_apps/web_view/chromevox_injection/main.js
[delete] https://crrev.com/eed4ea8fb01d92a623f3d912d3ea904e7740e13f/chrome/test/data/extensions/platform_apps/web_view/chromevox_injection/manifest.json
[delete] https://crrev.com/eed4ea8fb01d92a623f3d912d3ea904e7740e13f/chrome/test/data/extensions/platform_apps/web_view/chromevox_injection/test.js
[modify] https://crrev.com/4702f8e80cde7762dc897963ab69080e38093b97/extensions/browser/guest_view/web_view/web_view_guest.cc
[modify] https://crrev.com/4702f8e80cde7762dc897963ab69080e38093b97/extensions/browser/guest_view/web_view/web_view_guest_delegate.h

Comment 3 by dtseng@chromium.org, Jan 11 2017

Status: fixed (was: Assigned)

Comment 4 by pbath...@chromium.org, Jan 20 2017

Status: Verified (was: Fixed)
verified on 57.0.2984.0
►

Sign in to add a comment