New issue
Advanced search Search tips

Issue 676454 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Getting Started Chrome Demo doesn't execute properly

Reported by briguy1...@gmail.com, Dec 21 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36 Edge/14.14393

Steps to reproduce the problem:
1. Follow Steps at https://developer.chrome.com/extensions/getstarted 
2. Load extension
3. Go to youtube and run

What is the expected behavior?
That the image for YouTube showed up 

What went wrong?
Get the error message"Cannot display image. No response from Google Image search!

Did this work before? N/A 

Chrome version: 51.0.2704.79  Channel: n/a
OS Version: 10.0
Flash Version: Shockwave Flash 24.0 r0

Attached is my code. All I did was download the files that I was told and ran. If there's some stupid error I did, I apologize as I'm not asking for you to debug my code, but I think that the tutorial suggested is either out of date with the API, or there's just wrong info on the tutorial. For exmple, when you download the .html file it downloads it as a .htm file.
 
HelloChrome.zip
4.1 KB Download
Labels: Needs-Milestone
Adding 'Needs-Milestone' label, TE will check the issue and update the bug with comments & tag with respective Mstone

Comment 2 by ajha@chromium.org, Dec 29 2016

Cc: ajha@chromium.org
Components: Platform>Extensions
Labels: -Needs-Milestone M-57 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on the latest canary(57.0.2966.0) and the same behavior is seen on older chrome version(30.0.1549.0) across Windows-10, Mac OS 10.12.2 and Linux Ubuntu 14.04.

Not sure if the issue is with code, hence marking this as Untriaged and labelling it properply for someone from the respective team to have a look at this.
Components: -Platform>DevTools

Comment 4 by drbl...@gmail.com, Mar 18 2017

I had the same issue. It would seem that the extension produced in the tutorial attempts to use a deprecated api. Specifically it attempts to use https://ajax.googleapis.com/ajax/services/search/images which is deprecated. I would suggest the owner of the tutorial therefore change the code in line 60 of popup.js
Owner: karandeepb@chromium.org
Status: Assigned (was: Untriaged)
Labels: Hotlist-GoodFirstBug
This is a good first bug. The extension code lives in https://cs.chromium.org/chromium/src/chrome/common/extensions/docs/examples/tutorials/getstarted/
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b5099fd9146c1b1b1057102838b5a962545f87b

commit 7b5099fd9146c1b1b1057102838b5a962545f87b
Author: Karandeep Bhatia <karandeepb@chromium.org>
Date: Wed Sep 06 20:55:14 2017

Extension Docs: Update the Getting started tutorial.

The extension demoed in the Extensions Getting started tutorial at
https://developer.chrome.com/extensions/getstarted doesn't work since the Google
Image API is deprecated. This CL updates the tutorial and showcases a new
extension which can be used to update the background color of the current page
from a set of pre-defined options. The user's choice of background color is also
remembered. Also update some of the images used in the tutorial.

BUG= 676454 
TEST=Run python chrome/common/extensions/docs/server2/preview.py from the
Chromium src directory. Visit http://localhost:8000/extensions/getstarted.
Ensure the tutorial is correct.

Change-Id: I4b2b9087920c14665563a47fb43db91584fd7698
Reviewed-on: https://chromium-review.googlesource.com/636763
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500083}
[modify] https://crrev.com/7b5099fd9146c1b1b1057102838b5a962545f87b/chrome/common/extensions/docs/examples/tutorials/getstarted/manifest.json
[modify] https://crrev.com/7b5099fd9146c1b1b1057102838b5a962545f87b/chrome/common/extensions/docs/examples/tutorials/getstarted/popup.html
[modify] https://crrev.com/7b5099fd9146c1b1b1057102838b5a962545f87b/chrome/common/extensions/docs/examples/tutorials/getstarted/popup.js
[modify] https://crrev.com/7b5099fd9146c1b1b1057102838b5a962545f87b/chrome/common/extensions/docs/static/images/gettingstarted-preview.png
[modify] https://crrev.com/7b5099fd9146c1b1b1057102838b5a962545f87b/chrome/common/extensions/docs/static/images/gettingstarted-tooltip-after.png
[modify] https://crrev.com/7b5099fd9146c1b1b1057102838b5a962545f87b/chrome/common/extensions/docs/static/images/gettingstarted-tooltip-before.png
[modify] https://crrev.com/7b5099fd9146c1b1b1057102838b5a962545f87b/chrome/common/extensions/docs/templates/articles/getstarted.html

Status: Fixed (was: Assigned)

Sign in to add a comment