go/refactor_build_handling_and_cl_validating_components
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/5b9ee85d8857b9a82f8e1490de5a78bc9630d039 commit 5b9ee85d8857b9a82f8e1490de5a78bc9630d039 Author: Ningning Xia <nxia@chromium.org> Date: Wed Dec 21 22:22:12 2016 Move PatchSeries and HelperPool to patch_series module Refactor validation_pool.py by moving PatchSeries, HelperPool to patch_series.py Move related unit tests to patch_series_unittest.py BUG= chromium:676452 TEST=run_tests; tryjob Change-Id: I3e499f36e8552a4576434e382ed3db9182e6c534 Reviewed-on: https://chromium-review.googlesource.com/422444 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/5b9ee85d8857b9a82f8e1490de5a78bc9630d039/cbuildbot/validation_pool.py [modify] https://crrev.com/5b9ee85d8857b9a82f8e1490de5a78bc9630d039/cbuildbot/validation_pool_unittest.py [add] https://crrev.com/5b9ee85d8857b9a82f8e1490de5a78bc9630d039/cbuildbot/patch_series_unittest [modify] https://crrev.com/5b9ee85d8857b9a82f8e1490de5a78bc9630d039/cbuildbot/stages/sync_stages_unittest.py [add] https://crrev.com/5b9ee85d8857b9a82f8e1490de5a78bc9630d039/cbuildbot/patch_series_unittest.py [modify] https://crrev.com/5b9ee85d8857b9a82f8e1490de5a78bc9630d039/cbuildbot/stages/sync_stages.py [add] https://crrev.com/5b9ee85d8857b9a82f8e1490de5a78bc9630d039/cbuildbot/patch_series.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ef301ab3e71167ac937106c557d11f278aa063d5 commit ef301ab3e71167ac937106c557d11f278aa063d5 Author: Ningning Xia <nxia@chromium.org> Date: Thu Dec 22 00:10:40 2016 Move CL gerrit messages to cl_messages.py Refactor validation_pool by moving ValidationPool.CreateValidationFailureMessage and PaladinMessage to cl_messages.py Move related unit tests to cl_messages_unittest.py BUG= chromium:676452 TEST=run_tests;tryjob Change-Id: I8c88469f43cfeb152284637e012d6718543895c9 Reviewed-on: https://chromium-review.googlesource.com/422584 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/ef301ab3e71167ac937106c557d11f278aa063d5/cbuildbot/validation_pool.py [add] https://crrev.com/ef301ab3e71167ac937106c557d11f278aa063d5/lib/cl_messages_unittest.py [modify] https://crrev.com/ef301ab3e71167ac937106c557d11f278aa063d5/cbuildbot/validation_pool_unittest.py [modify] https://crrev.com/ef301ab3e71167ac937106c557d11f278aa063d5/cbuildbot/stages/sync_stages_unittest.py [add] https://crrev.com/ef301ab3e71167ac937106c557d11f278aa063d5/lib/cl_messages_unittest [add] https://crrev.com/ef301ab3e71167ac937106c557d11f278aa063d5/lib/cl_messages.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/6a718054f5c72252cb84aa7637978be0770c90e7 commit 6a718054f5c72252cb84aa7637978be0770c90e7 Author: Ningning Xia <nxia@chromium.org> Date: Thu Dec 22 18:08:15 2016 Move BuilderStatus from manifest_version to build_status. BUG= chromium:676452 TEST=run_tests Change-Id: I9f7d0c4f2d86d91b882a19f6e23339b793951413 Reviewed-on: https://chromium-review.googlesource.com/423229 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/6a718054f5c72252cb84aa7637978be0770c90e7/scripts/cbuildbot.py [modify] https://crrev.com/6a718054f5c72252cb84aa7637978be0770c90e7/cbuildbot/manifest_version_unittest.py [modify] https://crrev.com/6a718054f5c72252cb84aa7637978be0770c90e7/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/6a718054f5c72252cb84aa7637978be0770c90e7/cbuildbot/manifest_version.py [modify] https://crrev.com/6a718054f5c72252cb84aa7637978be0770c90e7/cbuildbot/stages/completion_stages_unittest.py [modify] https://crrev.com/6a718054f5c72252cb84aa7637978be0770c90e7/scripts/cros_best_revision_unittest.py [modify] https://crrev.com/6a718054f5c72252cb84aa7637978be0770c90e7/cbuildbot/build_status.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/1b4bc6962c88c8b11289b42cc7f4b0528f371150 commit 1b4bc6962c88c8b11289b42cc7f4b0528f371150 Author: Ningning Xia <nxia@chromium.org> Date: Wed Dec 28 01:17:07 2016 Create relevant_changes module to hold all the relevant changes logic. Move current relevant changes query logic to relevant_changes module. More relevant_changes related logic will be added to relevant_changes. 1) Move GetRelevantChangesForSlaves to relevant_changes. 2) Move testGetRelevantChangesForSlaves to relevant_changes_unittest. 3) Add test_GetSlaveMappingAndCLActions relevant_changes_unittest. BUG= chromium:676452 TEST=unit_tests Change-Id: Iae3afd63ecaea6238c7cbf1b665159ad9222bbaa Reviewed-on: https://chromium-review.googlesource.com/424110 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [add] https://crrev.com/1b4bc6962c88c8b11289b42cc7f4b0528f371150/cbuildbot/relevant_changes_unittest [add] https://crrev.com/1b4bc6962c88c8b11289b42cc7f4b0528f371150/cbuildbot/relevant_changes_unittest.py [modify] https://crrev.com/1b4bc6962c88c8b11289b42cc7f4b0528f371150/cbuildbot/stages/completion_stages.py [add] https://crrev.com/1b4bc6962c88c8b11289b42cc7f4b0528f371150/cbuildbot/relevant_changes.py [modify] https://crrev.com/1b4bc6962c88c8b11289b42cc7f4b0528f371150/cbuildbot/stages/completion_stages_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/91988eb813ff7db89b14d51fee70f6b4175e7d64 commit 91988eb813ff7db89b14d51fee70f6b4175e7d64 Author: Ningning Xia <nxia@chromium.org> Date: Thu Feb 09 20:47:32 2017 Move GetSubsysResultForSlaves from completion_stages to relevant_changes 1) relevant_changes.RelevantChanges is a better class to place GetSubsysResultForSlaves, as it will be used to filter ignorable relevant changes by other classes (will need to call it in TriageRelevantChanges for self-detected CQ). 2) make _CanIgnoreFailures public BUG= chromium:676452 TEST=unit_tests Change-Id: I56f87606864f8647b7bd53e89ed9e641e31cf57e Reviewed-on: https://chromium-review.googlesource.com/434157 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/91988eb813ff7db89b14d51fee70f6b4175e7d64/lib/triage_lib_unittest.py [modify] https://crrev.com/91988eb813ff7db89b14d51fee70f6b4175e7d64/cbuildbot/relevant_changes.py [modify] https://crrev.com/91988eb813ff7db89b14d51fee70f6b4175e7d64/cbuildbot/relevant_changes_unittest.py [modify] https://crrev.com/91988eb813ff7db89b14d51fee70f6b4175e7d64/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/91988eb813ff7db89b14d51fee70f6b4175e7d64/cbuildbot/stages/completion_stages_unittest.py [modify] https://crrev.com/91988eb813ff7db89b14d51fee70f6b4175e7d64/lib/triage_lib.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f342b9520a8906f3390f2e7bf6857fd146847315 commit f342b9520a8906f3390f2e7bf6857fd146847315 Author: Ningning Xia <nxia@chromium.org> Date: Tue Feb 21 22:07:38 2017 Move BuilderStatus to lib/builder_status_lib Going to move all operations on BuilderStatus to lib/builder_status_lib. Firstly, move the BuilderStatus class to lib/builder_status_lib in this CL. With this change, manifest_version, build_status and relevant_changes can import this module to access BuilderStatus, so they can avoid circular dependency. BUG= chromium:676452 TEST=unit_tests Change-Id: I1da4bd45e9167a5b3011c71b0051bb00072301eb Reviewed-on: https://chromium-review.googlesource.com/443072 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/f342b9520a8906f3390f2e7bf6857fd146847315/scripts/cbuildbot.py [modify] https://crrev.com/f342b9520a8906f3390f2e7bf6857fd146847315/cbuildbot/manifest_version_unittest.py [modify] https://crrev.com/f342b9520a8906f3390f2e7bf6857fd146847315/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/f342b9520a8906f3390f2e7bf6857fd146847315/cbuildbot/manifest_version.py [modify] https://crrev.com/f342b9520a8906f3390f2e7bf6857fd146847315/cbuildbot/stages/completion_stages_unittest.py [modify] https://crrev.com/f342b9520a8906f3390f2e7bf6857fd146847315/scripts/cros_best_revision_unittest.py [modify] https://crrev.com/f342b9520a8906f3390f2e7bf6857fd146847315/cbuildbot/build_status.py [add] https://crrev.com/f342b9520a8906f3390f2e7bf6857fd146847315/lib/builder_status_lib.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ff0ba6c5ffa544b1862410d072a2fc6c84f472d6 commit ff0ba6c5ffa544b1862410d072a2fc6c84f472d6 Author: Ningning Xia <nxia@chromium.org> Date: Tue Feb 21 22:07:38 2017 builder_status_lib: Add BuilderStatusManager to operate BuilderStatus. Move BuilderStatus operations from manifest_version to builder_status_lib, so that manifest_version, build_status and relevant_changes can access the methods without circular dependency. BUG= chromium:676452 TEST=unit_tests Change-Id: Iae047e0d3d5039d15aa6c99a44254c41f5de8718 Reviewed-on: https://chromium-review.googlesource.com/443505 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/ff0ba6c5ffa544b1862410d072a2fc6c84f472d6/cbuildbot/manifest_version_unittest.py [modify] https://crrev.com/ff0ba6c5ffa544b1862410d072a2fc6c84f472d6/cbuildbot/manifest_version.py [modify] https://crrev.com/ff0ba6c5ffa544b1862410d072a2fc6c84f472d6/scripts/cros_best_revision_unittest.py [add] https://crrev.com/ff0ba6c5ffa544b1862410d072a2fc6c84f472d6/lib/builder_status_lib_unittest.py [modify] https://crrev.com/ff0ba6c5ffa544b1862410d072a2fc6c84f472d6/lib/builder_status_lib.py [modify] https://crrev.com/ff0ba6c5ffa544b1862410d072a2fc6c84f472d6/scripts/cros_best_revision.py [add] https://crrev.com/ff0ba6c5ffa544b1862410d072a2fc6c84f472d6/lib/builder_status_lib_unittest
Comment 1 by bugdroid1@chromium.org
, Dec 27 2016