Issue metadata
Sign in to add a comment
|
[Select-to-Speak] Focus ring should disappear when highlighted object is obscured |
||||||||||||||||||||||
Issue descriptionIf you select a portion of the screen to be read aloud, then navigate to another page, the orange focus ring should disappear and no longer follow where the text would have been on that other page. This is important for the multi-tasking use case, where the user is listening to text being read aloud from one page and continuing onto another page, visually. Similarly, if you scroll the page, it would be nice for the orange highlight to disappear instead of staying in the same place and obstructing the new view.
,
Feb 16 2017
,
Mar 27 2017
,
Apr 21 2017
,
Apr 21 2017
,
Sep 5 2017
,
Sep 20 2017
The focus ring also gets frozen (stops progressing but stays on the screen) when the window is resized. I wonder if this is also related to crbug.com/766875, which also has the focus ring not updating at window / tab state changes?
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/264954b9871cc58ce21993552d0c0af17caccfc1 commit 264954b9871cc58ce21993552d0c0af17caccfc1 Author: Katie Dektar <katydek@google.com> Date: Fri Sep 22 22:44:59 2017 Hides SelectToSpeak focus ring when page is backgrounded. If the SelectToSpeak focus ring is showing on a node which is not in a visible window it will be hidden until the window is visible again. If the node is removed from the tree, SelectToSpeak will stop speaking. Does not yet address minimizing windows. Bug: 676447 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I54b0a3d9b10b713a4dae4458057ffa16c192d490 Reviewed-on: https://chromium-review.googlesource.com/676724 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#503891} [modify] https://crrev.com/264954b9871cc58ce21993552d0c0af17caccfc1/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js [modify] https://crrev.com/264954b9871cc58ce21993552d0c0af17caccfc1/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_unittest.gtestjs [modify] https://crrev.com/264954b9871cc58ce21993552d0c0af17caccfc1/chrome/browser/resources/chromeos/select_to_speak/test_support.js
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4702a5541d87d6f0d4413656ff3065db175c6bbd commit 4702a5541d87d6f0d4413656ff3065db175c6bbd Author: Katie Dektar <katydek@google.com> Date: Mon Oct 02 19:56:52 2017 Better detection of offscreen nodes. Use a HitTest to determine if the node being spoken is in the foreground. This catches the case of a new window being open on top of the spoken node, and the case of minimizing the window containing the current node. Bug: 676447 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic2dfb8143f3503691bbc167df49328906501a6e6 Reviewed-on: https://chromium-review.googlesource.com/691112 Commit-Queue: Katie Dektar <katydek@google.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#505742} [modify] https://crrev.com/4702a5541d87d6f0d4413656ff3065db175c6bbd/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js [modify] https://crrev.com/4702a5541d87d6f0d4413656ff3065db175c6bbd/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_unittest.gtestjs [modify] https://crrev.com/4702a5541d87d6f0d4413656ff3065db175c6bbd/chrome/browser/resources/chromeos/select_to_speak/test_support.js
,
Oct 2 2017
I think this is fixed now.
,
Nov 9 2017
Confirmed that this is working!
,
Nov 9 2017
Confirmed in 64.0.3262.2 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by lpalmaro@chromium.org
, Dec 21 2016