New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676429 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 633979



Sign in to add a comment

"org.chromium.components.minidump_uploader.CrashFileManagerTest#testMinidumpStorageRestrictionsGlobal" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 21 2016

Issue description

"org.chromium.components.minidump_uploader.CrashFileManagerTest#testMinidumpStorageRestrictionsGlobal" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 8 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybwsSBUZsYWtlImRvcmcuY2hyb21pdW0uY29tcG9uZW50cy5taW5pZHVtcF91cGxvYWRlci5DcmFzaEZpbGVNYW5hZ2VyVGVzdCN0ZXN0TWluaWR1bXBTdG9yYWdlUmVzdHJpY3Rpb25zR2xvYmFsDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: -Sheriff-Chromium
Owner: gsennton@chromium.org
Status: Assigned (was: Untriaged)
Created CL to disable flaky test: https://codereview.chromium.org/2597033002
Blocking: 633979
Can't reproduce this locally at all :/. Grrrrr
A couple of notes:
1. all of these failures are on line 474 of CrashFileManagerTest - i.e. they fail during the copying of the one file that brings us over the limit of minidumps to copy.
2. it is slightly weird that only testMinidumpStorageRestrictionsGlobal fails, but not testMinidumpStorageRestrictionsPerUid.
Project Member

Comment 5 by chromium...@appspot.gserviceaccount.com, Dec 22 2016

Labels: Sheriff-Chromium
Detected 11 new flakes for test/step "org.chromium.components.minidump_uploader.CrashFileManagerTest#testMinidumpStorageRestrictionsGlobal". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybwsSBUZsYWtlImRvcmcuY2hyb21pdW0uY29tcG9uZW50cy5taW5pZHVtcF91cGxvYWRlci5DcmFzaEZpbGVNYW5hZ2VyVGVzdCN0ZXN0TWluaWR1bXBTdG9yYWdlUmVzdHJpY3Rpb25zR2xvYmFsDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
Test is disabled, #5 has only old flakes.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/147546fe3012ef02ec8f7a604c6923a77f3f454f

commit 147546fe3012ef02ec8f7a604c6923a77f3f454f
Author: gsennton <gsennton@chromium.org>
Date: Fri Dec 23 10:26:16 2016

[minidump uploader] Enable testMinidumpStorageRestrictionsGlobal

testMinidumpStorageRestrictionsGlobal is currently flaky, it might be
that this flakiness is caused by us not correctly closing file
descriptors during testing - this CL re-enables the test and ensures
that the file-descriptors used are closed correctly.

BUG= 676429 

Review-Url: https://codereview.chromium.org/2592413002
Cr-Commit-Position: refs/heads/master@{#440614}

[modify] https://crrev.com/147546fe3012ef02ec8f7a604c6923a77f3f454f/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashFileManagerTest.java

Status: Fixed (was: Assigned)
This test seems to be passing consistently now :)

Sign in to add a comment