Check handling HW encoder errors in Media Recorder |
||||||
Issue descriptionCurrently HW encoder errors stop media recording and only put DVLOGs. we should consider below cases for error handling: - Throw an error that user can see on JS side. - If the error is spontaneous, try resetting the session. - If the error is persistent, fall back to SW encoder.
,
Jan 18 2017
Bulk move Blink>MediaStream>Recording ---> Blink>MediaRecording
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75762009cfc628424a8af508b91418ce912e0506 commit 75762009cfc628424a8af508b91418ce912e0506 Author: emircan <emircan@chromium.org> Date: Thu Apr 06 05:36:24 2017 Handle HW encoder errors in VideoTrackRecorder This CL adds callback to propagate errors from VEAEncoder to VideoTrackRecorder so that the recording session can be reinitialized. BUG= 676424 TEST=Added unittest. WebRTC quality browser tests now pass on Mac H264. Review-Url: https://codereview.chromium.org/2804843002 Cr-Commit-Position: refs/heads/master@{#462366} [modify] https://crrev.com/75762009cfc628424a8af508b91418ce912e0506/content/renderer/media_recorder/video_track_recorder.cc [modify] https://crrev.com/75762009cfc628424a8af508b91418ce912e0506/content/renderer/media_recorder/video_track_recorder.h [modify] https://crrev.com/75762009cfc628424a8af508b91418ce912e0506/content/renderer/media_recorder/video_track_recorder_unittest.cc
,
Apr 7 2017
,
Apr 7 2017
Adding merge request for 58. This problem exists since 57 and the fix should apply as early as possible.
,
Apr 7 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 7 2017
Your change is approved for M58. Please verify the fix, if all looks good merge ASAP so that it will be picked up for next Beta Release.
,
Apr 11 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 11 2017
Merge is actually done but the bot didn't pick it up somehow.
,
Apr 11 2017
Here is the link for the merge CL: https://codereview.chromium.org/2805353002/ |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mcasas@chromium.org
, Jan 18 2017