New issue
Advanced search Search tips

Issue 676422 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.android_webview.test.AwServiceWorkerClientTest#testFetchResourceLoadingError" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 21 2016

Issue description

"org.chromium.android_webview.test.AwServiceWorkerClientTest#testFetchResourceLoadingError" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 7 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZAsSBUZsYWtlIllvcmcuY2hyb21pdW0uYW5kcm9pZF93ZWJ2aWV3LnRlc3QuQXdTZXJ2aWNlV29ya2VyQ2xpZW50VGVzdCN0ZXN0RmV0Y2hSZXNvdXJjZUxvYWRpbmdFcnJvcgw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by boliu@chromium.org, Dec 21 2016

Components: Mobile>WebView
Labels: OS-Android
Owner: timvolod...@chromium.org
Status: Assigned (was: Untriaged)
sheriffs, feel free to disable

Comment 2 by sgu...@chromium.org, Dec 21 2016

Owner: sgu...@chromium.org

Comment 3 by sgu...@chromium.org, Dec 21 2016

that should be on me. I will look as soon as I have time. 

Comment 4 by boliu@chromium.org, Dec 21 2016

 Issue 676437  has been merged into this issue.
Labels: -Sheriff-Chromium
Disabled test in https://codereview.chromium.org/2597763002/
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 21 2016

Project Member

Comment 7 by chromium...@appspot.gserviceaccount.com, Dec 22 2016

Labels: Sheriff-Chromium
Detected 10 new flakes for test/step "org.chromium.android_webview.test.AwServiceWorkerClientTest#testFetchHttpError". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWQsSBUZsYWtlIk5vcmcuY2hyb21pdW0uYW5kcm9pZF93ZWJ2aWV3LnRlc3QuQXdTZXJ2aWNlV29ya2VyQ2xpZW50VGVzdCN0ZXN0RmV0Y2hIdHRwRXJyb3IM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 8 by boliu@chromium.org, Dec 22 2016

 Issue 676716  has been merged into this issue.

Comment 9 by boliu@chromium.org, Dec 22 2016

Will disable testFetchHttpError too
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 22 2016

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 22 2016

Comment 12 by boliu@chromium.org, Dec 22 2016

Labels: -Sheriff-Chromium
Project Member

Comment 13 by chromium...@appspot.gserviceaccount.com, Dec 23 2016

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "org.chromium.android_webview.test.AwServiceWorkerClientTest#testFetchHttpError". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWQsSBUZsYWtlIk5vcmcuY2hyb21pdW0uYW5kcm9pZF93ZWJ2aWV3LnRlc3QuQXdTZXJ2aWNlV29ya2VyQ2xpZW50VGVzdCN0ZXN0RmV0Y2hIdHRwRXJyb3IM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
Owner: ----
Status: Available (was: Assigned)

Comment 16 by boliu@chromium.org, Sep 26 2017

looped test locally 50 times and no failures. gonna try enabling with RetryOnFailure. I guess someone check back in a couple of weeks and see if there are any flakes on the flakiness dashboard

https://chromium-review.googlesource.com/c/chromium/src/+/685401
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a932e978b9d8ea67e1979290b57345d8e35e64b

commit 3a932e978b9d8ea67e1979290b57345d8e35e64b
Author: Bo Liu <boliu@chromium.org>
Date: Wed Sep 27 01:20:55 2017

aw: Enable testFetchResourceLoadingError with RetryOnFailure

Can't reproduce flake locally by looping test.

Bug:  676422 
Change-Id: I80003faac50a56583bc62264511374262df20c3b
Reviewed-on: https://chromium-review.googlesource.com/685401
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504541}
[modify] https://crrev.com/3a932e978b9d8ea67e1979290b57345d8e35e64b/android_webview/javatests/src/org/chromium/android_webview/test/AwServiceWorkerClientTest.java

Project Member

Comment 19 by bugdroid1@chromium.org, Oct 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/398ac081ca938d99b7b3aa316bfe770878f69c2f

commit 398ac081ca938d99b7b3aa316bfe770878f69c2f
Author: Bo Liu <boliu@chromium.org>
Date: Sun Oct 01 03:58:49 2017

aw: Remove RetryOnFailure for testFetchResourceLoadingError

Looks good on cq for 3 days.

Bug:  676422 
Change-Id: Iaeb0e2b19f29aff99ede51bf9a57f5c6ca715625
Reviewed-on: https://chromium-review.googlesource.com/693115
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505498}
[modify] https://crrev.com/398ac081ca938d99b7b3aa316bfe770878f69c2f/android_webview/javatests/src/org/chromium/android_webview/test/AwServiceWorkerClientTest.java

Status: Fixed (was: Available)
Labels: WebView-Disabled-Test
Status: Verified (was: Fixed)
marking it verified as results are looks green

Sign in to add a comment